From patchwork Sun Dec 26 20:31:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Famulari X-Patchwork-Id: 35668 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 00E0927BBE9; Sun, 26 Dec 2021 20:32:28 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id A328A27BBEB for ; Sun, 26 Dec 2021 20:32:27 +0000 (GMT) Received: from localhost ([::1]:42646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n1aBu-0001i4-Q2 for patchwork@mira.cbaines.net; Sun, 26 Dec 2021 15:32:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35392) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1aBY-0001hP-2j for guix-patches@gnu.org; Sun, 26 Dec 2021 15:32:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:58317) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n1aBW-0000NY-4b for guix-patches@gnu.org; Sun, 26 Dec 2021 15:32:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n1aBW-0007yT-1J for guix-patches@gnu.org; Sun, 26 Dec 2021 15:32:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH v6 1/3] installer: Offer the CUPS printing service on a dedicated page. References: In-Reply-To: Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 26 Dec 2021 20:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.164055070530604 (code B ref 47979); Sun, 26 Dec 2021 20:32:01 +0000 Received: (at 47979) by debbugs.gnu.org; 26 Dec 2021 20:31:45 +0000 Received: from localhost ([127.0.0.1]:41624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1aBF-0007xT-AM for submit@debbugs.gnu.org; Sun, 26 Dec 2021 15:31:45 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:50887) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1aBD-0007xD-I4 for 47979@debbugs.gnu.org; Sun, 26 Dec 2021 15:31:44 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 3903E320024A; Sun, 26 Dec 2021 15:31:37 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 26 Dec 2021 15:31:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; s=mesmtp; bh=V0WbCjdUKX2p+GUYhuVRuYT 7tbkIif30whujIQ0ciSI=; b=tG5IV57Wb+evocHpxVCmkrERi8JJ5iicPuyb1BL JRvHEPLLdT/ogwEsyPQTP1kOjBTCcaE3jeM2+aY3ZGDCYg/6imK9vt/sUljlEJHQ 2hhR2TDFm32UyxP6d7n7nXSkf5rLwG2c0ZZktUOlhfWnZDrVxdUyDa5+085eDjbN I1hc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=V0WbCjdUKX2p+GUYh uVRuYT7tbkIif30whujIQ0ciSI=; b=JymYSiMMSKttGfcDB7xFbFG7d/hPwGr6o iEnQRANixBaECM9JspXr05uYsjxj78fv5FYwKYLNFTawhw6uSQPs9Mq/sfd2R/wC Hdz3PhYDXgujy6B3bK29ZyZRdnP5bCPJgXTIDglUl0BbVmyLcTbp1DVD6bGRw9xd sKp45X2TwCO+YB3KeO4FG+hIhZTTeJf4sESwqvsmih60lEjn/TPweg1HqStaJTdz 2kP/Y+tW2H5KVX5De4VyfVJ0vXJ8qhPfMLWKXAHa50T03Qt6woBIfga3yMC+Nfs3 adb0uYrBFBmaJHEg0Aam/wB4PUlUi2fGyLckmOKCgdQDgQAr5x9xg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddugedgjedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgggfestdekredtre dttdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhi rdhnrghmvgeqnecuggftrfgrthhtvghrnhepteeuiefgleehkeevffevteffueegueduvd egieffveekuefffeetuddvhffhudfhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for <47979@debbugs.gnu.org>; Sun, 26 Dec 2021 15:31:36 -0500 (EST) From: Leo Famulari Date: Sun, 26 Dec 2021 15:31:29 -0500 Message-Id: <18b693c017c779578de0a6a367ebf0eab95c7054.1640550687.git.leo@famulari.name> X-Mailer: git-send-email 2.34.0 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Currently, this page of the installer offers to the user all installer services that are not of the types 'desktop', 'network-management', or 'networking'. Concretely, this means that it offers the CUPS printing service, because that is the only service of a different type defined in the installer. In later commits, we will add some services of a new type, and we only want them to be offered when the user is installing a non-graphical system. At least one of these new services (NTP) is part of %desktop-services. If it were offered on run-other-services-cbt-page, and the user had configured a system using %desktop-services, the user could accidentally add NTP to their services twice, which is an error and would break installation. So, this commit makes the run-other-services-cbt-page be more specific about what services to offer. This allows us to later create a new checkbox page that only runs when %desktop-services is not selected. * gnu/installer/newt/services.scm (run-other-services-cbt-page): Rename to ... (run-printing-services-cbt-page): ... new variable, and select only 'document' services. (run-services-page): Adjust accordingly. * gnu/installer/tests.scm (choose-services): Adjust accordingly. --- gnu/installer/newt/services.scm | 16 +++++++--------- gnu/installer/tests.scm | 2 +- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/gnu/installer/newt/services.scm b/gnu/installer/newt/services.scm index 1af4e7df2d..b4b5219b20 100644 --- a/gnu/installer/newt/services.scm +++ b/gnu/installer/newt/services.scm @@ -68,18 +68,16 @@ (define (run-networking-cbt-page) (condition (&installer-step-abort))))))) -(define (run-other-services-cbt-page) - "Run a page allowing the user to select other services." +(define (run-printing-services-cbt-page) + "Run a page allowing the user to select document services such as CUPS." (let ((items (filter (lambda (service) - (not (member (system-service-type service) - '(desktop - network-management - networking)))) + (eq? 'document + (system-service-type service))) %system-services))) (run-checkbox-tree-page - #:info-text (G_ "You can now select other services to run on your \ + #:info-text (G_ "You can now select the CUPS printing service to run on your \ system.") - #:title (G_ "Other services") + #:title (G_ "Printing and document services") #:items items #:selection (map system-service-recommended? items) #:item->text (compose G_ system-service-name) @@ -123,4 +121,4 @@ (define (run-services-page) (if (null? desktop) (list (run-network-management-page)) '()) - (run-other-services-cbt-page)))) + (run-printing-services-cbt-page)))) diff --git a/gnu/installer/tests.scm b/gnu/installer/tests.scm index 12d1d91608..5d931149b8 100644 --- a/gnu/installer/tests.scm +++ b/gnu/installer/tests.scm @@ -243,7 +243,7 @@ (define desktop-environments '()) (null? desktop-environments) (find choose-network-management-tool? services)) - ((checkbox-list (title "Other services") (text _) + ((checkbox-list (title "Printing and document services") (text _) (items ,services)) (filter choose-other-service? services)))) From patchwork Sun Dec 26 20:31:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Leo Famulari X-Patchwork-Id: 35669 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 430C527BBE9; Sun, 26 Dec 2021 20:32:29 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id A6ADD27BBEC for ; Sun, 26 Dec 2021 20:32:27 +0000 (GMT) Received: from localhost ([::1]:42644 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n1aBu-0001i2-RK for patchwork@mira.cbaines.net; Sun, 26 Dec 2021 15:32:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35390) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1aBY-0001hO-2X for guix-patches@gnu.org; Sun, 26 Dec 2021 15:32:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:58318) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n1aBW-0000NZ-K6 for guix-patches@gnu.org; Sun, 26 Dec 2021 15:32:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n1aBW-0007ya-GS for guix-patches@gnu.org; Sun, 26 Dec 2021 15:32:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH v6 2/3] installer: Recommend 'ntp-service-type' for non-graphical systems. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 26 Dec 2021 20:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.164055070930622 (code B ref 47979); Sun, 26 Dec 2021 20:32:02 +0000 Received: (at 47979) by debbugs.gnu.org; 26 Dec 2021 20:31:49 +0000 Received: from localhost ([127.0.0.1]:41628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1aBI-0007xp-Od for submit@debbugs.gnu.org; Sun, 26 Dec 2021 15:31:49 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:35857) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1aBE-0007xG-O8 for 47979@debbugs.gnu.org; Sun, 26 Dec 2021 15:31:45 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id E88DE3200929; Sun, 26 Dec 2021 15:31:38 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sun, 26 Dec 2021 15:31:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=from:to:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=mesmtp; bh=HBampG0kvWTu9PzRH5owyXrp3UXQO4g2xDHBMB0O5pw=; b=M7jwjHjuHhBZ 5EfOXxOKt3rlWANUPS0do89z7ZCj7GAL4wDH3gpoyQG42vJqSMdCzoi713Zdsuaa PaUnTUH2hJAHQale1Se89NXGK6DX5ixzIhAKNjJ/zjyCkQmAyIWnJFk+g1nkrBef idlE4NOTn9qQQAxhXfDWHUzZFejPMGE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=HBampG0kvWTu9PzRH5owyXrp3UXQO4g2xDHBMB0O5 pw=; b=YxoQCAjywUrwlrBpM7FZnvBoGnUfc88NbX5QDiH3pvaC8IBV3iPMhcEvA fowGbUYhnapxtAPI/WnVs6iHmgTUUgru6qujwMfctoayAz/VZYEVIcf+hnFxNYuW CLNtr80v/14Fq2iG6rb/A/Yk/kklsDIKx3yMVsDeRBvfPgzIR1bd8bHANJGA1Hig FpluS78wDJLX8yO/MII6bZH28njXiLRgNdH/3eYkrNU8XkLGSdIMIDvY6nqikZ9K iYFhUMj64Y2akxQc2KpKsJTkMOq4w9/P1+cBUdf2h6xxM6h/z9a05g1syN+smpp1 BP1zQ1+g2PI1f1YtS7+onzUTH9HNA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddugedgjedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgjfhggtgfgsehtke ertdertdejnecuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhl rghrihdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeefgfeftdfgveetfffhgfekkeeuje egueevieeikeetheffffekvefgffegheffheenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for <47979@debbugs.gnu.org>; Sun, 26 Dec 2021 15:31:38 -0500 (EST) From: Leo Famulari Date: Sun, 26 Dec 2021 15:31:30 -0500 Message-Id: <817dd7dd12e866f87428dcac82fff96e42c4ba77.1640550687.git.leo@famulari.name> X-Mailer: git-send-email 2.34.0 In-Reply-To: <18b693c017c779578de0a6a367ebf0eab95c7054.1640550687.git.leo@famulari.name> References: <18b693c017c779578de0a6a367ebf0eab95c7054.1640550687.git.leo@famulari.name> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches We had several bug reports with a root cause of "the clock was incorrect" from users who used the installer to install a non-graphical Guix System. * gnu/installer/services.scm (%system-services): Add the ntp-service-type. * gnu/installer/newt/services.scm (run-system-administration-cbt-page): New variable. (run-services-page): Use run-system-administration-cbt-page when not installing a desktop. * gnu/installer/tests.scm (choose-services): Add and use a choose-misc-service? procedure. * gnu/tests/install.scm (installation-target-os-for-gui-tests): Add ntp-service-type. --- gnu/installer/newt/services.scm | 25 ++++++++++++++++++++++++- gnu/installer/services.scm | 8 ++++++++ gnu/installer/tests.scm | 10 +++++++++- gnu/tests/install.scm | 5 +++-- 4 files changed, 44 insertions(+), 4 deletions(-) diff --git a/gnu/installer/newt/services.scm b/gnu/installer/newt/services.scm index b4b5219b20..c218825813 100644 --- a/gnu/installer/newt/services.scm +++ b/gnu/installer/newt/services.scm @@ -3,6 +3,7 @@ ;;; Copyright © 2019, 2020 Ludovic Courtès ;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen ;;; Copyright © 2021 Tobias Geerinckx-Rice +;;; Copyright © 2021 Leo Famulari ;;; ;;; This file is part of GNU Guix. ;;; @@ -88,6 +89,27 @@ (define (run-printing-services-cbt-page) (condition (&installer-step-abort))))))) +(define (run-console-services-cbt-page) + "Run a page to select various system adminstration services for non-graphical +systems." + (let ((items (filter (lambda (service) + (eq? 'administration + (system-service-type service))) + %system-services))) + (run-checkbox-tree-page + #:title (G_ "Console services") + #:info-text (G_ "Select miscellaneous services to run on your \ +non-graphical system.") + #:items items + #:selection (map system-service-recommended? items) + #:item->text (compose G_ system-service-name) + #:checkbox-tree-height 5 + #:exit-button-callback-procedure + (lambda () + (raise + (condition + (&installer-step-abort))))))) + (define (run-network-management-page) "Run a page to select among several network management methods." (let ((title (G_ "Network management"))) @@ -119,6 +141,7 @@ (define (run-services-page) (append desktop (run-networking-cbt-page) (if (null? desktop) - (list (run-network-management-page)) + (cons (run-network-management-page) + (run-console-services-cbt-page)) '()) (run-printing-services-cbt-page)))) diff --git a/gnu/installer/services.scm b/gnu/installer/services.scm index 341d8b69c8..94c49307f0 100644 --- a/gnu/installer/services.scm +++ b/gnu/installer/services.scm @@ -3,6 +3,7 @@ ;;; Copyright © 2019 Ludovic Courtès ;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen ;;; Copyright © 2021 Tobias Geerinckx-Rice +;;; Copyright © 2021 Leo Famulari ;;; ;;; This file is part of GNU Guix. ;;; @@ -104,6 +105,13 @@ (define %system-services (packages '((specification->package "nss-certs"))) (recommended? #t)) + ;; Miscellaneous system administration services. + (system-service + (name (G_ "Network time service (NTP), to set the clock automatically")) + (type 'administration) + (recommended? #t) + (snippet '((service ntp-service-type)))) + ;; Network connectivity management. (system-service (name (G_ "NetworkManager network connection manager")) diff --git a/gnu/installer/tests.scm b/gnu/installer/tests.scm index 5d931149b8..39be59f689 100644 --- a/gnu/installer/tests.scm +++ b/gnu/installer/tests.scm @@ -221,7 +221,11 @@ (define* (choose-services port (choose-network-management-tool? (lambda (service) (string-contains service "DHCP"))) - (choose-other-service? (const #f))) + (choose-other-service? (const #f)) + (choose-misc-service? + (lambda (service) + (string-contains service "NTP")))) + "Converse over PORT to choose services." (define desktop-environments '()) @@ -243,6 +247,10 @@ (define desktop-environments '()) (null? desktop-environments) (find choose-network-management-tool? services)) + ((checkbox-list (title "Console services") (text _) + (items ,services)) + (filter choose-misc-service? services)) + ((checkbox-list (title "Printing and document services") (text _) (items ,services)) (filter choose-other-service? services)))) diff --git a/gnu/tests/install.scm b/gnu/tests/install.scm index 154f98b2e1..ae8c6051f1 100644 --- a/gnu/tests/install.scm +++ b/gnu/tests/install.scm @@ -1685,8 +1685,9 @@ (define* (installation-target-os-for-gui-tests (list (swap-space (target (uuid "11111111-2222-3333-4444-123456789abc")))))) - (services (cons (service dhcp-client-service-type) - (operating-system-user-services %minimal-os-on-vda))))) + (services (cons* (service dhcp-client-service-type) + (service ntp-service-type) + (operating-system-user-services %minimal-os-on-vda))))) (define* (installation-target-desktop-os-for-gui-tests #:key (encrypted? #f)) From patchwork Sun Dec 26 20:31:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Famulari X-Patchwork-Id: 35670 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 41E8627BBEA; Sun, 26 Dec 2021 20:32:39 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 7644227BBE9 for ; Sun, 26 Dec 2021 20:32:38 +0000 (GMT) Received: from localhost ([::1]:43064 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n1aC5-00020y-LE for patchwork@mira.cbaines.net; Sun, 26 Dec 2021 15:32:37 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35394) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1aBY-0001hQ-2z for guix-patches@gnu.org; Sun, 26 Dec 2021 15:32:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:58319) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n1aBX-0000Na-8J for guix-patches@gnu.org; Sun, 26 Dec 2021 15:32:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n1aBW-0007yh-UZ for guix-patches@gnu.org; Sun, 26 Dec 2021 15:32:03 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH v6 3/3] installer: Offer 'gpm-service-type' for non-graphical systems. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 26 Dec 2021 20:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.164055070930628 (code B ref 47979); Sun, 26 Dec 2021 20:32:02 +0000 Received: (at 47979) by debbugs.gnu.org; 26 Dec 2021 20:31:49 +0000 Received: from localhost ([127.0.0.1]:41630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1aBJ-0007xr-6P for submit@debbugs.gnu.org; Sun, 26 Dec 2021 15:31:49 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:59859) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1aBF-0007xJ-WF for 47979@debbugs.gnu.org; Sun, 26 Dec 2021 15:31:46 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 4C2253200993; Sun, 26 Dec 2021 15:31:40 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 26 Dec 2021 15:31:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=from:to:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=mesmtp; bh=teqBrmXr5h tyzCkSRaihbWRAnjF8Ly1PRoVmYrVnun8=; b=J1mhMJBGEqgiavL+LRhUDO3HTh n4mkfz9QErieoJcDbkzjXZwrIJesfk/hny8SoVEao5x3QzwooMi0wp0gOpcJiHe6 zeXiyIEm2wjkweDmlsUkBcZFqT7Js3cV0cD2OsGP03o0tQIqv8iNYUmlnt2YCwWT BfrOw/HArcxrnjAU0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=teqBrmXr5htyzCkSRaihbWRAnjF8Ly1PRoVmYrVnun8=; b=Uy6Pu6C7 JIs4vrQypij7tOBoyrv/MmJVnWovAfuJYBY4nn0/5vD6aTOsBsCD9iGk+L4yJS68 cjb/oHqF2RlinrvnQmfMHOWWC2APyEhJwP6Wpr80j5waojY8m6xKTArM1YtzI6uF KBBALEUGEMFyTeVSZUAkIILTBkLdVXyqN6P+9e8QzJLhgUVAri1PV+d9ae3zWWP4 trV/DhXV3GRyGNZ731GyxkshB2DrNqM83kBhdtZGeszm3GIAJqwX/rBBgvz1ntU7 AN8pcg9XUCpYo3sElwQBZcuiSKygFwAu8dPEzzhfvJP6GRBcc4kqdEs4b9y0ccUy mUeoe/VPFWsP9Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddugedgjedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgjfhgggfestdekre dtredttdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgr rhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhephfeggeetiedtvdduudevueehvdehhf efhefghedvhfdugeeukeehvdfhfffhhfegnecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for <47979@debbugs.gnu.org>; Sun, 26 Dec 2021 15:31:39 -0500 (EST) From: Leo Famulari Date: Sun, 26 Dec 2021 15:31:31 -0500 Message-Id: <1a104bb17072170af44b1d2886e98f2377c28f74.1640550687.git.leo@famulari.name> X-Mailer: git-send-email 2.34.0 In-Reply-To: <18b693c017c779578de0a6a367ebf0eab95c7054.1640550687.git.leo@famulari.name> References: <18b693c017c779578de0a6a367ebf0eab95c7054.1640550687.git.leo@famulari.name> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches * gnu/installer/services.scm (%system-services): Add the gpm-service-type. --- gnu/installer/services.scm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gnu/installer/services.scm b/gnu/installer/services.scm index 94c49307f0..be6e75cbc4 100644 --- a/gnu/installer/services.scm +++ b/gnu/installer/services.scm @@ -111,6 +111,10 @@ (define %system-services (type 'administration) (recommended? #t) (snippet '((service ntp-service-type)))) + (system-service + (name (G_ "GPM mouse daemon, to use the mouse in the console")) + (type 'administration) + (snippet '((service gpm-service-type)))) ;; Network connectivity management. (system-service