From patchwork Fri Dec 17 22:30:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Wamm K. D" X-Patchwork-Id: 35360 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 4680A27BBEA; Fri, 17 Dec 2021 22:32:23 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 7363C27BBE9 for ; Fri, 17 Dec 2021 22:32:22 +0000 (GMT) Received: from localhost ([::1]:47120 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1myLm1-0003d0-MQ for patchwork@mira.cbaines.net; Fri, 17 Dec 2021 17:32:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40614) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myLli-0003cS-9L for guix-patches@gnu.org; Fri, 17 Dec 2021 17:32:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:57497) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1myLli-0008F4-0o for guix-patches@gnu.org; Fri, 17 Dec 2021 17:32:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1myLlh-0002nQ-SB for guix-patches@gnu.org; Fri, 17 Dec 2021 17:32:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52238] [PATCH] gnu: Add MEGA SDK Resent-From: Jaft Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 17 Dec 2021 22:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52238 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "52238@debbugs.gnu.org" <52238@debbugs.gnu.org>, Liliana Marie Prikler Received: via spool by 52238-submit@debbugs.gnu.org id=B52238.163978026910680 (code B ref 52238); Fri, 17 Dec 2021 22:32:01 +0000 Received: (at 52238) by debbugs.gnu.org; 17 Dec 2021 22:31:09 +0000 Received: from localhost ([127.0.0.1]:40810 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myLkr-0002mB-6i for submit@debbugs.gnu.org; Fri, 17 Dec 2021 17:31:09 -0500 Received: from mail-co1nam11olkn2030.outbound.protection.outlook.com ([40.92.18.30]:30049 helo=NAM11-CO1-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myLkl-0002la-K5 for 52238@debbugs.gnu.org; Fri, 17 Dec 2021 17:31:08 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XDtdt5hHqFoBKBTe5t2N1Wovlvev1VN31vCj/wixjFuIBB/338xapuZJ9fifITFGhBaVT1S45/jqdTSs8It/gfUwvxYgj1wM8EhPuq/Zlvs+NpCdoHk1JbFwAOrkZbQmo2yQwlp2oYu8kArAuPkwjHluVaviBJ2VdIAn7+SKD5XdlwjB9Pq8j8ftC3xcP/yw0YSgWEN6qdzgfs0lvyu1MuOGZHioF1PwauOg+SXVmJRuE7N8bXth7gyNH6BcaHCVBGDO3uot6QYttvC479eZGTMlNv4b7c3neHub6zwBuZvqqkTdJJ3l8Qh2zuoAEz+eRH7AbTYP8Q24LA0uND+CbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=swWZtccUBDN6emsOWwoWxsQxgrcOutN37GJqcofiZGU=; b=el5kncWD9o2rIQvidhhvUQnq2B/n6x9whME1NtOyC4uRjy5d9O5yPWcVY1r37Z16ReKL3tXO9GkbS34ZMQNbwXcC7VELCRzCRpoACwIGy6WZuuOHljvPNnCf3m997r6XTVAOkOXa+BlXTy0nIXxR//CuEIQxKJ0TDRAFXL3v+8juDxMRgwUQhV7zn44u9hn75PucEBYB9GxvMBwWOVdFWqMA7JlAlfWakdCzcTY68GIyHvyb5ZNPhWbArHUlm3oZ51NAOqGRb/6MHx53TSU/bbOCSbYp3CbZP7mKFhAE4s5Hmgg/X7soKmCBQXd95N4vGAoFcGgVjJlfSRTqYVzIHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=swWZtccUBDN6emsOWwoWxsQxgrcOutN37GJqcofiZGU=; b=A9Cen+R+9ZBfd37sJ2z6/cWuGgSKGLuqlcHaZu/rXEF3kBW+MKViLPXMbOAEfKQ6k5AVH60/U5HC1vxJoTR9qkdiR337GSE6HRzh7QvwV2FH5CXdnuz3vOZiEn9yLwa66s8jrDhVyuiXUZkYrlfGdPkpPukTw1VdRUfND68rkopfoF33AofzQx7on4tG2HwqUGepe4+eeha54HTZe8msmIo5CzWRAgtPAmuGZmR0D4UJOuf2T83ALvcLL840xIIgnAoeA1xtsaNwADAkk57vMh5KoSJoX7N5WLvZnL/Ay9Dod0krdN2hDrr0M/yz7cvNFBVKWimERKGxzbjXQD8r6w== Received: from DM6PR19MB2460.namprd19.prod.outlook.com (2603:10b6:5:18a::23) by DM6PR19MB3852.namprd19.prod.outlook.com (2603:10b6:5:240::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Fri, 17 Dec 2021 22:30:57 +0000 Received: from DM6PR19MB2460.namprd19.prod.outlook.com ([fe80::dd6a:5fb5:6e54:9928]) by DM6PR19MB2460.namprd19.prod.outlook.com ([fe80::dd6a:5fb5:6e54:9928%5]) with mapi id 15.20.4778.019; Fri, 17 Dec 2021 22:30:57 +0000 X-YMail-OSG: Wtv11vEVM1mT_QXwxUde9nsTJSvxVp7Wu7f697MuMa5nvD4c7Dq1d.E.1oygAmv HJsu2mxB5VsxpKgTmfxpcNVW3eKtU4epj81lk_n8e956R8Nozf_Hn_MpH.pH_LcRtkNohBdb2G_V Gth0sKf8kgzAEygQ4zyVHEr_iNtFJlMIOOOwHLcvYtUPrg7s7bgq8SwDJmsFSKJOPc4PDo0kENUo eEn9ddaj9.93.5l4qWS5fuigU2XLjPaSRnsZIZKMdK8sD_veaJeaumyW0Nlx633Szhc8WsgW3_R4 6mmWSaoJn9T09vSkyuwW4LkG9LTLOkTNmU9QrhQ7.2H2zg6eoBzWRFy_cg5hkX0kjQHZV_DbG_2i oU9_JcYOVsI3HUZqH30KOeenlygos.iwhwnP5KWz8QHfse07AMowamalYFPGoAEnJfpTT_ThUA.L 0x3Q0ihHXbDrIGusqNawOM4H.fVmNoKvu5_iOou2345JXIRr5Gqal7cEX3txTf7zFNafk1sPIQyR 52loy9P26Tcf8y2qH4_JRj9.9RDsEsVtPJ.OOOqU1jKxV3mBPSQpEhSGRckB7aWI5KOx1mc4QN5b lekfKjzNl0u4FAxDp866Iv3ptDIGxAxxa2SQ3MbMzL1b_ODC1EVIPjBZ9F5awNliIP6hVbqcM.AB Wi3v2ant4kwHCg.WcQo6H3eBq1pvqEsjXpIAljLoloDBWTo1dY3JILCmU2eVm5PeS6DGSdMq31Mv 9hH.Yj5LP8c60dzZsABr3D25FAWBCZqrk58TzZfkRqLYsvZWeaD5kLGoN6E9YNI6g087.fvZ9xkl v5yFyMYrG5dZSUUVcsGc78zPGlj9Py.LSBJSyRrf4M.dYHdxEwIfGEo0uBJlVfH3tWwasrOCR5fL nvNFjIuxNnRkVXzWIeRInOFBaCcw6eNkbDfhw6oB9tKIGozWsVNQ8eS_koCT7066t5eWLCRBTZcI NWkz6u5T_ux6SKV636nSNZRyeYbhQYeYXFjbY5AtJQt7IJanpFAtPahQrf1sX6WU_Yf0OHP881ZD mxbs456zIFxVJNgl7zOLXbjeFZUk1w1np4ww5yjjD.QZ2psZKjGdu6kmPIy_EjhLIvpY_SkdrJ3M tUkblOu2bPQ6_cMrA7aw5P77pBBrXZKoEycDk5AsjVv.vv1eHDdAl_QNyjsE6U.UfRqoEIS1eXJE MbRCiIouG0Wka9TQFUpCsW4Yexr1f5hxz8CAqGLoZ_9Mytw8szepWc1JdS7oWigvdqZ4viKk8BPS nlIX55asOz8JT4JTnHHWXEvY0lEY6KzR383Hmry.wccYPi9zQBHkZu7oAutGwFnV8X00dPdGN796 dmanTYtd7MaTsDKvKejQQy8D8HewwyXvdrYN4YIP3XoFDkF03YfWwEEo08M5wSyIcx385q.2mTD8 Nizuvoqv4q5XDVB1AbqIERDoto5U9l_3D5rxmth8ymiFufROwvH1uJF45lhg5u4eOz80moCKt7xa _d2PoUZoG5_0eVNX5Kn1QzfbnFsaPIZ2JYhBuTEOehfbGNQIau3cv2DUAc4QK0uCRB3bGFZB6AAI xBG_sIJdU_7Uf.hqY8J5jQvf6rbVH6_QXHGiUB8JyHhIfUcQ7UTUz7ljys45S42Omt7nMFIoNtYX BcCykTlPcCeW0mjTdpV9p9GSwPY_BIt0vQOp1NrXXehA2VXE51BXhlfDSQHCOPcNhHsupE0oFtSr ODppOs0ArZwzTvl22A8dE6MDPfHqsudMskZ3Kb5O7h6gBLnTHQv.DFAud703I5nziwlRTy58z1xI 2K5nCRZ.QoJaqHgBn.7ykHrjbVSGbLScHKsCrKc0L8voed1SYpLomuojcDTODrEkxHixSuzpYDrG cHs0QrUBk7U_.eGLjNhwscitHZTNJclqlDillpWLwvyWW25pdFsugzBdJIZeNsNTw6l792R1n3Ot GPy5d8R18Gyj6ge6dNtRp7Q0_KRLDoYO9v8.TDywVfnGPpl0F4.zp.SScNXDSHMfTIMMylrc40XE 9YH65DgMHlH6pS5d07Zq_eWJyVQ2w2M4wM6KLPk03HmpW9gvCfYslBpAvNgLeB47HAAnsD1zJjo8 paflscC7K8IFvutefrqFpYtvF.WZAm6orFkgJ9J.ag8WcNmpjVO3545zYHqF9ayX7aZyt0cssRzv xuP2nuZ75uNR8Ip0Ie2_7ekKijhJjETJhYH8hzOvti6MBZ3CxmyuCGGxZ00.57lG9G1QZZzVniNn habO0xd1NFSV3foqkIO8.nre0uHQ0uvOs53ANal7mBLMWa8wAX_UYXfJtDn5Wq_Ty6X2H7B0.sdT jMTcCyWzvZGI70ulK2IVSwVd6Xpc3BKUPtRRJDrkwDuANtQREs2XW.p55CUU- X-Sonic-MF: Date: Fri, 17 Dec 2021 22:30:55 +0000 (UTC) From: Jaft Message-ID: In-Reply-To: References: <1136809883.7440498.1638426746315.ref@mail.yahoo.com> X-Mailer: WebService/1.1.19498 YMailNorrin X-TMN: [wx2hMCZeZtwKcMdNnZGn5TP3zvwXL5yn] X-ClientProxiedBy: MN2PR01CA0049.prod.exchangelabs.com (2603:10b6:208:23f::18) To DM6PR19MB2460.namprd19.prod.outlook.com (2603:10b6:5:18a::23) X-Microsoft-Original-Message-ID: <1152498677.28369.1639780255589@mail.yahoo.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cd912796-f628-4e74-d172-08d9c1ace479 X-MS-TrafficTypeDiagnostic: DM6PR19MB3852:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Uffqm0OoQhKvKrr7FEFDjbNsghx9nGfYg0WhHXqpxGv43li4/TmZPvWmsnFP7slMKwL/C3eXGwDPpyjSstX7MdDS6b7fKB7JLrcA4FdEzfZ4XtQjdhuhkNiD3bK22/qFUqh4uPdrI5JCuawNx7ayYOmmlf/I1wIfRtX1puhyHj/5oUnBzTB8gB0O6gz02zOmBa0tRWRBWcqwSu7Pu+UsG+yo4IWDIr8ViTy5LMERqSmzWRmC9LkrRpcWxg6AzWP2hgBJTZwEyzcw1mQF3oNGnBcPT7fkgPM0PLvriK1D3yawTgeHnG6KIIR+q9dB2ezLeDKFssjSwClKHNlrQVe3lKbi01MCVmyHALzJlgRQWYMOcEfSymipeAEZQOeLpB8r+6eJx1OCE9fV55K13V+NpoJOzR/2+NoXeN7HnlpRbSmZyVJm4yW67HIV4rFwxtuUG5/EhYM5NoeWz7q3s01KZxAID5JO7nH8hWWHB1x2LN5H6i4CbmarTn5v+4dsP1Cs4wcHNK5fi7306NXyz43sHxsJLG0o5i/1RvjJnQT0gP+ltPO3DeE0mR0ApJG53tPhMi/YVOblmWXbo9aq05jWsDZftDKSGXlgZhoMIH40b8PjSyhV3AWpX0gAEIOMiq+c X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: KvK1SaizXN8NTJAH3ojjCXTltb1mNRS0Zyj+oJPFZ6akZBZZn9/JyW46nj1A30fpPYkIlH5GiwqVJLaGp59VcTxjRUzt8LgYpS8ZW6rtrSjhXuTDVh/KeAjDgad74qJnZfDdkzOKuP8+4FeXIwUeN8bjCRlUryXCv4+a3RPIl3xp2roQfWWGQtmnK67xoM8SIVa/sNykMJEecmssSJNaT11vX0LSIIbA7ndrA39XYJ1zeKENTLJG1bFMidakJobf3dr0R27yW9m1RojwZbg3+aw8n3EZsu5O83feVYPiZzlcRgLOv8Maoapza01R58/buikBWn71dw0MjE5qgtayq9NcKRLFreaRaIkjDmy0SiBZZtpiLtEmGd9KLPZKDvG2fXtRAy4/joXsTw4GFfDHVlWuq6Yy06O3Rwj/KnWc7D1JVMLsFt+fERGEVe7RJWv+N6M7PDzFOI4558Bt3djuOVWGuYA0VHYjFiHK7+fWGe+SCmZApjQJmT9CoRwwgGg/ESTarTSF1FCOPBVw8tvzJZ8m3iEqUtyft6bAj+P5wDdr4+t5qSslbyXAHPCQ+1F1ed0ep4n+dJtDIE9lX1VArGiRoZ1mShOlhApYHPEkOcyxODy3jQDilGoIy83TGRpJxgVpxIa0dACXNw8ExHULV+Pd02WCqqDN4AdWQfOI5CYLqYuTD7ZJxbVM0GzXKV18aOuXBAVu2/66UPmSXKT/p2w97JXfZXywQhOODvRbI4m35z2DROWhQRhR0FNtfBga9HcIwWNF91PnMl5iDEaEIjVHJ/5NzXSA1v8ue6ElYK87XpU/Lv1obm9uKllyKEPWWGOOMFlxMZKW8zC3EdZr2ee7hoHOeeV8QDGVxnZuRkYT4NyVhaPsH2hvjSma0R2XNADlJd6w8FnN5tdSsv9PbTavHCJhYKUo9AmKIhBkXUjGy8KCf+U86S5dbi5wfiGtPSXH6WKzphm7j8W3hEqFrw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cd912796-f628-4e74-d172-08d9c1ace479 X-MS-Exchange-CrossTenant-AuthSource: DM6PR19MB2460.namprd19.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2021 22:30:57.1047 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR19MB3852 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Jaft Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches > On Monday, December 6, 2021, 01:53:09 PM CST, Liliana Marie Prikler wrote: > > > > > > Am Donnerstag, den 02.12.2021, 06:32 +0000 schrieb Jaft: > > * gnu/packages/mega.scm (mega-sdk):Add MEGA SDK > Should be "New variable." Which part should be "New variable"? "* gnu/packages/mega.scm (mega-sdk): New variable"? Or the whole line? "* New variable"? > > The SDK is a dependency of MEGAsync so I thought to make a new file > > since there's multiple packages that are MEGA related and then I > > discovered that the megacmd package exists; is it better for this to > > be placed in sync.scm, next to megacmd? > Sync is good.  If existing Mega packages use the SDK, try to unbundle > them. Makes sense; megatools doesn't seem to rely on it but megacmd pulls from git recursively since the SDK repo.'s setup as a module for it so I've adjusted that definition to make use of the SDK, now. > > --- > I don't know if I told you that yet, but comments ought to go below > this line. Mmm, I think you did but I must've misunderstood as I thought you were saying the opposite; noted and I'll do it the other way, going forward. > > +    (package > > +      (name "mega-sdk") > > +      (version version) > There's no reason to let-bind version if you're just going to assign it > here anyway. It hadn't been clear to me that the macro functions in that fashion; I've removed the use of let. > > +      (arguments `(#:tests? #f)) > Never leave #:tests? #f uncommented. Makes sense; that's been revised. > > +      (home-page "https://mega.nz/sdk") > > +      (synopsis "SDK for the MEGA service, offered by MEGA Limited") > Sponsored by RAID: Shadow Legends. I don't understand what this is communicating. > Given the megacli command, what's the relation to existing MEGA > packages, particularly megacmd? > > Cheers Noted above (and addressed in the new patch). It seems like I'll likely have to make further changes but I've attached what I have for the patch, thus far, just to keep track of what changes have been made. * gnu/packages/sync.scm (mega-sdk): Add MEGA SDK --- gnu/packages/sync.scm | 44 ++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 42 insertions(+), 2 deletions(-) diff --git a/gnu/packages/sync.scm b/gnu/packages/sync.scm index ce815ed5c7..064e68c431 100644 --- a/gnu/packages/sync.scm +++ b/gnu/packages/sync.scm @@ -213,6 +213,46 @@ (define-public nextcloud-client license:lgpl2.1+ ; qtokenizer license:gpl2+)))) +(define-public mega-sdk + (package + (name "mega-sdk") + (version "3.9.10") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/meganz/sdk/") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 (base32 + "08qw23rm4rrvlsbcixrncbi5x0qgqkpx74l5f1gq2rgll0ksx8ph")) + (modules '((guix build utils))))) + (build-system gnu-build-system) + (native-inputs `(("autoconf" ,autoconf) + ("automake" ,automake) + ("libtool" ,libtool))) + (inputs `(("c-ares" ,c-ares) + ("crypto++" ,crypto++) + ("curl" ,curl) + ("freeimage" ,freeimage) + ("libsodium" ,libsodium) + ("openssl" ,openssl) + ("readline" ,readline) + ("sqlite" ,sqlite) + ("zlib" ,zlib))) + ;; XXX: Disabling tests because they depend on libgtest.la from googletest, + ;; which is not installed for unclear reasons. + (arguments `(#:tests? #f)) + (home-page "https://mega.nz/sdk") + (synopsis "SDK for the MEGA service, offered by MEGA Limited") + (description "A low-level SDK for the MEGA service which powers the +file-sharing site. This package provides two executables: +@itemize +@item megacli: a command-line tool that allows usage of all SDK features +@item megasimplesync: a command line tool that allows usage of the +synchronization engine +@end itemize") + (license license:bsd-2))) + (define-public megacmd (package (name "megacmd") @@ -222,8 +262,7 @@ (define-public megacmd (method git-fetch) (uri (git-reference (url "https://github.com/meganz/MEGAcmd") - (commit (string-append version "_Linux")) - (recursive? #t))) + (commit (string-append version "_Linux")))) (sha256 (base32 "004j8m3xs6slx03g2g6wzr97myl2v3zc09wxnfar5c62a625pd53")) @@ -242,6 +281,7 @@ (define-public megacmd ("curl" ,curl) ("freeimage" ,freeimage) ("gtest" ,googletest) + ("mega-sdk" ,mega-sdk) ("openssl" ,openssl) ("pcre" ,pcre) ("readline" ,readline)