From patchwork Sun Nov 14 04:34:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ahmed Khanzada X-Patchwork-Id: 34473 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id C51D127BBE3; Sun, 14 Nov 2021 13:06:52 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,T_DKIM_INVALID, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 7418F27BBE1 for ; Sun, 14 Nov 2021 13:06:52 +0000 (GMT) Received: from localhost ([::1]:53282 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmFDf-0003dd-MX for patchwork@mira.cbaines.net; Sun, 14 Nov 2021 08:06:51 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36584) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mm7O3-0002iK-Av for guix-patches@gnu.org; Sat, 13 Nov 2021 23:45:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37282) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mm7O3-0004nW-2Z for guix-patches@gnu.org; Sat, 13 Nov 2021 23:45:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mm7O2-00012w-OI for guix-patches@gnu.org; Sat, 13 Nov 2021 23:45:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51829] Better error message for mcron file loading Resent-From: Ahmed Khanzada Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 14 Nov 2021 04:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 51829 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 51829@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16368650623953 (code B ref -1); Sun, 14 Nov 2021 04:45:02 +0000 Received: (at submit) by debbugs.gnu.org; 14 Nov 2021 04:44:22 +0000 Received: from localhost ([127.0.0.1]:48828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mm7NN-00011h-R8 for submit@debbugs.gnu.org; Sat, 13 Nov 2021 23:44:22 -0500 Received: from lists.gnu.org ([209.51.188.17]:57240) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mm7NJ-00011U-D9 for submit@debbugs.gnu.org; Sat, 13 Nov 2021 23:44:20 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36544) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mm7NJ-0002gI-4z for guix-patches@gnu.org; Sat, 13 Nov 2021 23:44:17 -0500 Received: from [2607:f8b0:4864:20::82a] (port=38863 helo=mail-qt1-x82a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mm7NH-0004kq-9v for guix-patches@gnu.org; Sat, 13 Nov 2021 23:44:16 -0500 Received: by mail-qt1-x82a.google.com with SMTP id 8so2763186qtx.5 for ; Sat, 13 Nov 2021 20:44:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enzu-ru.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version; bh=1ES9CBHb3V1QvLOXPh30iSo1dOGaDDdJM3m7isrmbeA=; b=cDqCA4hNmpkOELneBsovyBltBFduF9YFTcOj7Kv7w0kFawd4XfwO5/1mSnmM/vVxDK Ts+bCjXu0w9aI68D52NAM3SKVdGW9RSFta7pjTyBGvHUjVqbYWq0D8CL8qrRICxhvHqo wSktwTvAplwORs9LGnqKU6TX8cJMzAxPUr/J21HCHfOZBTJZ2NbGeZAzJOI/IzLwSUrM KV0mkouj+uEA/m7XMsLML/mLxDx2U171A5018Cx7KYlIlF6iCqVg3rcSuEZeVzq+Eulr CC3bkyv1rGFGQvQMiZ8Jy+iARG5u6jHbn1E4uWYu+qSreQ0PJxrd1cXuvzvFhP0N8dSK AcSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version; bh=1ES9CBHb3V1QvLOXPh30iSo1dOGaDDdJM3m7isrmbeA=; b=6yKic6oE6yyCsHpfoAkb2qugpBT8Eo8q+RJMIChioYpZqS3My5+pfvjOEm23lz+jgn SxaahEqNVjVpSY/FXA96zmcly5OqwnGn/3R4T2pfrUrUfriGSc8WJezZ/70/6nKAeK6g uO06Dg1w9DVneH13zunBzMG4AMBmcyjUQ+SBOsvpI3Qo1H4D00bc9fOUmbjPefN7Ueuu 2mi/vF5vcC89rTsfIWiOlvAs4EWX7uzz7wg1i9XZTKiQw6VemNnr8ff4JWlHqvXvC+FK VQVXVsZ8zbpPFrMvBGpoRaIzRCBhAOxMiB934Ntjtm0wXyETml676x3pnrg+K7jHhPTx B2sA== X-Gm-Message-State: AOAM533ieF71NuyF9MiWXDy/Ggt8k6KjBbbQHrVnO2nV+MtLXL6famik jrUlvzj1kdTWyQcK75Z+o8FAaCekVxJwl4O51JXA4Q== X-Google-Smtp-Source: ABdhPJwKf5E1db0XuDYA9NVub7xyVDLrkotiH7TF+2fy5QM28aS2F8/Dw83CRECNYhVG53NGkHt29Q== X-Received: by 2002:a37:f90a:: with SMTP id l10mr21486635qkj.402.1636864720064; Sat, 13 Nov 2021 20:38:40 -0800 (PST) Received: from guix ([2002:4575:508:0:6ce3:217:86e2:a70]) by smtp.gmail.com with ESMTPSA id 15sm5963016qtp.55.2021.11.13.20.38.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Nov 2021 20:38:39 -0800 (PST) From: Ahmed Khanzada Date: Sat, 13 Nov 2021 23:34:18 -0500 Message-ID: <87sfvztkxh.fsf@enzu.ru> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::82a (failed) Received-SPF: none client-ip=2607:f8b0:4864:20::82a; envelope-from=me@enzu.ru; helo=mail-qt1-x82a.google.com X-Spam_score_int: 3 X-Spam_score: 0.3 X-Spam_bar: / X-Spam_report: (0.3 / 5.0 requ) BAYES_05=-0.5, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Mailman-Approved-At: Sun, 14 Nov 2021 08:06:30 -0500 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches I was a bit puzzled why mcron was failing; based on the error, I assumed file permissions, and did not realize the actual problem was my faulty syntax within a file. Until we can get more detailed error messages in place, I propose this patch to make the current generic error we have slightly more helpful. diff --git a/src/mcron/scripts/mcron.scm b/src/mcron/scripts/mcron.scm index 4c5f7b5..3e581fa 100644 --- a/src/mcron/scripts/mcron.scm +++ b/src/mcron/scripts/mcron.scm @@ -93,7 +93,7 @@ $XDG_CONFIG_HOME is not defined uses ~/.config/cron instead)." "/cron"))) (when (eq? 2 errors) (mcron-error 13 - "Cannot read files in your ~/.config/cron (or ~/.cron) directory.")))) + "There was an error reading files in your ~/.config/cron (or ~/.cron) directory. Double-check the folder and file permissions and syntax."))))