From patchwork Fri Nov 12 19:19:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Demis Balbach X-Patchwork-Id: 34416 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 3D27D27BBE3; Fri, 12 Nov 2021 19:21:02 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,T_DKIM_INVALID, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id E249027BBE1 for ; Fri, 12 Nov 2021 19:21:01 +0000 (GMT) Received: from localhost ([::1]:37608 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mlc6e-0006O4-Ra for patchwork@mira.cbaines.net; Fri, 12 Nov 2021 14:21:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57280) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlc5v-0006FS-FX for guix-patches@gnu.org; Fri, 12 Nov 2021 14:20:19 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34446) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mlc5i-0006BQ-BL for guix-patches@gnu.org; Fri, 12 Nov 2021 14:20:15 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mlc5i-0003DE-4U for guix-patches@gnu.org; Fri, 12 Nov 2021 14:20:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51779] [PATCH] Add phonesim 1.21 References: <20211111221457.6025-1-db@minikn.xyz> In-Reply-To: <20211111221457.6025-1-db@minikn.xyz> Resent-From: Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 12 Nov 2021 19:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51779 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: <51779@debbugs.gnu.org> Received: via spool by 51779-submit@debbugs.gnu.org id=B51779.163674474812277 (code B ref 51779); Fri, 12 Nov 2021 19:20:02 +0000 Received: (at 51779) by debbugs.gnu.org; 12 Nov 2021 19:19:08 +0000 Received: from localhost ([127.0.0.1]:45992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlc4p-0003Bx-Ne for submit@debbugs.gnu.org; Fri, 12 Nov 2021 14:19:08 -0500 Received: from mout-p-103.mailbox.org ([80.241.56.161]:43836) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlc4n-0003BR-WB for 51779@debbugs.gnu.org; Fri, 12 Nov 2021 14:19:06 -0500 Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4HrT0M56RMzQkrd for <51779@debbugs.gnu.org>; Fri, 12 Nov 2021 20:18:59 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minikn.xyz; s=MBO0001; t=1636744737; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FEK+sJAODOrGj4D5oXzqXbAVNWaw/XEpUZ2AmEdATis=; b=rCs3kGLxh1LrpmwKC3czaV7V82+Ct+8DS3CdZUMmxYZCpG7eBxiGh4mXH+OhoqxB+W/iAm 7sqcJ4WgKMr7Oa1nnsutxsgw18f0tFgOk6OTwf11G+hK4dmVP8JKwuppDY4apzdxWXnlM2 YqClIAoGh8XDwJSvLUdwoyI5m+5dVT1y6NaGcr71LUP6LjuJVjkAUuCoU1Awk4CsbJmEIs QVNgVnAKnLbHwxShWYml+jwrKXDbaHZ3mZ40fIUlyScgXo5kfIwEvcqkttv+jESXiZ2fhp nSHbUa+LI6BvDhOFrm8xed/88rpViB0u1221tvK98nriyFz+6zyCGloMmyxloA== From: Date: Fri, 12 Nov 2021 20:19:03 +0100 Message-ID: <006401d7d7fa$27f236e0$77d6a4a0$@minikn.xyz> MIME-Version: 1.0 Thread-Index: AdfX+huKqlCSGNMpRI+o3RlVhdFxlw== Content-Language: de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hello Tobias, thank you for your input. This is my first attempt at submitting a patch through a mailing list. I expected some mistakes. On top of that, my guile is bad as well (I'm just starting with it). > Check the git log for commits adding new packages for the expected > 'change-log-style' commit message. Thanks. I think it should have been `[PATCH] gnu: Add phonesim'. How can I change that? > This is unusual enough to require a comment explaining why it's here. The short answer is - I don't know. I copied it from the source: https://git.kernel.org/pub/scm/network/ofono/phonesim.git/tree/bootstrap-con figure I should also mention that I do not have any experience with the application. I never used it nor do I really understand what it does. I just submitted a patch because it is part of what needs to be done in order to get bluetooth headsets fully working in Guix (with microphone), see https://wiki.archlinux.org/title/Bluetooth_headset#HFP_not_working_with_Puls eAudio This is beside the point, but I'm mentioning it to give a little background why I may not be able to give insight on why things are done a certain way. That being said, here is the new patch version: --- gnu/packages/telephony.scm | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) (define-public libilbc (package (name "libilbc") -- 2.33.0 Greetings, Demis. diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm index a2765ee99f..6e3c69ce91 100644 --- a/gnu/packages/telephony.scm +++ b/gnu/packages/telephony.scm @@ -20,6 +20,7 @@ ;;; Copyright C 2020, 2021 Maxim Cournoyer ;;; Copyright C 2020 Vincent Legoll ;;; Copyright C 2021 LibreMiami +;;; Copyright C 2021 Demis Balbach ;;; ;;; This file is part of GNU Guix. ;;; @@ -87,6 +88,7 @@ (define-module (gnu packages telephony) #:use-module (gnu packages bison) #:use-module (gnu packages flex) #:use-module ((guix licenses) #:prefix license:) + #:use-module (guix utils) #:use-module (guix packages) #:use-module (guix download) #:use-module (guix git-download) @@ -94,6 +96,37 @@ (define-module (gnu packages telephony) #:use-module (guix build-system gnu) #:use-module (guix build-system qt)) +(define-public phonesim + (package + (name "phonesim") + (version "1.21") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://git.kernel.org/pub/scm/network/ofono/phonesim.git") + (commit "a7c844d45b047b2dae5b0877816c346fce4c47b9"))) + (sha256 + (base32 + "0rc1c2vr03dmi1dr3skj57v77ga9c22g29xs1qiphqms4isby9cq")))) + (build-system gnu-build-system) + (arguments + `(#:configure-flags + (list "--enable-maintainer-mode" + "CC=" ,(cc-for-target)))) + (native-inputs + `(("automake" ,automake) + ("autoconf" ,autoconf) + ("pkg-config" ,pkg-config))) + (inputs + `(("qtbase" ,qtbase-5) + ("qtdeclarative" ,qtdeclarative))) + (synopsis "Phone Simulator for modem testing") + (description "Phonesim is a modem emulator that oFono uses for development +and testing. This allows oFono to be used by any host without requiring special +GSM (or other) hardware.") + (home-page "https://git.kernel.org/pub/scm/network/ofono/phonesim.git") + (license license:gpl2+))) +