From patchwork Sat May 4 10:23:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre Neidhardt X-Patchwork-Id: 13890 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id F134916F96; Sat, 4 May 2019 11:24:15 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 9D8BB16F8A for ; Sat, 4 May 2019 11:24:13 +0100 (BST) Received: from localhost ([127.0.0.1]:54316 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMrq0-0007BD-Tr for patchwork@mira.cbaines.net; Sat, 04 May 2019 06:24:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:32781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMrpu-0007Au-RY for guix-patches@gnu.org; Sat, 04 May 2019 06:24:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMrpq-0001h0-GL for guix-patches@gnu.org; Sat, 04 May 2019 06:24:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36877) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMrpq-0001go-AA for guix-patches@gnu.org; Sat, 04 May 2019 06:24:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hMrpp-0002vQ-Vu for guix-patches@gnu.org; Sat, 04 May 2019 06:24:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#34807] [PATCH 1/2] Add (guix lzlib). Resent-From: Pierre Neidhardt Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 04 May 2019 10:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34807 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?utf-8?q?Court=C3=A8s?= Received: via spool by 34807-submit@debbugs.gnu.org id=B34807.155696541511210 (code B ref 34807); Sat, 04 May 2019 10:24:01 +0000 Received: (at 34807) by debbugs.gnu.org; 4 May 2019 10:23:35 +0000 Received: from localhost ([127.0.0.1]:50421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMrpM-0002uf-Ap for submit@debbugs.gnu.org; Sat, 04 May 2019 06:23:35 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:47451) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMrpH-0002uP-BI for 34807@debbugs.gnu.org; Sat, 04 May 2019 06:23:30 -0400 X-Originating-IP: 92.169.116.19 Received: from bababa (lfbn-1-4117-19.w92-169.abo.wanadoo.fr [92.169.116.19]) (Authenticated sender: pierre@atlas.engineer) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id CB9D11C0009; Sat, 4 May 2019 10:23:23 +0000 (UTC) From: Pierre Neidhardt In-Reply-To: <87lfzm7fdz.fsf@gnu.org> References: <20190310180209.11578-1-mail@ambrevar.xyz> <8736ne3855.fsf@gnu.org> <87pnp2f7gr.fsf@ambrevar.xyz> <8736lxdxn6.fsf@ambrevar.xyz> <87lfzm7fdz.fsf@gnu.org> Date: Sat, 04 May 2019 12:23:23 +0200 Message-ID: <878svm5xic.fsf@ambrevar.xyz> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 34807@debbugs.gnu.org Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Right on time, I just finished it! - I've been in touch with Antonio, Lzip's maintainer, for more than a week and now I'm confident that I have a decent understanding of the library. - Your m4 suggestion didn't work. I've included a comment. We need to fix it before merging. I'm not the right person for this job I'm afraid :p Ludo? - The convenience functions do not support multi-member archives. Multi-member archives are mostly useful for parallelization, but we don't use that in Guix, so it's OK. Should it be required some day, we would need to implement it, which requires a little bit more work. I've documented all that. - The implementation of lzread! is subpar because I understood a subtlety a bit too late. But that's alright, it does not affect performance nor reliability. - I've included 11 tests covering all your suggestions. - I haven't strace'd the Guile process. The code regarding ports is identical to zlib.scm, so it's unlikely there would be an issue in this area. I have never done this before, so out of curiosity, how do you run a specific Guix tests without going through `make'? Next steps? :D From 7dd8f4207657ae7ad178c21a45f74bef6cc0a314 Mon Sep 17 00:00:00 2001 From: Pierre Neidhardt Date: Sun, 10 Mar 2019 16:40:41 +0100 Subject: [PATCH 2/2] dir-locals.el: Add 'call-with-lzip-input-port' and 'call-with-lzip-output-port' keywords. * .dir-locals.el: Add indentation rules for 'call-with-lzip-input-port' and 'call-with-lzip-output-port'. --- .dir-locals.el | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.dir-locals.el b/.dir-locals.el index 550e06ef09..f1196fd781 100644 --- a/.dir-locals.el +++ b/.dir-locals.el @@ -53,6 +53,8 @@ (eval . (put 'call-with-decompressed-port 'scheme-indent-function 2)) (eval . (put 'call-with-gzip-input-port 'scheme-indent-function 1)) (eval . (put 'call-with-gzip-output-port 'scheme-indent-function 1)) + (eval . (put 'call-with-lzip-input-port 'scheme-indent-function 1)) + (eval . (put 'call-with-lzip-output-port 'scheme-indent-function 1)) (eval . (put 'signature-case 'scheme-indent-function 1)) (eval . (put 'emacs-batch-eval 'scheme-indent-function 0)) (eval . (put 'emacs-batch-edit-file 'scheme-indent-function 1)) -- 2.21.0