From patchwork Fri Oct 23 10:32:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ekaitz Zarraga X-Patchwork-Id: 24756 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 8C74F27BBF0; Fri, 23 Oct 2020 11:33:09 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,T_DKIM_INVALID, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 8C05627BBEE for ; Fri, 23 Oct 2020 11:33:08 +0100 (BST) Received: from localhost ([::1]:33088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kVuNf-0000gE-PT for patchwork@mira.cbaines.net; Fri, 23 Oct 2020 06:33:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42474) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVuNa-0000g5-Re for guix-patches@gnu.org; Fri, 23 Oct 2020 06:33:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43890) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kVuNa-0000ij-Ii for guix-patches@gnu.org; Fri, 23 Oct 2020 06:33:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kVuNa-0003UJ-F1 for guix-patches@gnu.org; Fri, 23 Oct 2020 06:33:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#44170] [PATCH] gnu: Correct Inkscape extension dependencies Resent-From: Ekaitz Zarraga Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 23 Oct 2020 10:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 44170 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 44170@debbugs.gnu.org X-Debbugs-Original-To: "guix-patches@gnu.org" Received: via spool by submit@debbugs.gnu.org id=B.160344917913396 (code B ref -1); Fri, 23 Oct 2020 10:33:02 +0000 Received: (at submit) by debbugs.gnu.org; 23 Oct 2020 10:32:59 +0000 Received: from localhost ([127.0.0.1]:55436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVuNT-0003Ts-6v for submit@debbugs.gnu.org; Fri, 23 Oct 2020 06:32:59 -0400 Received: from lists.gnu.org ([209.51.188.17]:50088) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVuNR-0003Tl-QL for submit@debbugs.gnu.org; Fri, 23 Oct 2020 06:32:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42464) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVuNR-0000fp-Eq for guix-patches@gnu.org; Fri, 23 Oct 2020 06:32:53 -0400 Received: from mail1.protonmail.ch ([185.70.40.18]:60097) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVuNN-0000cN-2H for guix-patches@gnu.org; Fri, 23 Oct 2020 06:32:52 -0400 Date: Fri, 23 Oct 2020 10:32:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=elenq.tech; s=protonmail2; t=1603449163; bh=pz4fHMmRMEawFbQmWGRDrC2IehBYO9f+fVWVkcCTFYY=; h=Date:To:From:Reply-To:Subject:From; b=GiSZ2tFdQFlePM8LYJL8xsuUezSyVob4gwBTGnE2YstyfWcCSImn0Kw+mze58j5z3 4rLpy1rszev45tx6sBaP/yS2pSYyOE8dQnEGUM/JoIgz5acrXwoZ12IVCF19tGJbhX q/N3eFHNtbaR8Z4dtP2Z5/GMEW9586nWP4GLHNNu85VafcMHdJBk2lLGZNkmkFPsc/ TaUPlFIB2kePuEeU6x0zGy8YJPL1GCGTFDohhEh8Pk8YMTQEYcyL/nqD5yuIQCb3PE CgENGpM9Fnpt9MALTZgxaomFRy4Vfz82KYZpoMoAAdNCR3ODyhLc8g/Stj9wh8YDey rs+Y0Omnvu7DQ== From: Ekaitz Zarraga Message-ID: MIME-Version: 1.0 Received-SPF: pass client-ip=185.70.40.18; envelope-from=ekaitz@elenq.tech; helo=mail1.protonmail.ch X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/23 05:35:06 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Ekaitz Zarraga Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi, This patch is the result of the guix-devel discussion about Inkscape's errors during import-export. Looks like the Inkscape package was not fully packaged because the extensions' dependencies were not included. This patch includes python-scour package, one missing dependency needed for optimized SVG exports and adds the needed dependencies to the inkscape package. Thanks! From 47b9eaec1715ad44e0156bf29362af47c103d02e Mon Sep 17 00:00:00 2001 From: Ekaitz Zarraga Date: Wed, 21 Oct 2020 19:08:20 +0200 Subject: [PATCH] gnu: Correct Inkscape extension dependencies * gnu/packages/inkscape.scm (inkscape@1.0.1): Add dependencies. * gnu/packages/python-xyz.scm (python-scour): New variable. --- gnu/packages/inkscape.scm | 28 ++++++++++++++++++++++++++-- gnu/packages/python-xyz.scm | 26 ++++++++++++++++++++++++++ 2 files changed, 52 insertions(+), 2 deletions(-) -- 2.28.0 diff --git a/gnu/packages/inkscape.scm b/gnu/packages/inkscape.scm index 4ac3cf3966..85b4b5020f 100644 --- a/gnu/packages/inkscape.scm +++ b/gnu/packages/inkscape.scm @@ -6,6 +6,7 @@ ;;; Copyright © 2018 Tobias Geerinckx-Rice ;;; Copyright © 2020 Maxim Cournoyer ;;; Copyright © 2020 Boris A. Dekshteyn +;;; Copyright © 2020 Ekaitz Zarraga ;;; ;;; This file is part of GNU Guix. ;;; @@ -44,6 +45,7 @@ #:use-module (gnu packages pdf) #:use-module (gnu packages popt) #:use-module (gnu packages python) + #:use-module (gnu packages python-xyz) #:use-module (gnu packages xml) #:use-module (gnu packages ghostscript) #:use-module (gnu packages fontutils) @@ -250,7 +252,25 @@ endif()~%~%" (add-after 'install 'glib-or-gtk-compile-schemas (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-compile-schemas)) (add-after 'glib-or-gtk-compile-schemas 'glib-or-gtk-wrap - (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap))))) + (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap)) + (add-after 'install 'wrap-program + ;; Ensure correct Python at runtime. + (lambda* (#:key inputs outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (python (assoc-ref inputs "python")) + (file (string-append out "/bin/inkscape")) + (path (string-append + out + "/lib/python" + ,(version-major+minor + (package-version python)) + "/site-packages:" + (getenv "PYTHONPATH")))) + (wrap-program file + `("PYTHONPATH" ":" prefix (,path)) + `("PATH" ":" prefix + (,(string-append python "/bin:"))))) + #t))))) (inputs `(("aspell" ,aspell) ("autotrace" ,autotrace) @@ -283,7 +303,11 @@ endif()~%~%" ("googletest" ,googletest) ("perl" ,perl) ("pkg-config" ,pkg-config) - ("python" ,python-wrapper))) + ("python" ,python-wrapper) + ("python-scour" ,python-scour) + ("python-pyserial" ,python-pyserial) + ("python-numpy" ,python-numpy) + ("python-lxml" ,python-lxml))) (home-page "https://inkscape.org/") (synopsis "Vector graphics editor") (description "Inkscape is a vector graphics editor. What sets Inkscape diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm index 575ce40ac8..fe2e77a338 100644 --- a/gnu/packages/python-xyz.scm +++ b/gnu/packages/python-xyz.scm @@ -88,6 +88,7 @@ ;;; Copyright © 2020 Joseph LaFreniere ;;; Copyright © 2020 Tim Gesthuizen ;;; Copyright © 2020 Bonface Munyoki Kilyungi +;;; Copyright © 2020 Ekaitz Zarraga ;;; ;;; This file is part of GNU Guix. ;;; @@ -22524,3 +22525,28 @@ applications with variable CPU loads).") (define-public python2-parallel (package-with-python2 python-parallel)) + +(define-public python-scour + (package + (name "python-scour") + (version "038.1") + (source + (origin + (method git-fetch) + (uri + (git-reference + (url "https://github.com/scour-project/scour") + (commit + (string-append "v" version)))) + (sha256 + (base32 "0rgiypb9ig8x4rl3hfzpy7kwnx1q3064nvlrv4fk0dnp84girn0v")))) + (propagated-inputs + `(("python-six" ,python-six))) + (build-system python-build-system) + (home-page "https://github.com/scour-project/scour") + (synopsis "Scour is an SVG optimizer/cleaner written in Python") + (description "The goal of Scour is to output a file that renderes +identically at a fraction of the size by removing a lot of redundant +information created by most SVG editors. Optimization options are typically +lossless but can be tweaked for more agressive cleaning.") + (license license:asl2.0)))