diff mbox series

[bug#45293] gnu: Add skim.

Message ID tencent_D7E3AC86BF3F9D94F2969283DAA7CDAFD407@qq.com
State Accepted
Headers show
Series [bug#45293] gnu: Add skim. | expand

Checks

Context Check Description
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue

Commit Message

Z572 Jan. 25, 2021, 4:15 p.m. UTC

Comments

John Soo Jan. 25, 2021, 4:20 p.m. UTC | #1 
Can you rename rust-skim to skim (both variable name and package name) please?    I think ideally you should also remove the old rust-skim versions from crates-io.scm if no other packages depend on it.    Can also you also squash the commit doing the move and rename into the commit adding skim please? 

 
Thanks!
 

 
John
diff mbox series

Patch

From dbf352b787db782786f433a7cc26760cc283e42c Mon Sep 17 00:00:00 2001
From: Zheng Junjie <873216071@qq.com>
Date: Tue, 26 Jan 2021 00:03:55 +0800
Subject: [PATCH 2/2] gnu: Rename rust-skim to skim.

---
 gnu/packages/crates-io.scm | 7 +++++--
 gnu/packages/rust-apps.scm | 8 ++++----
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 05d00f5ce6..32d889d11b 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -29874,11 +29874,11 @@  sub-processes using a fork-like interface.")
         ("rust-memchr" ,rust-memchr-2)
         ("rust-nix" ,rust-nix-0.18)
         ("rust-scopeguard" ,rust-scopeguard-1)
-        ("rust-skim" ,rust-skim-0.7)
         ("rust-unicode-segmentation" ,rust-unicode-segmentation-1)
         ("rust-unicode-width" ,rust-unicode-width-0.1)
         ("rust-utf8parse" ,rust-utf8parse-0.2)
-        ("rust-winapi" ,rust-winapi-0.3))
+        ("rust-winapi" ,rust-winapi-0.3)
+        ("skim" ,skim-0.7))
        #:cargo-development-inputs
        (("rust-assert-matches" ,rust-assert-matches-1.3)
         ("rust-doc-comment" ,rust-doc-comment-0.3)
@@ -32726,6 +32726,9 @@  variants in pure Rust.")
      "Test your Rust markdown documentation via Cargo.")
     (license (list license:expat license:asl2.0))))
 
+(define-public rust-skim-0.7
+  (deprecated-package "rust-skim-0.7" skim-0.7))
+
 (define-public rust-slab-0.4
   (package
     (name "rust-slab")
diff --git a/gnu/packages/rust-apps.scm b/gnu/packages/rust-apps.scm
index 24430120ca..f2ab4a0c44 100644
--- a/gnu/packages/rust-apps.scm
+++ b/gnu/packages/rust-apps.scm
@@ -503,9 +503,9 @@  gitignore rules.")
          (base32
           "13jzbmjz1bmmfr0i80hw6ar484mgabx3hbpb2ynhk0ddqi0yr58m"))))))
 
-(define-public rust-skim-0.9
+(define-public skim
   (package
-    (name "rust-skim")
+    (name "skim")
     (version "0.9.3")
     (source
       (origin
@@ -587,9 +587,9 @@  gitignore rules.")
     (description "This package provides a fuzzy finder in Rust.")
     (license license:expat)))
 
-(define-public rust-skim-0.7
+(define-public skim-0.7
   (package
-    (inherit rust-skim-0.9)
+    (inherit skim)
     (name "rust-skim")
     (version "0.7.0")
     (source
-- 
2.30.0