diff mbox series

[bug#78195] Remove unused use-module that can lead to circular dependencies

Message ID tencent_2CD91135EB0C4D5E6864A8C004B2F4315C09@qq.com
State New
Headers
Series [bug#78195] Remove unused use-module that can lead to circular dependencies |

Commit Message

Dan Khodabakhsh May 1, 2025, 5:55 p.m. UTC 
Apologies, thought I sent it as plaintext, here's another shot:

This change removes the use-module (gnu packages node-xyz) import from (gnu packages node).
node-xyz is not actually used in node and seems to have been accidentally added in f540ee5ef845946228c0e2e4cffadccd36069922.
Keeping it in can lead to circular dependency issues.

---
 gnu/packages/node.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)


base-commit: a6b40f7a2f2db3107319d1a5e099b269a462a723
-- 
2.49.0

Comments

Ludovic Courtès May 18, 2025, 8:35 p.m. UTC | #1 
Hi,

"Dan Khodabakhsh" <d@niel.khodabakh.sh> writes:

> From: Daniel Khodabakhsh <d@niel.khodabakh.sh>
> Date: Thu, 1 May 2025 08:55:41 -0700
> Subject: [PATCH] Remove use-module (gnu packages node-xyz) from (gnu packages
>  node).
>
> This change removes the use-module (gnu packages node-xyz) import from (gnu
>  packages node).
> node-xyz is not actually used in node and seems to have been accidentally
>  added in f540ee5ef845946228c0e2e4cffadccd36069922.
> Keeping it in can lead to circular dependency issues.
>
> Change-Id: I292323510b918a5e5c154a06f06cc608997557d6
> Signed-off-by: Daniel Khodabakhsh <d@niel.khodabakh.sh>

Applied, thanks!

Ludo’.
diff mbox series

Patch

diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
index 018a6b1bd0..4cad70a179 100644
--- a/gnu/packages/node.scm
+++ b/gnu/packages/node.scm
@@ -13,7 +13,7 @@ 
 ;;; Copyright © 2021, 2022 Philip McGrath <philip@philipmcgrath.com>
 ;;; Copyright © 2022 Hilton Chain <hako@ultrarare.space>
 ;;; Copyright © 2024 Efraim Flashner <efraim@flashner.co.il>
-;;; Copyright © 2024 Daniel Khodabakhsh <d.khodabakhsh@gmail.com>
+;;; Copyright © 2024, 2025 Daniel Khodabakhsh <d@niel.khodabakh.sh>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -50,7 +50,6 @@  (define-module (gnu packages node)
   #:use-module (gnu packages libevent)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages networking)
-  #:use-module (gnu packages node-xyz)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages python)