From patchwork Wed Feb 16 01:18:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Kehayias X-Patchwork-Id: 37257 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 9F63527BBEA; Wed, 16 Feb 2022 01:20:10 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,SPF_HELO_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 69A7A27BBE9 for ; Wed, 16 Feb 2022 01:20:10 +0000 (GMT) Received: from localhost ([::1]:42560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nK8zJ-0006PB-Fm for patchwork@mira.cbaines.net; Tue, 15 Feb 2022 20:20:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52242) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nK8yR-0006NF-0X for guix-patches@gnu.org; Tue, 15 Feb 2022 20:19:15 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:52958) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nK8yE-00029p-9w for guix-patches@gnu.org; Tue, 15 Feb 2022 20:19:12 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nK8yE-0005g1-4n for guix-patches@gnu.org; Tue, 15 Feb 2022 20:19:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#54019] [PATCH] doc: Fix 'setuid-program' example. Resent-From: John Kehayias Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 16 Feb 2022 01:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 54019 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 54019@debbugs.gnu.org X-Debbugs-Original-To: Guix-patches Received: via spool by submit@debbugs.gnu.org id=B.164497433421798 (code B ref -1); Wed, 16 Feb 2022 01:19:01 +0000 Received: (at submit) by debbugs.gnu.org; 16 Feb 2022 01:18:54 +0000 Received: from localhost ([127.0.0.1]:46853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nK8y5-0005fW-KY for submit@debbugs.gnu.org; Tue, 15 Feb 2022 20:18:53 -0500 Received: from lists.gnu.org ([209.51.188.17]:49728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nK8y0-0005fJ-Ep for submit@debbugs.gnu.org; Tue, 15 Feb 2022 20:18:51 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52156) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nK8y0-0006IL-64 for guix-patches@gnu.org; Tue, 15 Feb 2022 20:18:48 -0500 Received: from mail-40133.protonmail.ch ([185.70.40.133]:57497) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nK8xx-00027V-Hd for guix-patches@gnu.org; Tue, 15 Feb 2022 20:18:47 -0500 Date: Wed, 16 Feb 2022 01:18:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1644974322; bh=a4x6IM9kGck8Rp49N2voKlIGGvf5C313biMF802jBDA=; h=Date:To:From:Reply-To:Subject:Message-ID:From:To:Cc:Date:Subject: Reply-To:Feedback-ID:Message-ID; b=mdXfYPD/UvT6786kdbI6YF7lWN17E5pZgZ59S96dLXk8ZAMSa3TTR8v/6WhxTVLk4 jbmotRWqqnJO6jaF8lHDQYh+mx1mBg0psBYjs/8h1WysnZmOuZOJpgjATXcO1JWglV oqMslM8XO7I/V38B+UQkDyxMqBDRvolKKzIWpJPAMat0VSSmC/nxg4i1gSyDyrL5xa B02ZjBF3CP1v+qTNzWugKM4zJeewnC3Y5jEK67tXVjHyf+bEN0vIMptfkzxX6n4uiF uB2Z9UWz2uaIHvpE7z2Ac0uzR3domhIiASVJaj8uUwiIcDRUTARzJBFstLBbEnk5H8 a9JJRKS2IWN5g== Message-ID: MIME-Version: 1.0 Received-SPF: pass client-ip=185.70.40.133; envelope-from=john.kehayias@protonmail.com; helo=mail-40133.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" Reply-to: John Kehayias X-ACL-Warn: , John Kehayias via Guix-patches X-Patchwork-Original-From: John Kehayias via Guix-patches via From: John Kehayias X-getmail-retrieved-from-mailbox: Patches On #guix an error was reported in adding a setuid-program, but which followed the example in the manual. Looks like %setuid-programs was moved out a level in 1b87dc2f2a897f5fe0b3f8984c2544335ac87b56. The indentation was misleading (implying %setuid-programs was in the list sexp) previous to that commit. I believe this should be the correct format, and Kolev (who had the setuid-program problem on #guix) reported moving the paren fixed the error. Please see the attached patch. I did not add a copyright line for fixing this typo, but if it should be added, please do. Thanks! John From cccfce7d6d01e286277d5a847c89f428a2d66fe1 Mon Sep 17 00:00:00 2001 From: John Kehayias Date: Tue, 15 Feb 2022 20:09:09 -0500 Subject: [PATCH] doc: Fix 'setuid-program' example. %setuid-programs was previously moved to be in the list sexp instead of just the append one. This causes an "invalid G-expression input" error. Error reported by: Kolev on #guix. * doc/guix.texi (Setuid Programs): Move %setuid-programs out to the append sexp. --- doc/guix.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 039b418038..d966137dfe 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -34506,8 +34506,8 @@ Setuid Programs ;; Some fields omitted... (setuid-programs (append (list (setuid-program - (program (file-append nfs-utils "/sbin/mount.nfs"))) - %setuid-programs)))) + (program (file-append nfs-utils "/sbin/mount.nfs")))) + %setuid-programs))) @end lisp @deftp {Data Type} setuid-program -- 2.34.0