Message ID | m1seoyb11t.fsf@fastmail.net |
---|---|
State | New |
Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id C800027BBE9; Sat, 1 Feb 2025 07:03:28 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 98A6D27BBE2 for <patchwork@mira.cbaines.net>; Sat, 1 Feb 2025 07:03:26 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces@gnu.org>) id 1te7Wz-0006Fk-FW; Sat, 01 Feb 2025 02:03:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1te7Ww-0006FW-Gd for guix-patches@gnu.org; Sat, 01 Feb 2025 02:03:02 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1te7Ww-0005MS-7R for guix-patches@gnu.org; Sat, 01 Feb 2025 02:03:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=WK2OHbszXHgc70SUs/+hVWdkJ4wZiP+zSjupZFKesv4=; b=FV9Bgg4BXSpOIRJmR9Qqpvq/bnYzUhONYL2slbg5TicrXrBgRQ9HIl5zjSecVldr+jt5/5fyixGg+QHRE74Cc8ksWUQHPetWm10zVIMQ/W11tv7j9gkLRh6RgIOnpbg1O7PkKqeS3eHLoS7Xg30rUkYZZB2F7+f7I+yfElGglW4qkI92P37PoJbiEvz+4kTMyhyxzOa8s9sroD4eB9JtM8cHlcFharmDZAmn97zLlFaqQyvpmCRLauJgLA89WGTYF/1IZmqK96WZA3wu3sOfAaB/R63AxZK01PxsLehpSIR6cnJqKE9vjr2LwLWCkZMwiW32GR+GOc3stv3vCy/eow==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1te7Wv-0007ct-Pr for guix-patches@gnu.org; Sat, 01 Feb 2025 02:03:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#75986] [PATCH] gnu: Add emacs-khardel. Resent-From: Konrad Hinsen <konrad.hinsen@fastmail.net> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 01 Feb 2025 07:03:01 +0000 Resent-Message-ID: <handler.75986.B.173839334329234@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 75986 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 75986@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.173839334329234 (code B ref -1); Sat, 01 Feb 2025 07:03:01 +0000 Received: (at submit) by debbugs.gnu.org; 1 Feb 2025 07:02:23 +0000 Received: from localhost ([127.0.0.1]:56000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1te7WI-0007bS-GF for submit@debbugs.gnu.org; Sat, 01 Feb 2025 02:02:22 -0500 Received: from lists.gnu.org ([2001:470:142::17]:55808) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <konrad.hinsen@fastmail.net>) id 1te7WG-0007b6-5E for submit@debbugs.gnu.org; Sat, 01 Feb 2025 02:02:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <konrad.hinsen@fastmail.net>) id 1te7W8-00068M-KN for guix-patches@gnu.org; Sat, 01 Feb 2025 02:02:12 -0500 Received: from fout-b7-smtp.messagingengine.com ([202.12.124.150]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <konrad.hinsen@fastmail.net>) id 1te7W6-0005Je-Fm for guix-patches@gnu.org; Sat, 01 Feb 2025 02:02:12 -0500 Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfout.stl.internal (Postfix) with ESMTP id 3A6A911400CE; Sat, 1 Feb 2025 02:02:09 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Sat, 01 Feb 2025 02:02:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.net; h= cc:content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to; s=fm3; t=1738393329; x=1738479729; bh=WK2OHbszXHgc70SUs/+hVWdkJ4wZiP+z SjupZFKesv4=; b=B4apqT1NMEYfIk7o1WNl0l1WxdXAL4TBgSYFLJpCLsnrWQFh 3i3f07nZEDQVnrl/8/mmqnmclEvUPOpjzq+dCuCDNau/DUnH6mPXHdClgC4PIgIc 01ttqmuJA2bm+mwETONsKTwcqrW5cbbIIs+opI+c1n1HX2IbYR17Wf3C2MhHfDqX K6LcKNg4uVe2s3iMwPkEqEPumh67Utj4MWnSZvUl9DqG9rBM82AOB4hIY5fnY8sO aFlcAXW5yCfAeJD/fi99KG6AFGCVlCYq/mLrCYqMBnxtCu4IJXw6ELin4yzTMC0s 1bK0Otc9Mbwdw84FEyqJ9tBK7ZE3W9w2b5F0Qg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1738393329; x= 1738479729; bh=WK2OHbszXHgc70SUs/+hVWdkJ4wZiP+zSjupZFKesv4=; b=d D8mAUtGRE4o9PL3YZnjjhbDWBwMfnDU3SQQRjO6RbTTbZsX8jS3vtLCvucubMtj1 +TpNeCpTQNdSl92AbizPbfVVNZlOF1qVFRX0iO4lUxQ0M/8nytxdpQtahhYqPn5Q hHPRejaRXwU7b5giFYLqWYwHrHREhT9a69jkNbWZ8YnUjOBjgxiwNtZNXidUrYCQ iTTVswZL29X8tAaDy56QvBkRVt0kaenH9UC2wHGV2W795onjuPB7OgjipK3rffiq zg67olErJHUCyvIOwdH/WMzdGcWs/SiWEnOlnWM7u87yufwLA322Pdbk3wtPqt+H kwTHraRlZrmct+UnaHX2g== X-ME-Sender: <xms:8MadZ-mmwm4RFYJyiMWGiuYiNJBCYeY0Cy85k_IfZbfchXtsRBtfMQ> <xme:8MadZ12DmD_JhVDMOSvcml35iErF2HgZV-CTGDc8BoaRhJqtcvZyWU7wo55kJGfnZ dKj0W-UZwuyzaZ1> X-ME-Received: <xmr:8MadZ8rUEdFaOWR3VE5TbUyNON4F1Z-JDTNAtZSmmrXU7si8PD2gFbpaazvjYX3tBAk8ZZegp6FaacyFMsANWRhhDtzk-FaP> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduuddthecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvuf ffkfggtgesthdtredttddttdenucfhrhhomhepmfhonhhrrgguucfjihhnshgvnhcuoehk ohhnrhgrugdrhhhinhhsvghnsehfrghsthhmrghilhdrnhgvtheqnecuggftrfgrthhtvg hrnhepffefteeuhfekleduheejfeekleevhfekkeelhffgleejtefgfeevueelkeegvdeh necuffhomhgrihhnpehgihhthhhusgdrtghomhenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehkohhnrhgrugdrhhhinhhsvghnsehfrghsthhm rghilhdrnhgvthdpnhgspghrtghpthhtohepvddpmhhouggvpehsmhhtphhouhhtpdhrtg hpthhtohepsggttgeskhhhihhnshgvnhdrfhgrshhtmhgrihhlrdhnvghtpdhrtghpthht ohepghhuihigqdhprghttghhvghssehgnhhurdhorhhg X-ME-Proxy: <xmx:8MadZymC4KQ3ZdTqeitbVwDBTe9cVw-ajis1qOrNIa77Q9InuYuWfg> <xmx:8MadZ80FmLApr-1OWEyyBch8dj1-PMosBHDfem0zf4XR4UuWmqPRpA> <xmx:8MadZ5tC02UhL4GY-de_JuYJm4ZsAEn88JpUmRRkjJJUOBspT--5XQ> <xmx:8MadZ4UvTGwUcz9vA8WLTplELNB9UHcjNiX-Iz5QIQYJOnFODTGE5Q> <xmx:8cadZ6AfnxVrXGb7bugGdG3-0C_f4iECM9PxIbpVhiK-EUDasnyG0bWy> Feedback-ID: i184641e2:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 1 Feb 2025 02:02:08 -0500 (EST) From: Konrad Hinsen <konrad.hinsen@fastmail.net> Date: Sat, 01 Feb 2025 08:02:06 +0100 Message-ID: <m1seoyb11t.fsf@fastmail.net> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=202.12.124.150; envelope-from=konrad.hinsen@fastmail.net; helo=fout-b7-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches |
Series |
[bug#75986] gnu: Add emacs-khardel.
|
|
Commit Message
Konrad Hinsen
Feb. 1, 2025, 7:02 a.m. UTC
* gnu/packages/emacs-xyz.scm (emacs-khardel): New variable. Change-Id: I74093cc2cade2330f9981b88e7bb6f8b030d1c85 --- gnu/packages/emacs-xyz.scm | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) base-commit: d48da2d21610f9cf5f76cd846703b12beedb1fd5
Comments
Hello, Konrad Hinsen <konrad.hinsen@fastmail.net> writes: > * gnu/packages/emacs-xyz.scm (emacs-khardel): New variable. Thank you. Some comments follow. > + (version "20231126.1502") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/DamienCassou/khardel.git") You can drop the ".git" suffix. > + (commit "205e374b36252183a146a7a8f857bcf95a77edc3"))) Version is wrong: it should be "2.0.0". You do not need to provide a raw commit hash either, the "v2.0.0" tag will be fine. > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "0gqijnmj24phryi6n74iq410k0637j0li1ncdymxhk3bdmp4mb40")))) > + (build-system emacs-build-system) > + (inputs > + (list khard)) > + (propagated-inputs > + (list emacs-yaml-mode)) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'fix-path > + (lambda _ > + (substitute* "khardel.el" > + (("\\(executable-find \"khard\"\\)") > + (string-append "\"" (which "khard") > "\"")))))))) I think using `search-input-file' is more elegant than relying on `which'. Also, the latter may return unpredictable results if "khard" was already on $PATH. > + (home-page "https://github.com/DamienCassou/khardel") > + (synopsis "Emacs interface to khard") Nitpick: khard -> Khard > + (description > + "Emacs integrate with khard, a console carddav application to search and > +edit contacts in carddav/vcard format.") "Khardel provides an Emacs integration with Khard…" also, in carddav/vcard-> vCard format Could you send an updated patch? Regards,
Nicolas Goaziou via Guix-patches via <guix-patches@gnu.org> writes: >> + (add-after 'unpack 'fix-path >> + (lambda _ >> + (substitute* "khardel.el" >> + (("\\(executable-find \"khard\"\\)") >> + (string-append "\"" (which "khard") >> "\"")))))))) Also, you could use `emacs-substitute-variables' above.
Hi Nicolas, Thanks for your comments and suggestions! I just sent an updated patch. > I think using `search-input-file' is more elegant than relying on > `which'. Also, the latter may return unpredictable results if "khard" > was already on $PATH. That shouldn't happen in the build daemon, right? But I agree that "explicit is better than implicit", as Pythonistas like to say. > Nitpick: khard -> Khard Capitalization of program names is roughly as consensual as Emacs vs. vi! > Also, you could use `emacs-substitute-variables' above. Or, better yet, emacs-substitute-sexp, which I just discovered. Cheers, Konrad.
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 153785e017..6a2e0c8129 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -6773,6 +6773,39 @@ (define-public emacs-keyfreq a command.") (license license:gpl3+))) +(define-public emacs-khardel + (package + (name "emacs-khardel") + (version "20231126.1502") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/DamienCassou/khardel.git") + (commit "205e374b36252183a146a7a8f857bcf95a77edc3"))) + (file-name (git-file-name name version)) + (sha256 + (base32 "0gqijnmj24phryi6n74iq410k0637j0li1ncdymxhk3bdmp4mb40")))) + (build-system emacs-build-system) + (inputs + (list khard)) + (propagated-inputs + (list emacs-yaml-mode)) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'fix-path + (lambda _ + (substitute* "khardel.el" + (("\\(executable-find \"khard\"\\)") + (string-append "\"" (which "khard") "\"")))))))) + (home-page "https://github.com/DamienCassou/khardel") + (synopsis "Emacs interface to khard") + (description + "Emacs integrate with khard, a console carddav application to search and +edit contacts in carddav/vcard format.") + (license license:gpl3+))) + (define-public emacs-ligature (let ((commit "3d1460470736777fd8329e4bb4ac359bf4f1460a") (revision "1"))