| Message ID | ffb3e65bab0ef05dfbc3362fdc70858cd77f8a12.1697096866.git.liliana.prikler@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [bug#66481,gnome-team] gnu: tracker-miners: Update to 3.6.1. | expand |
Hello,
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> * gnu/packages/gnome.scm (tracker-miners): Update to 3.6.1.
LGTM. I think this is a small change enough that it doesn't need to go
through guix-patches (you could have pushed it already).
Am Donnerstag, dem 12.10.2023 um 10:21 -0400 schrieb Maxim Cournoyer: > Hello, > > Liliana Marie Prikler <liliana.prikler@gmail.com> writes: > > > * gnu/packages/gnome.scm (tracker-miners): Update to 3.6.1. > > LGTM. I think this is a small change enough that it doesn't need to > go through guix-patches (you could have pushed it already). IIUC the exception for small patches is no longer part of the manual. Plus, with the recent kerfluffle around tracker-miners, I prefer a review :)
Hi, Liliana Marie Prikler <liliana.prikler@gmail.com> writes: > Am Donnerstag, dem 12.10.2023 um 10:21 -0400 schrieb Maxim Cournoyer: >> Hello, >> >> Liliana Marie Prikler <liliana.prikler@gmail.com> writes: >> >> > * gnu/packages/gnome.scm (tracker-miners): Update to 3.6.1. >> >> LGTM. I think this is a small change enough that it doesn't need to >> go through guix-patches (you could have pushed it already). > IIUC the exception for small patches is no longer part of the manual. > Plus, with the recent kerfluffle around tracker-miners, I prefer a > review :) The relevant bits from info '(guix) managing patches and branches' is this: > As an exception, some changes considered “trivial” or “obvious” may be > pushed directly to the ‘master’ branch. This includes changes to fix > typos and reverting commits that caused immediate problems. This is > subject to being adjusted, allowing individuals to commit directly on > non-controversial changes on parts they’re familiar with. It mentions 'master' there but I think this was an oversight; the same should hold for any branch. And I think bumping a version field and the hash is non-controversial enough if it doesn't break the world and was tested :-).
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index 6e3933ec96..bf853bd588 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -9561,7 +9561,7 @@ (define-public tracker (define-public tracker-miners (package (name "tracker-miners") - (version "3.5.2") + (version "3.6.1") (source (origin (method url-fetch) (uri (string-append "mirror://gnome/sources/tracker-miners/" @@ -9569,7 +9569,7 @@ (define-public tracker-miners "/tracker-miners-" version ".tar.xz")) (sha256 (base32 - "0sbc3fmvqg5hvdl5sq8w77lqmk9i6vc13izcxck8winrrgx93ys0")))) + "13ljx0birrav728ik3bnlwzgas8q6rbhjbvxp7zzwy6ambafiw7f")))) (build-system meson-build-system) (arguments `(#:glib-or-gtk? #t