From patchwork Thu Mar 20 20:54:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ludovic_Court=C3=A8s?= X-Patchwork-Id: 40523 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 4B29C27BBEA; Thu, 20 Mar 2025 20:58:04 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 07A7727BBE2 for ; Thu, 20 Mar 2025 20:58:04 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tvMx2-0002aO-Eh; Thu, 20 Mar 2025 16:57:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tvMwz-0002Z9-DX for guix-patches@gnu.org; Thu, 20 Mar 2025 16:57:14 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tvMwx-0001Ys-PN for guix-patches@gnu.org; Thu, 20 Mar 2025 16:57:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:Date:From:To:Subject; bh=ozQM+lYqSSPDiTg6Dp/w4oPIGKDs4CrGaOeKp99rZWg=; b=Q75DlApb9TXeKltUGobJt87QcXJYLSLcoirdZ9Vya9+rRTb5VrSDgl1Nc4FsfNJbT4zN1Pj8UwS0wl9D3zZsUOcFph12+kbE+fGP0pG29i7gR3OGuA7Kn/fZ+/EzB7M03fn+yTrKkhfPT603BclAAHU8ePdmNeSJhu+pN6LNcWHgIaikCfZJgx+m9lvyMlGRiJ9Lf8Hj5jCydXRAniGrk/xbXBpfEtawGx6CFwfaOUE5ZSAcTHPhP/QGgXnzjTIIUVAmjaptd/Sl9lpGlaQZakWw3Yh6D1iLxap0fc3oMQiR3vrITYc14BaPGMiy7WW8KFQ4ilDnkL4w1SGYpIoSdQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tvMwx-0006ZQ-Jp for guix-patches@gnu.org; Thu, 20 Mar 2025 16:57:11 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#75810] [PATCH v7 05/16] daemon: Remount inputs as read-only. Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 20 Mar 2025 20:57:11 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75810 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 75810@debbugs.gnu.org Cc: Ludovic =?utf-8?q?Court=C3=A8s?= , Reepca Russelstein Received: via spool by 75810-submit@debbugs.gnu.org id=B75810.174250421425101 (code B ref 75810); Thu, 20 Mar 2025 20:57:11 +0000 Received: (at 75810) by debbugs.gnu.org; 20 Mar 2025 20:56:54 +0000 Received: from localhost ([127.0.0.1]:59184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tvMwc-0006WN-EM for submit@debbugs.gnu.org; Thu, 20 Mar 2025 16:56:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41202) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tvMwB-0006RR-ES for 75810@debbugs.gnu.org; Thu, 20 Mar 2025 16:56:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tvMw0-0001G6-27; Thu, 20 Mar 2025 16:56:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=ozQM+lYqSSPDiTg6Dp/w4oPIGKDs4CrGaOeKp99rZWg=; b=i3BqnwDkbZHnTgOm4lNc OynN/H5vzCzwpGBMK5jFpl/WytGJZ/mtPVtOel6Zd7Uiwa/j7PrrEPzfQ4u85aab/zkyrBib7+oAZ My5nqM0Qa/n4AgmS0U78BRDqAGSCZILTz2/Os47XciYu2QUiTnWZYhORxe85pzQDHoEZyE4K1d6fC P6yAU6fit2DYDgOUuDlJWXwQAU+LnOs/v7LjGSPEiO5uyTjETFmayvDKcQSIdwNbp+7CssV0jqPyE /9m+aGWWljc3c5bLGqkpnIL63lhF1qNaPqTDzhsTVLYM0TWv9RBoku6y+2zsXSp5lglmhbyoGzwoC znjR/bWPZemOEA==; From: Ludovic =?utf-8?q?Court=C3=A8s?= Date: Thu, 20 Mar 2025 21:54:38 +0100 Message-ID: X-Mailer: git-send-email 2.48.1 In-Reply-To: References: MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches * nix/libstore/build.cc (DerivationGoal::runChild): Remount ‘target’ as read-only. Reported-by: Reepca Russelstein Change-Id: Ib7201bcf4363be566f205d23d17fe2f55d3ad666 --- nix/libstore/build.cc | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/nix/libstore/build.cc b/nix/libstore/build.cc index 193b279b88..3861a1ffd9 100644 --- a/nix/libstore/build.cc +++ b/nix/libstore/build.cc @@ -2107,8 +2107,15 @@ void DerivationGoal::runChild() createDirs(dirOf(target)); writeFile(target, ""); } + + /* Extra flags passed with MS_BIND are ignored, hence the + extra MS_REMOUNT. */ if (mount(source.c_str(), target.c_str(), "", MS_BIND, 0) == -1) throw SysError(format("bind mount from `%1%' to `%2%' failed") % source % target); + if (source.compare(0, settings.nixStore.length(), settings.nixStore) == 0) { + if (mount(source.c_str(), target.c_str(), "", MS_BIND | MS_REMOUNT | MS_RDONLY, 0) == -1) + throw SysError(format("read-only remount of `%1%' failed") % target); + } } /* Bind a new instance of procfs on /proc to reflect our