From patchwork Mon Mar 20 16:57:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felix Lechner X-Patchwork-Id: 48220 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 8130C16F2D; Mon, 20 Mar 2023 16:59:14 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id E2E5516ECE for ; Mon, 20 Mar 2023 16:59:11 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1peIpi-0005vT-2q; Mon, 20 Mar 2023 12:58:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peIpe-0005uc-KM for guix-patches@gnu.org; Mon, 20 Mar 2023 12:58:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1peIpe-0002HB-CP for guix-patches@gnu.org; Mon, 20 Mar 2023 12:58:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1peIpe-0002hA-6P for guix-patches@gnu.org; Mon, 20 Mar 2023 12:58:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62156] [PATCH v3 2/2] lint: Append "/info/refs" to git-reference-url. Resent-From: Felix Lechner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 20 Mar 2023 16:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62156 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 62156@debbugs.gnu.org Cc: Sergey Trofimov , Felix Lechner Received: via spool by 62156-submit@debbugs.gnu.org id=B62156.167933145810321 (code B ref 62156); Mon, 20 Mar 2023 16:58:02 +0000 Received: (at 62156) by debbugs.gnu.org; 20 Mar 2023 16:57:38 +0000 Received: from localhost ([127.0.0.1]:55607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peIpF-0002gP-Uh for submit@debbugs.gnu.org; Mon, 20 Mar 2023 12:57:38 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]:49950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peIpB-0002g0-7k for 62156@debbugs.gnu.org; Mon, 20 Mar 2023 12:57:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=D8ikgbx9065o6pv cXlvVkkW15a2MxFYRWM5taKshdGY=; h=references:in-reply-to:date:subject: cc:to:from; d=lease-up.com; b=KEyjPmhLWRxT+VSEZlrXS2uLklvI1rjg+KZyMPhD t/xmDl3O4gwKcKKiCfHB2Hujm3ocVP+n75budIPM/DxI7A3Lhsp1DYXT07aiE6jM3vAoMy ZsogHIuXnCGrhCBEx4QdyLP3rzFDPpvZyT7PAR4SEWC0AyW47Dy3gvP8ubOyo= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 4d86524f (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Mon, 20 Mar 2023 16:57:32 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id fdb59c85; Mon, 20 Mar 2023 16:57:32 +0000 (UTC) Date: Mon, 20 Mar 2023 09:57:19 -0700 Message-Id: X-Mailer: git-send-email 2.39.1 In-Reply-To: References: MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Felix Lechner X-ACL-Warn: , Felix Lechner via Guix-patches X-Patchwork-Original-From: Felix Lechner via Guix-patches via From: Felix Lechner Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches For the atftp package added in the preceeding commit, lint produced this warning: gnu/packages/networking.scm:2924:5: atftp@0.8.0: URI https://git.code.sf.net/p/atftp/code not reachable: 404 ("Not Found") Thanks to Sergey Trofimov for suggesting a fix! [1] [1] https://issues.guix.gnu.org/62156#3 It was implemented here, and the warning disappeared. * guix/lint.scm (check-source): Append "/info/refs" to git-reference-url. Co-authored-by: Sergey Trofimov --- guix/lint.scm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/guix/lint.scm b/guix/lint.scm index a1a27873d9..394d68c472 100644 --- a/guix/lint.scm +++ b/guix/lint.scm @@ -1224,7 +1224,9 @@ (define (warnings-for-uris uris) '()))) ((git-reference? (origin-uri origin)) (warnings-for-uris - (list (string->uri (git-reference-url (origin-uri origin)))))) + (list (string->uri (string-append + (git-reference-url (origin-uri origin)) + "/info/refs"))))) ((or (svn-reference? (origin-uri origin)) (svn-multi-reference? (origin-uri origin))) (let ((uri (svn-reference-uri-with-userinfo (origin-uri origin))))