Message ID | fab4c4c9-2bb9-0fa2-9050-75ba632b3d8e@zedat.fu-berlin.de |
---|---|
State | New |
Headers | show |
Series | [bug#62293] gnu: add pcsc-cyberjack | expand |
Hi Arvid, On 2023-03-20 10:28, Arvid Krein wrote: > +(define-public pcsc-cyberjack > + (package > + (name "pcsc-cyberjack") > + (version "3.99.5final.sp15") > + (synopsis "PC/SC driver for cyberJack chipcard readers") > + (home-page "http://www.reiner-sct.com/") > + (description > + "REINER SCT cyberJack USB chipcard reader user space driver > + This package includes the IFD driver for the cyberJack contactless > + (RFID) and contact USB chipcard reader.") How about “This package includes the IFD driver for the cyberJack contactless (RFID) and contact USB chipcard readers.” > + (source (origin > + (method url-fetch) > + (uri > + "https://support.reiner-sct.de/downloads/LINUX/V3.99.5_SP15/pcsc-cyberjack_3.99.5final.SP15.tar.bz2")> + (sha256 > + (base32 > + "0yj6plgb245r218v6lgdabb3422hxyrw8rrpf5b8fwah4j1w5dxc")))) How about indenting this as: (source (origin (method url-fetch) (uri ...) (sha256 (base32 ...)))) > + (arguments > + (list #:configure-flags #~(list (string-append "--with-usbdropdir=" > + (ungexp output "out") > + "/pcsc/drivers") > + (string-append "--bindir=" > + (ungexp output "tools") > + "/bin")) > + #:phases '(modify-phases %standard-phases > + (add-after 'install 'install-tools > + (lambda _ > + (invoke "make" "-C" "tools/cjflash" "install")))))))) Do this: (arguments (list #:configure-flags #~(list (string-append "--with-usbdropdir=" #$output "/pcsc/drivers") (string-append "--bindir=" #$output:tools "/bin")) #:phases #~(modify-phases %standard-phases ... ))) Also, please reorder the package fields into something like: (define-public ... (package (name ...) (version ...) (source ...) (build-system ...) (arguments ...) (native-inputs ...) (inputs ...) (outputs ...) (synopsis ...) (description ...) (home-page ...) (license ...))) Cheers, Bruno
This Patch was merged in commit a7d9cd742c3149bb014db95f88d1158d590bc124 so I am marking it as done. Greetings, Arvid
diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm index a7f5e3acf9..521f6f226b 100644 --- a/gnu/packages/security-token.scm +++ b/gnu/packages/security-token.scm @@ -967,3 +967,37 @@ (define-public cardpeek It also has limited support for Mifare Classic compatible cards (Thalys card)") (license license:gpl3+) (home-page "http://pannetrat.com/Cardpeek"))) + +(define-public pcsc-cyberjack + (package + (name "pcsc-cyberjack") + (version "3.99.5final.sp15") + (synopsis "PC/SC driver for cyberJack chipcard readers") + (home-page "http://www.reiner-sct.com/") + (description + "REINER SCT cyberJack USB chipcard reader user space driver + This package includes the IFD driver for the cyberJack contactless + (RFID) and contact USB chipcard reader.") + (license license:lgpl2.1+) + (native-inputs (list pkg-config)) + (inputs (list pcsc-lite libusb)) + (outputs '("out" "tools")) + (source (origin + (method url-fetch) + (uri + "https://support.reiner-sct.de/downloads/LINUX/V3.99.5_SP15/pcsc-cyberjack_3.99.5final.SP15.tar.bz2") + (sha256 + (base32 + "0yj6plgb245r218v6lgdabb3422hxyrw8rrpf5b8fwah4j1w5dxc")))) + (build-system gnu-build-system) + (arguments + (list #:configure-flags #~(list (string-append "--with-usbdropdir=" + (ungexp output "out") + "/pcsc/drivers") + (string-append "--bindir=" + (ungexp output "tools") + "/bin")) + #:phases '(modify-phases %standard-phases + (add-after 'install 'install-tools