Message ID | f82a90585121e5c2d40c3dddd47de0cc169fb52a.1724775512.git.zhengjunjie@iscas.ac.cn |
---|---|
State | New |
Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id A151327BBEA; Tue, 27 Aug 2024 17:28:04 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE,SPF_HELO_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id C03B527BBEB for <patchwork@mira.cbaines.net>; Tue, 27 Aug 2024 17:28:02 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces@gnu.org>) id 1siz2I-0002km-OD; Tue, 27 Aug 2024 12:27:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1siz2F-0002hO-5l for guix-patches@gnu.org; Tue, 27 Aug 2024 12:27:11 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1siz2E-0000md-SO for guix-patches@gnu.org; Tue, 27 Aug 2024 12:27:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:Date:From:To:Subject; bh=TLQRqeOEXpmw2EDsvEdOOzmpJCNaCNQ32SDK5c1KyaQ=; b=WSZa491C+SX0GSKWcC1YMH6bE9WCYr5q8wJCwqBSzdV7MHE+x9hEls9Zo5R1Karw6LvG3hf7ma3uNRernK49vMkzUhzsK3F/rQDILFo0Bwt2sr6zKvI2KeBBtfu43eNw+j0uYF23HrH7SK0NLf6RxvDTMVpwbB+f173zEddLBP7yD3HSGGR0k0kyORRxTtzeYi/Ik4BuI5IXsbFs6aCs5F8eGtAxBR+qX0vOmEGTXuL6XDBKw+qHvzBDB8zSAoXKjvCkDuGrTXd8J13zDMQ8HJW63wJtHk7KITWXypcYGIMjHi+KfmEWhnAXxjTNyw5zXgGg+lzdfRgDIaZKzh6U4w==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1siz35-0001RR-KP; Tue, 27 Aug 2024 12:28:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72835] [PATCH qt-team 32/38] gnu: Add qtconnectivity. Resent-From: Zheng Junjie <zhengjunjie@iscas.ac.cn> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: maxim.cournoyer@gmail.com, iyzsong@envs.net, guix-patches@gnu.org Resent-Date: Tue, 27 Aug 2024 16:28:03 +0000 Resent-Message-ID: <handler.72835.B72835.17247760275382@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72835 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 72835@debbugs.gnu.org Cc: Maxim Cournoyer <maxim.cournoyer@gmail.com>, =?utf-8?b?5a6L5paH5q2m?= <iyzsong@envs.net> X-Debbugs-Original-Xcc: Maxim Cournoyer <maxim.cournoyer@gmail.com>, =?utf-8?b?5a6L5paH5q2m?= <iyzsong@envs.net> Received: via spool by 72835-submit@debbugs.gnu.org id=B72835.17247760275382 (code B ref 72835); Tue, 27 Aug 2024 16:28:03 +0000 Received: (at 72835) by debbugs.gnu.org; 27 Aug 2024 16:27:07 +0000 Received: from localhost ([127.0.0.1]:47411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1siz2A-0001Od-S4 for submit@debbugs.gnu.org; Tue, 27 Aug 2024 12:27:07 -0400 Received: from smtp84.cstnet.cn ([159.226.251.84]:52372 helo=cstnet.cn) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <zhengjunjie@iscas.ac.cn>) id 1siz1y-0001LD-3P for 72835@debbugs.gnu.org; Tue, 27 Aug 2024 12:26:56 -0400 Received: from m.tailaa68d.ts.net (unknown [117.147.108.198]) by APP-05 (Coremail) with SMTP id zQCowACnEUEP_s1mbhXLCg--.5542S11; Wed, 28 Aug 2024 00:25:54 +0800 (CST) From: Zheng Junjie <zhengjunjie@iscas.ac.cn> Date: Wed, 28 Aug 2024 00:25:40 +0800 Message-ID: <f82a90585121e5c2d40c3dddd47de0cc169fb52a.1724775512.git.zhengjunjie@iscas.ac.cn> X-Mailer: git-send-email 2.45.2 In-Reply-To: <cover.1724775511.git.zhengjunjie@iscas.ac.cn> References: <cover.1724775511.git.zhengjunjie@iscas.ac.cn> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: zQCowACnEUEP_s1mbhXLCg--.5542S11 X-Coremail-Antispam: 1UD129KBjvJXoW7ZFWkGry3Cw4fCrWxtF4kXrb_yoW8Jw4kpF WUArsIv3WrGa1xJrZ3W3WxWrn8urZ7CrW8Cw47Z347Kw15C3y8ZryIy39xGrsFgr1UJw1j 9F48XF4UWry5CFJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUU9Sb7Iv0xC_Zr1lb4IE77IF4wAFF20E14v26rWj6s0DM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28IrcIa0xkI8VA2jI 8067AKxVWUAVCq3wA2048vs2IY020Ec7CjxVAFwI0_JFI_Gr1l8cAvFVAK0II2c7xJM28C jxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW5JVW7JwA2z4x0Y4vE2Ix0cI 8IcVCY1x0267AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIE14v26r4j6F4UM28EF7xvwVC2z280 aVCY1x0267AKxVW8JVW8Jr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4 CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jrv_JF1lYx0Ex4A2jsIE14v26r1j6r4UMcvj eVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCF04k20xvY0x0EwIxGrwCFx2IqxV CFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r10 6r1rMI8E67AF67kF1VAFwI0_Jr0_JrylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxV W5JVW7JwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG 6r1j6r1xMIIF0xvEx4A2jsIE14v26r4j6F4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr 1UYxBIdaVFxhVjvjDU0xZFpf9x07jo0PfUUUUU= X-Originating-IP: [117.147.108.198] X-CM-SenderInfo: x2kh0wxmxqyx3h6l2u1dvotugofq/ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches |
Series |
update qt6 to 6.7.2
|
|
Commit Message
Z572
Aug. 27, 2024, 4:25 p.m. UTC
* gnu/packages/qt.scm (qtconnectivity): New variable. Change-Id: Ia2c1d9d260b47cd3a18c9ab5ac7e8f5ea83b7e11 --- gnu/packages/qt.scm | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+)
Comments
Hi Zheng, Zheng Junjie <zhengjunjie@iscas.ac.cn> writes: > * gnu/packages/qt.scm (qtconnectivity): New variable. > > Change-Id: Ia2c1d9d260b47cd3a18c9ab5ac7e8f5ea83b7e11 > --- > gnu/packages/qt.scm | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm > index 1956fec57a..df8759b832 100644 > --- a/gnu/packages/qt.scm > +++ b/gnu/packages/qt.scm > @@ -1688,6 +1688,29 @@ (define-public qtconnectivity-5 > (description "The Qt Connectivity modules provides modules for interacting > with Bluetooth and NFC."))) > > +(define-public qtconnectivity > + (package > + (inherit qtsvg) > + (name "qtconnectivity") > + (version "6.6.3") > + (source (origin > + (method url-fetch) > + (uri (qt-url name version)) > + (sha256 > + (base32 > + "066mf4d6a81ywviwr8bvm1mpm2ykjzysvcc0v2x82h5bl28vl6h9")))) > + (native-inputs > + (list perl pkg-config qtdeclarative)) > + (inputs > + (list bluez qtbase)) > + (arguments (substitute-keyword-arguments (package-arguments qtsvg) > + ((#:phases phases) > + #~(modify-phases #$phases > + (delete 'delete-installed-tests))))) > + (synopsis "Qt Connectivity module") > + (description "The Qt Connectivity modules provides modules for interacting > +with Bluetooth and NFC."))) I'm not sure about using inheritance this way; the packages are unrelated. You'd at least want to ensure propagated-inputs is forced to '() in case qtsvg had some added in the future. I think I had refrained from using this style for Qt 6 thus far, as I found it obfuscated the package definitions for Qt 5. Could you rewrite it to use the style as used for example by qtshadertools? Only the home page and license fields need to be specified. So it's one field difference, and better clarity. Could you please send a v2?
Maxim Cournoyer <maxim.cournoyer@gmail.com> writes: > Hi Zheng, > > Zheng Junjie <zhengjunjie@iscas.ac.cn> writes: > >> * gnu/packages/qt.scm (qtconnectivity): New variable. >> >> Change-Id: Ia2c1d9d260b47cd3a18c9ab5ac7e8f5ea83b7e11 >> --- >> gnu/packages/qt.scm | 23 +++++++++++++++++++++++ >> 1 file changed, 23 insertions(+) >> >> diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm >> index 1956fec57a..df8759b832 100644 >> --- a/gnu/packages/qt.scm >> +++ b/gnu/packages/qt.scm >> @@ -1688,6 +1688,29 @@ (define-public qtconnectivity-5 >> (description "The Qt Connectivity modules provides modules for interacting >> with Bluetooth and NFC."))) >> >> +(define-public qtconnectivity >> + (package >> + (inherit qtsvg) >> + (name "qtconnectivity") >> + (version "6.6.3") >> + (source (origin >> + (method url-fetch) >> + (uri (qt-url name version)) >> + (sha256 >> + (base32 >> + "066mf4d6a81ywviwr8bvm1mpm2ykjzysvcc0v2x82h5bl28vl6h9")))) >> + (native-inputs >> + (list perl pkg-config qtdeclarative)) >> + (inputs >> + (list bluez qtbase)) >> + (arguments (substitute-keyword-arguments (package-arguments qtsvg) >> + ((#:phases phases) >> + #~(modify-phases #$phases >> + (delete 'delete-installed-tests))))) >> + (synopsis "Qt Connectivity module") >> + (description "The Qt Connectivity modules provides modules for interacting >> +with Bluetooth and NFC."))) > > I'm not sure about using inheritance this way; the packages are > unrelated. You'd at least want to ensure propagated-inputs is forced to > '() in case qtsvg had some added in the future. > > I think I had refrained from using this style for Qt 6 thus far, as I > found it obfuscated the package definitions for Qt 5. > > Could you rewrite it to use the style as used for example by > qtshadertools? Only the home page and license fields need to be > specified. So it's one field difference, and better clarity. > > Could you please send a v2? done.
diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm index 1956fec57a..df8759b832 100644 --- a/gnu/packages/qt.scm +++ b/gnu/packages/qt.scm @@ -1688,6 +1688,29 @@ (define-public qtconnectivity-5 (description "The Qt Connectivity modules provides modules for interacting with Bluetooth and NFC."))) +(define-public qtconnectivity + (package + (inherit qtsvg) + (name "qtconnectivity") + (version "6.6.3") + (source (origin + (method url-fetch) + (uri (qt-url name version)) + (sha256 + (base32 + "066mf4d6a81ywviwr8bvm1mpm2ykjzysvcc0v2x82h5bl28vl6h9")))) + (native-inputs + (list perl pkg-config qtdeclarative)) + (inputs + (list bluez qtbase)) + (arguments (substitute-keyword-arguments (package-arguments qtsvg) + ((#:phases phases) + #~(modify-phases #$phases + (delete 'delete-installed-tests))))) + (synopsis "Qt Connectivity module") + (description "The Qt Connectivity modules provides modules for interacting +with Bluetooth and NFC."))) + (define-public qtwebsockets-5 (package (inherit qtsvg-5) (name "qtwebsockets")