diff mbox series

[bug#69949,gnome-team] gnu: pango@1.90: Disable failing test.

Message ID f6ef6580c8d10f0fe0470101db710b8d26768f0f.1711143964.git.vivien@planete-kraus.eu
State New
Headers show
Series [bug#69949,gnome-team] gnu: pango@1.90: Disable failing test. | expand

Commit Message

Vivien Kraus March 22, 2024, 9:45 p.m. UTC 
* gnu/packages/gtk.scm (pango-1.90) [snippet]: Disable failing test.

Change-Id: Ib0f6dcd42c9475c4b543400f43836c2f3f8db16f
---
Dear Guix,

I don’t fully understand what’s pango 1.90, but it has an unfixed failing test
and very few users, so maybe disabling the failing test could be OK.

What do you think?

Best regards,

Vivien

 gnu/packages/gtk.scm | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)


base-commit: a9951a74a591a9b22ee2d93d8efe0523c6c42c97

Comments

Christopher Baines March 24, 2024, 10:33 a.m. UTC | #1 
Vivien Kraus via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/gtk.scm (pango-1.90) [snippet]: Disable failing test.
>
> Change-Id: Ib0f6dcd42c9475c4b543400f43836c2f3f8db16f
> ---
> Dear Guix,
>
> I don’t fully understand what’s pango 1.90, but it has an unfixed failing test
> and very few users, so maybe disabling the failing test could be OK.
>
> What do you think?

Sounds good, I've pushed this to gnome-team as
d48d0baad16b3acc393f74a9fbea358ce94f1449.

Thanks,

Chris
diff mbox series

Patch

diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index f43eece4f2..9252315fd2 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -466,7 +466,12 @@  (define-public pango-1.90
                #~(begin
                    (substitute* "pango/pangocairo-font.c"
                      (("cairo_user_font_face_set_render_color_glyph_func")
-                      "cairo_user_font_face_set_render_glyph_func"))))))))
+                      "cairo_user_font_face_set_render_glyph_func"))
+                   ;; Disable a failing test
+                   (substitute* "tests/testmisc.c"
+                     (("\
+g_test_add_func \\(\"/layout/gravity-metrics2\", test_gravity_metrics2\\);")
+                      ""))))))))
 
 (define-public pangox-compat
   (package