From patchwork Sun Jul 25 06:12:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sarah Morgensen X-Patchwork-Id: 31592 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 4969527BC6B; Sun, 25 Jul 2021 07:13:11 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS, T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 52EF527BC78 for ; Sun, 25 Jul 2021 07:13:09 +0100 (BST) Received: from localhost ([::1]:38678 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7XNs-0005Y3-EG for patchwork@mira.cbaines.net; Sun, 25 Jul 2021 02:13:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41764) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7XNn-0005Xv-9S for guix-patches@gnu.org; Sun, 25 Jul 2021 02:13:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35818) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m7XNn-0004OE-1x for guix-patches@gnu.org; Sun, 25 Jul 2021 02:13:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m7XNm-0007Xs-GX for guix-patches@gnu.org; Sun, 25 Jul 2021 02:13:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49729] [PATCH core-updates] build-system/gnu: Make gzip files writable before resetting timestamps. Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 25 Jul 2021 06:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 49729 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 49729@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.162719353928948 (code B ref -1); Sun, 25 Jul 2021 06:13:02 +0000 Received: (at submit) by debbugs.gnu.org; 25 Jul 2021 06:12:19 +0000 Received: from localhost ([127.0.0.1]:47364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7XN4-0007Wq-Qg for submit@debbugs.gnu.org; Sun, 25 Jul 2021 02:12:19 -0400 Received: from lists.gnu.org ([209.51.188.17]:54410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7XN1-0007Wf-Em for submit@debbugs.gnu.org; Sun, 25 Jul 2021 02:12:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41702) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7XN0-0005Ws-UP for guix-patches@gnu.org; Sun, 25 Jul 2021 02:12:14 -0400 Received: from out1.migadu.com ([2001:41d0:2:863f::]:22534) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7XMw-0003bp-Im for guix-patches@gnu.org; Sun, 25 Jul 2021 02:12:14 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1627193526; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=BUxwaVAnUiyHnTCDo9HkPm7jYEyyZMd8FhPPcEFzJNM=; b=dmCboz3OOMjhuhw0cNVVgNchG/YKR6mWx4cOvZXTJGK1j147rzvooJjMQpew+3tfpolaXW YefJMuut12uRT0L/doazD4YqFwn9CwQAlEtwAqrFrHwzWfSL0SYnZERr9plYh/uiMJa4q5 3CxPwiz7osy86ZNjeNUgIP/Hj/d6gD8= From: Sarah Morgensen Date: Sat, 24 Jul 2021 23:12:04 -0700 Message-Id: MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev Received-SPF: pass client-ip=2001:41d0:2:863f::; envelope-from=iskarian@mgsn.dev; helo=out1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches guix/build/gnu-build-system.scm (reset-gzip-timestamps): Ensure gzip files are writable before resetting their timestamps. --- Hello Guix, There have been a number of instances of packages having to add their own phase before 'reset-gzip-timestamps to make the gzip files writable--perhaps the gnu build system can take care of this itself? WDYT? -- Sarah guix/build/gnu-build-system.scm | 2 ++ 1 file changed, 2 insertions(+) base-commit: 7bef3be1d318beebaf48ac6daa3140205ba18e98 diff --git a/guix/build/gnu-build-system.scm b/guix/build/gnu-build-system.scm index d0f7413268..d84411c090 100644 --- a/guix/build/gnu-build-system.scm +++ b/guix/build/gnu-build-system.scm @@ -598,6 +598,8 @@ and 'man/'. This phase moves directories to the right place if needed." (string-suffix? ".tgz" file)) (gzip-file? file))) #:stat lstat))) + ;; Ensure the files are writable. + (for-each make-file-writable files) (for-each reset-gzip-timestamp files))) (match outputs