| Message ID | f1088c0e21260d70fecd0a1d1afc7bfcebc895bf.1690739463.git.csantosb@inventati.org |
|---|---|
| State | New |
| Headers | show |
| Series | [bug#64961] gnu: emacs-mastodon: Update to 1.0.0-1.20dec88. | expand |
Hi Cayetano, Cayetano Santos <csantosb@inventati.org> skribis: > * gnu/packages/emacs-xyz.scm (emacs-mastodon): Update to 1.0.0-1.20dec88. [...] > + (let ((commit "20dec8871c9bb5f5e418bfc197e7533b5e3065e3") > + (revision "1")) > + (package > + (name "emacs-mastodon") > + (version (git-version "1.0.0" revision commit)) Normally we only package releases, unless there’s a good reason to grab a snapshot, in which case there should be a comment explaining it. What’s the situation here? > + (synopsis "Emacs client for Mastodon") > + (description "@code{mastodon.el} is an Emacs client for Mastodon, the > federated microblogging social network.") > (license license:gpl3+))) There’s a missing paren here, which made qa.guix unhappy: https://qa.guix.gnu.org/issue/64961 :-) Thanks, Ludo’.
>dim. 20 août 2023 at 23:20, Ludovic Courtès <ludo@gnu.org> wrote: > Hi Cayetano, > > Cayetano Santos <csantosb@inventati.org> skribis: > >> * gnu/packages/emacs-xyz.scm (emacs-mastodon): Update to 1.0.0-1.20dec88. > > [...] > >> + (let ((commit "20dec8871c9bb5f5e418bfc197e7533b5e3065e3") >> + (revision "1")) >> + (package >> + (name "emacs-mastodon") >> + (version (git-version "1.0.0" revision commit)) > > Normally we only package releases, unless there’s a good reason to grab > a snapshot, in which case there should be a comment explaining it. > > What’s the situation here? Nothing special here, other than the fact that latest stable is from more than one year ago. In my opinion, we should debate this question once for ever in a broader discussion about emacs packages (guix-devel?): what do we package ? only stables (obsolete packages, see emacs-org-ref) ? always master (we run after latest commit) ? something in between (current situation) ? As for now, it is stated that we privilege releases ... except that emacs-xyz is full of snapshots, and for a good reason (case of magit, etc.), probably due to releases being too old (author just forgets releasing). (By the way. Similar debate comes to using melpa or melpa-stable) What do you think ? Cayetano
Hi Cayetano, Cayetano Santos <csantosb@inventati.org> skribis: >>dim. 20 août 2023 at 23:20, Ludovic Courtès <ludo@gnu.org> wrote: > >> Hi Cayetano, >> >> Cayetano Santos <csantosb@inventati.org> skribis: >> >>> * gnu/packages/emacs-xyz.scm (emacs-mastodon): Update to 1.0.0-1.20dec88. >> >> [...] >> >>> + (let ((commit "20dec8871c9bb5f5e418bfc197e7533b5e3065e3") >>> + (revision "1")) >>> + (package >>> + (name "emacs-mastodon") >>> + (version (git-version "1.0.0" revision commit)) >> >> Normally we only package releases, unless there’s a good reason to grab >> a snapshot, in which case there should be a comment explaining it. >> >> What’s the situation here? > > Nothing special here, other than the fact that latest stable is from > more than one year ago. OK. I went ahead and applied the patch (there’s not a lot at stake in this case anyway). > In my opinion, we should debate this question once for ever in a broader > discussion about emacs packages (guix-devel?): what do we package ? > only stables (obsolete packages, see emacs-org-ref) ? always master (we > run after latest commit) ? something in between (current situation) ? The question’s not really up for debate in that the policy is to choose releases, unless there’s a good reason not to do so. But… > As for now, it is stated that we privilege releases ... except that > emacs-xyz is full of snapshots, and for a good reason (case of magit, > etc.), probably due to releases being too old (author just forgets > releasing). … you’re right of course. The situation of Emacs packages is a bit special I guess, and it would be worth clarifying that somehow. Please feel free to launch the discussion on guix-devel! Thanks, Ludo’.
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index e8d1ac6034..0bd4ff93bc 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -32420,35 +32420,37 @@ (define-public emacs-wc-mode (license license:gpl3+))) (define-public emacs-mastodon - (package - (name "emacs-mastodon") - (version "1.0.0") - (source (origin - (method git-fetch) - (uri (git-reference - (url "https://codeberg.org/martianh/mastodon.el") - (commit version))) - (file-name (git-file-name name version)) - (sha256 - (base32 - "13swcbvwhjl8ksrgzvmfafkgd3iz8znk49bs1n48w3g9qvh097w7")))) - (build-system emacs-build-system) - (arguments - (list #:phases - #~(modify-phases %standard-phases - ;; Move the source files to the top level, which is included in - ;; the EMACSLOADPATH. - (add-after 'unpack 'move-source-files - (lambda _ - (let ((el-files (find-files "./lisp" ".*\\.el$"))) - (for-each (lambda (f) - (rename-file f (basename f))) - el-files))))))) - (propagated-inputs - (list emacs-request)) - (home-page "https://codeberg.org/martianh/mastodon.el") - (synopsis "Emacs client for Mastodon") - (description "@code{mastodon.el} is an Emacs client for Mastodon, the + (let ((commit "20dec8871c9bb5f5e418bfc197e7533b5e3065e3") + (revision "1")) + (package + (name "emacs-mastodon") + (version (git-version "1.0.0" revision commit)) + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://codeberg.org/martianh/mastodon.el") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "15cfjny99yw5frdp8nlyazlwgscvfvbinsj0fbdfprxf50k2zjs6")))) + (build-system emacs-build-system) + (arguments + (list #:phases + #~(modify-phases %standard-phases + ;; Move the source files to the top level, which is included in + ;; the EMACSLOADPATH. + (add-after 'unpack 'move-source-files + (lambda _ + (let ((el-files (find-files "./lisp" ".*\\.el$"))) + (for-each (lambda (f) + (rename-file f (basename f))) + el-files))))))) + (propagated-inputs + (list emacs-request emacs-ts emacs-persist)) + (home-page "https://codeberg.org/martianh/mastodon.el") + (synopsis "Emacs client for Mastodon") + (description "@code{mastodon.el} is an Emacs client for Mastodon, the federated microblogging social network.") (license license:gpl3+)))