| Message ID | ecc51538ce9f5ff8c339cd75870737cf75cf4b96.1711547888.git.csantosb@inventati.org |
|---|---|
| State | New |
| Headers | show |
| Series | [bug#70029] gnu: Add emacs-eglot-jl. | expand |
Hello, Cayetano Santos via Guix-patches via <guix-patches@gnu.org> writes: > * gnu/packages/emacs-xyz.scm (emacs-eglot-jl): New variable. Thanks. > +(define-public emacs-eglot-jl > + (package > + (name "emacs-eglot-jl") > + (version "2.3.0") > + (source > + (origin > + (method git-fetch) > + (uri > + (git-reference > + (url "https://github.com/non-Jedi/eglot-jl.git") Nitpick: I think ".git" suffixes are usually removed. > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "144q4fj3am165vf1vx2ljlsmpn8vvvs1b95qi3rxlwqskkx0lig3")))) > + (build-system emacs-build-system) > + (propagated-inputs (list emacs-eglot)) > + (arguments > + '(#:include '("^[^/]+.el$" > + "^[^/]+.jl$" > + "^[^/]+.toml$"))) This is a bit verbose, and ignores %default-include variable. I suggest (using G-expressions just because we can) (arguments (list #:include #~(cons "\\.(jl|toml)$" %default-include))) > + (home-page "https://github.com/non-Jedi/eglot-jl") > + (synopsis "Julia support for eglot") Nitpick: Julia support for Eglot > + (description > + "This package adds support for @code{emacs-eglot} to the Julia language.") Nitpick: ... support for Eglot to the Julia language. > + (license:cc-by2.0))) I think there is a typo here. You mean (license license:cc-by2.0) However, it seems to licensed under CC0 terms. Could you send an updated patch? Regards,
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index d4819c62ce..f2af107671 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -12313,6 +12313,33 @@ (define-public emacs-eglot-tempel library with Eglot instead of Yasnippet.") (license license:gpl3+)))) +(define-public emacs-eglot-jl + (package + (name "emacs-eglot-jl") + (version "2.3.0") + (source + (origin + (method git-fetch) + (uri + (git-reference + (url "https://github.com/non-Jedi/eglot-jl.git") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "144q4fj3am165vf1vx2ljlsmpn8vvvs1b95qi3rxlwqskkx0lig3")))) + (build-system emacs-build-system) + (propagated-inputs (list emacs-eglot)) + (arguments + '(#:include '("^[^/]+.el$" + "^[^/]+.jl$" + "^[^/]+.toml$"))) + (home-page "https://github.com/non-Jedi/eglot-jl") + (synopsis "Julia support for eglot") + (description + "This package adds support for @code{emacs-eglot} to the Julia language.") + (license:cc-by2.0))) + (define-public emacs-consult-xdg-recent-files (let ((commit "593023ffb99a368152ebd4e739488fa560bdfdea") (revision "0"))
* gnu/packages/emacs-xyz.scm (emacs-eglot-jl): New variable. Signed-off-by: Cayetano Santos <csantosb@inventati.org> --- gnu/packages/emacs-xyz.scm | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) base-commit: 656baadf83f2812c0ff79f4f2f0b5f1e927ed8a5