diff mbox series

[bug#71618] guix: gnu-build-system: Add %gnu-build-system-default-modules.

Message ID ebe4129898ffdef998af427e62a5b43da4499f28.1718651435.git.~@wolfsden.cz
State New
Headers show
Series [bug#71618] guix: gnu-build-system: Add %gnu-build-system-default-modules. | expand

Commit Message

Tomas Volf June 17, 2024, 7:10 p.m. UTC
Since there is no exported variable containing the list of default modules,
every place that needs it (in #:modules for example) needs to copy&paste it
and pray it never changes.

This commit provides new variable exposing the default list, allowing
constructs like this:

    #:modules
    `((srfi srfi-34)
      ,@%gnu-build-system-default-modules)

* guix/build-system/gnu.scm (%gnu-build-system-default-modules): New variable.
(define-module)[#:export]: Export it.

Change-Id: I1da392019a95aea5edeac0301db26266efbeee9e
---
 guix/build-system/gnu.scm | 3 +++
 1 file changed, 3 insertions(+)

Comments

Bruno Victal June 18, 2024, 7:30 p.m. UTC | #1
Hi Tomas,

On 2024-06-17 20:10, Tomas Volf wrote:
> Since there is no exported variable containing the list of default modules,
> every place that needs it (in #:modules for example) needs to copy&paste it
> and pray it never changes.

I believe this has been addressed with [1].

[1]: <https://issues.guix.gnu.org/66426>
Maxim Cournoyer June 19, 2024, 1:04 a.m. UTC | #2
Hi,

Bruno Victal <mirai@makinata.eu> writes:

> Hi Tomas,
>
> On 2024-06-17 20:10, Tomas Volf wrote:
>> Since there is no exported variable containing the list of default modules,
>> every place that needs it (in #:modules for example) needs to copy&paste it
>> and pray it never changes.
>
> I believe this has been addressed with [1].
>
> [1]: <https://issues.guix.gnu.org/66426>

Indeed, thanks for the heads-up.  That's on the core-updates branch.

Closing.
diff mbox series

Patch

diff --git a/guix/build-system/gnu.scm b/guix/build-system/gnu.scm
index cdbb547773..53ac2f8cbd 100644
--- a/guix/build-system/gnu.scm
+++ b/guix/build-system/gnu.scm
@@ -28,6 +28,7 @@  (define-module (guix build-system gnu)
   #:use-module (srfi srfi-1)
   #:use-module (ice-9 match)
   #:export (%gnu-build-system-modules
+            %gnu-build-system-default-modules
             %strip-flags
             %strip-directories
             gnu-build
@@ -60,6 +61,8 @@  (define %default-modules
   '((guix build gnu-build-system)
     (guix build utils)))
 
+(define %gnu-build-system-default-modules %default-modules)
+
 (define* (package-with-explicit-inputs/deprecated p inputs
                                                   #:optional
                                                   (loc (current-source-location))