From patchwork Mon Nov 11 01:35:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandros Theodotou X-Patchwork-Id: 16074 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id E0A3717720; Mon, 11 Nov 2019 01:37:11 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 92F7F1771D for ; Mon, 11 Nov 2019 01:37:11 +0000 (GMT) Received: from localhost ([::1]:48342 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iTydj-00080S-1P for patchwork@mira.cbaines.net; Sun, 10 Nov 2019 20:37:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51497) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iTydb-00080G-L3 for guix-patches@gnu.org; Sun, 10 Nov 2019 20:37:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iTyda-00080g-9E for guix-patches@gnu.org; Sun, 10 Nov 2019 20:37:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:44056) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iTyda-00080a-5E for guix-patches@gnu.org; Sun, 10 Nov 2019 20:37:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iTydZ-0003nO-Vr for guix-patches@gnu.org; Sun, 10 Nov 2019 20:37:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#38129] [PATCH] gnu: Add sherlock-lv2. Resent-From: Alexandros Theodotou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 11 Nov 2019 01:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38129 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke , 38129@debbugs.gnu.org Received: via spool by 38129-submit@debbugs.gnu.org id=B38129.157343617214524 (code B ref 38129); Mon, 11 Nov 2019 01:37:01 +0000 Received: (at 38129) by debbugs.gnu.org; 11 Nov 2019 01:36:12 +0000 Received: from localhost ([127.0.0.1]:52877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iTycm-0003mB-8w for submit@debbugs.gnu.org; Sun, 10 Nov 2019 20:36:12 -0500 Received: from mout01.posteo.de ([185.67.36.141]:46357) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iTych-0003lf-Jd for 38129@debbugs.gnu.org; Sun, 10 Nov 2019 20:36:10 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id F15BE16005C for <38129@debbugs.gnu.org>; Mon, 11 Nov 2019 02:36:00 +0100 (CET) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 47BD3g0MnPz6tm9; Mon, 11 Nov 2019 02:35:58 +0100 (CET) Message-ID: From: Alexandros Theodotou Date: Mon, 11 Nov 2019 01:35:56 +0000 In-Reply-To: <87ftivl8pw.fsf@devup.no> References: <57b24a50e1feeed51edf264b6bb97480@posteo.net> <87ftivl8pw.fsf@devup.no> User-Agent: Evolution 3.30.5 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi Marius, > I think your MUA might have mangled these > patches somehow, as many of them are "corrupt" according to git. Can > you try to resend these? I'll comment on the patches individually > meanwhile. Sorry about that. I got Gnome evolution sorted out now so hopefully it's better. send-mail doesn't work for me at the moment so I'll add the patches as attachments. > > + `(("glibc" ,glibc) > > I don't think this is needed? I guess it's not, I removed it. > > + ("libx11" ,libx11) > > + ("mesa" ,mesa) > > + ("serd" ,serd) > > + ("sratom" ,sratom))) > > + (native-inputs > > + `(("flex" ,flex) > > + ("lv2" ,lv2) > > + ("sord" ,sord) > > I don't know anything about LV2 and sord, are these inputs really > only > used for the build process itself? :-) Sord is an input for sratom (which is in the inputs above), but the build fails if I remove this from the native-inputs. For LV2, technically, it's only needed in the build process since it's just a header file with specifications. Since this is an LV2 plugin, a host that will be loading it will include LV2 itself and will have it as an input, so the plugin doesn't really need it. It doesn't hurt to add it as an input either, but I think having it as a build input is more "correct". By the way, the Arch packagers do the same for most LV2 plugins. > > + ("pkg-config" ,pkg-config))) > > + (synopsis "Investigative LV2 plugin bundle") > > + (description "The Sherlock plugin bundle contains LV2 plugins > > for > > +visualizing LV2 atom, MIDI and OSC events. They can be used for > > monitoring and > > +debugging of event signal flows inside plugin graphs.") > > Two spaces after periods, as per 'guix lint'. Fixed, thank you! From 8bda974a93874bcf366ba78bdf3329f73245e90f Mon Sep 17 00:00:00 2001 From: Alexandros Theodotou Date: Fri, 8 Nov 2019 10:59:52 +0000 Subject: [PATCH] gnu: Add sherlock-lv2. * gnu/packages/music.scm: (sherlock-lv2): New variable. --- gnu/packages/music.scm | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index 2f023685df..690434202e 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -4737,3 +4737,34 @@ for integration into status line generators or other command-line tools.") effects. It contains a bitcrusher, delay, distortion, equalizer, compressor, and reverb.") (license license:gpl2+))) + +(define-public sherlock-lv2 + (package + (name "sherlock-lv2") + (version "0.20.0") + (source + (origin + (method url-fetch) + (uri (string-append + "https://git.open-music-kontrollers.ch/lv2/" + "sherlock.lv2/snapshot/sherlock.lv2-" + version ".tar.xz")) + (sha256 + (base32 + "1c5xajpss9h8lbyx160bbzg8va50n2d74qwnxig9sf468rzmha1y")))) + (build-system meson-build-system) + (inputs + `(("libx11" ,libx11) + ("mesa" ,mesa) + ("sratom" ,sratom))) + (native-inputs + `(("flex" ,flex) + ("lv2" ,lv2) + ("sord" ,sord) + ("pkg-config" ,pkg-config))) + (synopsis "Investigative LV2 plugin bundle") + (description "The Sherlock plugin bundle contains LV2 plugins for +visualizing LV2 atom, MIDI and OSC events. They can be used for monitoring +and debugging of event signal flows inside plugin graphs.") + (home-page "https://open-music-kontrollers.ch/lv2/sherlock/") + (license license:artistic2.0))) -- 2.24.0