| Message ID | ea-mime-629300ff-ca9-8667229@www-7.mailo.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [bug#55674] gnu: emacs-helpful: Update to 209971b | expand |
| Context | Check | Description |
|---|---|---|
| cbaines/comparison | success | View comparision |
| cbaines/git branch | success | View Git branch |
| cbaines/applying patch | success | View Laminar job |
| cbaines/issue | success | View issue |
Am Sonntag, dem 29.05.2022 um 07:13 +0200 schrieb yarl-baudig@mailoo.org: > * gnu/packages/emacs-xyz.scm (emacs-helpful): Update to 209971b > > Fixes <https://issues.guix.gnu.org/55674> > Thanks to upstream pull request by Erik Šabič > --- > gnu/packages/emacs-xyz.scm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > index 31822dc641..90fd8a49d6 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -20131,7 +20131,7 @@ (define-public emacs-download-region > (define-public emacs-helpful > (package > (name "emacs-helpful") > - (version "0.18") > + (version "209971ba9f576ba080352642cfbf25df5692b1d7") Commit hashes are not versions. Furthermore, there has been more than just that bugfix since – as a workaround I think it'd be more reasonable to just disable that one test until the next release. Cheers
> Commit hashes are not versions. Furthermore, there has been more than > just that bugfix since – as a workaround I think it'd be more > reasonable to just disable that one test until the next release. Or Erik Šabič might try its patch against version 0.19 then add it to the package definition and let a comment that as soon as it is updated to 0.20, the patch can go away?
Am Sonntag, dem 29.05.2022 um 11:09 +0200 schrieb yarl-baudig@mailoo.org: > > Commit hashes are not versions. Furthermore, there has been more > > than just that bugfix since – as a workaround I think it'd be more > > reasonable to just disable that one test until the next release. > > Or Erik Šabič might try [their] patch against version 0.19 then add > it to the package definition and let a comment that as soon as it is > updated to 0.20, the patch can go away? That'd work too, but it'd be a slightly larger patch to create :)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 31822dc641..90fd8a49d6 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -20131,7 +20131,7 @@ (define-public emacs-download-region (define-public emacs-helpful (package (name "emacs-helpful") - (version "0.18") + (version "209971ba9f576ba080352642cfbf25df5692b1d7") (source (origin (method git-fetch) @@ -20140,7 +20140,7 @@ (define-public emacs-helpful (commit version))) (file-name (git-file-name name version)) (sha256 - (base32 "0gdjxykqkal2x765mi51m99i5ql23i1fy909wy4mzj5ajhjfgqcc")))) + (base32 "1qrxr0ybvdvx6qw6akb1pv074bmffv4m57855kk8fr1vp4w07z0i")))) (build-system emacs-build-system) (propagated-inputs (list emacs-elisp-refs emacs-dash emacs-s emacs-f emacs-shut-up))