From patchwork Wed Jun 29 00:38:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Kehayias X-Patchwork-Id: 40392 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 1A21427BBEA; Wed, 29 Jun 2022 01:40:34 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,SPF_HELO_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 4001D27BBE9 for ; Wed, 29 Jun 2022 01:40:33 +0100 (BST) Received: from localhost ([::1]:49286 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o6Lku-0005SF-Ar for patchwork@mira.cbaines.net; Tue, 28 Jun 2022 20:40:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40804) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6LkQ-0005RS-S0 for guix-patches@gnu.org; Tue, 28 Jun 2022 20:40:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34550) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o6LkQ-0002sE-IH for guix-patches@gnu.org; Tue, 28 Jun 2022 20:40:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o6LkQ-00076d-Fx for guix-patches@gnu.org; Tue, 28 Jun 2022 20:40:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56200] [PATCH v2] gnu: linux-libre: Enable the AMD HSA driver. References: In-Reply-To: Resent-From: John Kehayias Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 29 Jun 2022 00:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56200 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Leo Famulari , "56200@debbugs.gnu.org" <56200@debbugs.gnu.org> Received: via spool by 56200-submit@debbugs.gnu.org id=B56200.165646316227260 (code B ref 56200); Wed, 29 Jun 2022 00:40:02 +0000 Received: (at 56200) by debbugs.gnu.org; 29 Jun 2022 00:39:22 +0000 Received: from localhost ([127.0.0.1]:56680 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6Ljj-00075Z-3K for submit@debbugs.gnu.org; Tue, 28 Jun 2022 20:39:22 -0400 Received: from mail-4316.protonmail.ch ([185.70.43.16]:17695) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6LjY-00075C-U0 for 56200@debbugs.gnu.org; Tue, 28 Jun 2022 20:39:18 -0400 Date: Wed, 29 Jun 2022 00:38:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1656463141; x=1656722341; bh=io/Cgiwi8mD01fic0alIq0jrds/zVQVacJNR8//WXc0=; h=Date:To:From:Reply-To:Subject:Message-ID:Feedback-ID:From:To:Cc: Date:Subject:Reply-To:Feedback-ID:Message-ID; b=dssp80E3NGM2yEj7Q+5iI9Dy8y+nWGL3bjkYioScvXq0IyF/0xww3PzdCsISpScGc sYxq/qGCQnnjona07RvVPgVC7BBodoxVvWdtsPmqMw3tZv7RFUkNvipcJKT4Sj9S4G FkJIaQ6nnX7HfnOEjw6tQVRdj4SuSRPic9r4F40H1riksL++ik6RRfNprX8I1C9Vny mH0JcFheAC2bcMygEifjnZzUAq5Hh4ZqgwSnjjcHYjMHcB0iPp2gASs8Qdn9l6wgou DYu2EsUqWfis+Ge3th0cTDoVcPb6MBD0GXyWE1rC14ehb5+WGet47c6/nWL4kiIxFN nTMdqMAMbg63g== Message-ID: Feedback-ID: 7805494:user:proton MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" Reply-to: John Kehayias X-ACL-Warn: , John Kehayias via Guix-patches X-Patchwork-Original-From: John Kehayias via Guix-patches via From: John Kehayias X-getmail-retrieved-from-mailbox: Patches Hi Leo, ------- Original Message ------- On Tuesday, June 28th, 2022 at 4:30 PM, Leo Famulari wrote: > > Don't worry too much about the commit message. The only thing to change > is that the commit title should begin with 'gnu', which is how we denote > that the change touches the software distribution portion of guix.git, > as compared to 'guix', 'doc', 'build', etc. But I would normally handle > that without mentioning it to the patch submitter. > I'm decent with package patch notes now, but wasn't sure how the kernel config fit in. I did look for examples but must have found one that missed the convention. > > * gnu/packages/aux-files/linux-libre/5.18-x86_64.conf: Enable the AMD > > Heterogeneous System Architecture (HSA) driver. > > > Grepping for 'HSA_AMD' in guix.git: > > ------ > $ git grep HSA_AMD > gnu/packages/aux-files/linux-libre/4.14-x86_64.conf:CONFIG_HSA_AMD=m > gnu/packages/aux-files/linux-libre/4.19-x86_64.conf:CONFIG_HSA_AMD=m > gnu/packages/aux-files/linux-libre/4.9-x86_64.conf:CONFIG_HSA_AMD=m > gnu/packages/aux-files/linux-libre/5.10-arm64.conf:# CONFIG_HSA_AMD is not set > gnu/packages/aux-files/linux-libre/5.10-x86_64.conf:# CONFIG_HSA_AMD is not set > gnu/packages/aux-files/linux-libre/5.15-arm64.conf:# CONFIG_HSA_AMD is not set > gnu/packages/aux-files/linux-libre/5.15-x86_64.conf:# CONFIG_HSA_AMD is not set > gnu/packages/aux-files/linux-libre/5.18-arm64.conf:# CONFIG_HSA_AMD is not set > gnu/packages/aux-files/linux-libre/5.18-x86_64.conf:# CONFIG_HSA_AMD is not set > gnu/packages/aux-files/linux-libre/5.4-arm64.conf:# CONFIG_HSA_AMD is not set > gnu/packages/aux-files/linux-libre/5.4-x86_64.conf:# CONFIG_HSA_AMD is not set > ------ > > Yes, there is actually some 64-bit ARM hardware by AMD. > > Anyways, I recommend enabling it in all the configs where it is > currently not set. What do you think? If that's a good idea, can you > send a revised patch? > > Don't worry about building all the kernels if that's a burden; I'll > check that they build before pushing. > I've attached a v2 of the patch that sets it for all the configurations where the option was listed. Note that a few had it "enabled" with setting it to "m", but I don't think that does anything, per my testing. And looking at the documentation, seems like it should be "y": https://www.kernelconfig.io/config_hsa_amd I did not build any of the other kernels, but how does that look now? Thanks again! John From 3adb2143ba54b3c0751bda7c8b06ad9f02681b65 Mon Sep 17 00:00:00 2001 From: John Kehayias Date: Mon, 27 Jun 2022 00:33:54 -0400 Subject: [PATCH] gnu: linux-libre: Enable the AMD HSA driver. * gnu/packages/aux-files/linux-libre/4.14-x86_64.conf gnu/packages/aux-files/linux-libre/4.19-x86_64.conf, gnu/packages/aux-files/linux-libre/4.9-x86_64.conf, gnu/packages/aux-files/linux-libre/5.10-arm64.conf, gnu/packages/aux-files/linux-libre/5.10-x86_64.conf, gnu/packages/aux-files/linux-libre/5.15-arm64.conf, gnu/packages/aux-files/linux-libre/5.15-x86_64.conf, gnu/packages/aux-files/linux-libre/5.18-arm64.conf, gnu/packages/aux-files/linux-libre/5.18-x86_64.conf, gnu/packages/aux-files/linux-libre/5.4-arm64.conf, gnu/packages/aux-files/linux-libre/5.4-x86_64.conf: Enable the AMD Heterogeneous System Architecture (HSA) driver. --- gnu/packages/aux-files/linux-libre/4.14-x86_64.conf | 2 +- gnu/packages/aux-files/linux-libre/4.19-x86_64.conf | 2 +- gnu/packages/aux-files/linux-libre/4.9-x86_64.conf | 2 +- gnu/packages/aux-files/linux-libre/5.10-arm64.conf | 2 +- gnu/packages/aux-files/linux-libre/5.10-x86_64.conf | 2 +- gnu/packages/aux-files/linux-libre/5.15-arm64.conf | 2 +- gnu/packages/aux-files/linux-libre/5.15-x86_64.conf | 2 +- gnu/packages/aux-files/linux-libre/5.18-arm64.conf | 2 +- gnu/packages/aux-files/linux-libre/5.18-x86_64.conf | 2 +- gnu/packages/aux-files/linux-libre/5.4-arm64.conf | 2 +- gnu/packages/aux-files/linux-libre/5.4-x86_64.conf | 2 +- 11 files changed, 11 insertions(+), 11 deletions(-) diff --git a/gnu/packages/aux-files/linux-libre/4.14-x86_64.conf b/gnu/packages/aux-files/linux-libre/4.14-x86_64.conf index 3953ee9104..86445b40ba 100644 --- a/gnu/packages/aux-files/linux-libre/4.14-x86_64.conf +++ b/gnu/packages/aux-files/linux-libre/4.14-x86_64.conf @@ -5683,7 +5683,7 @@ CONFIG_DRM_PANEL_BRIDGE=y # Display Interface Bridges # CONFIG_DRM_ANALOGIX_ANX78XX=m -CONFIG_HSA_AMD=m +CONFIG_HSA_AMD=y CONFIG_DRM_HISI_HIBMC=m # CONFIG_DRM_TINYDRM is not set # CONFIG_DRM_LEGACY is not set diff --git a/gnu/packages/aux-files/linux-libre/4.19-x86_64.conf b/gnu/packages/aux-files/linux-libre/4.19-x86_64.conf index 24148dcf6f..4ae1aa33f0 100644 --- a/gnu/packages/aux-files/linux-libre/4.19-x86_64.conf +++ b/gnu/packages/aux-files/linux-libre/4.19-x86_64.conf @@ -5894,7 +5894,7 @@ CONFIG_DRM_PANEL_BRIDGE=y # Display Interface Bridges # CONFIG_DRM_ANALOGIX_ANX78XX=m -CONFIG_HSA_AMD=m +CONFIG_HSA_AMD=y CONFIG_DRM_HISI_HIBMC=m # CONFIG_DRM_TINYDRM is not set CONFIG_DRM_XEN=y diff --git a/gnu/packages/aux-files/linux-libre/4.9-x86_64.conf b/gnu/packages/aux-files/linux-libre/4.9-x86_64.conf index 8d47127ece..afc7973373 100644 --- a/gnu/packages/aux-files/linux-libre/4.9-x86_64.conf +++ b/gnu/packages/aux-files/linux-libre/4.9-x86_64.conf @@ -5465,7 +5465,7 @@ CONFIG_DRM_BRIDGE=y # Display Interface Bridges # CONFIG_DRM_ANALOGIX_ANX78XX=m -CONFIG_HSA_AMD=m +CONFIG_HSA_AMD=y # CONFIG_DRM_LEGACY is not set # diff --git a/gnu/packages/aux-files/linux-libre/5.10-arm64.conf b/gnu/packages/aux-files/linux-libre/5.10-arm64.conf index a612819ee9..046c310d85 100644 --- a/gnu/packages/aux-files/linux-libre/5.10-arm64.conf +++ b/gnu/packages/aux-files/linux-libre/5.10-arm64.conf @@ -5848,7 +5848,7 @@ CONFIG_DRM_AMD_DC=y CONFIG_DRM_AMD_DC_SI=y # end of Display Engine Configuration -# CONFIG_HSA_AMD is not set +CONFIG_HSA_AMD=y CONFIG_DRM_NOUVEAU=m # CONFIG_NOUVEAU_LEGACY_CTX_SUPPORT is not set CONFIG_NOUVEAU_PLATFORM_DRIVER=y diff --git a/gnu/packages/aux-files/linux-libre/5.10-x86_64.conf b/gnu/packages/aux-files/linux-libre/5.10-x86_64.conf index 4dfb742813..2760c71f62 100644 --- a/gnu/packages/aux-files/linux-libre/5.10-x86_64.conf +++ b/gnu/packages/aux-files/linux-libre/5.10-x86_64.conf @@ -6304,7 +6304,7 @@ CONFIG_DRM_AMD_DC_SI=y # CONFIG_DEBUG_KERNEL_DC is not set # end of Display Engine Configuration -# CONFIG_HSA_AMD is not set +CONFIG_HSA_AMD=y CONFIG_DRM_NOUVEAU=m # CONFIG_NOUVEAU_LEGACY_CTX_SUPPORT is not set CONFIG_NOUVEAU_DEBUG=5 diff --git a/gnu/packages/aux-files/linux-libre/5.15-arm64.conf b/gnu/packages/aux-files/linux-libre/5.15-arm64.conf index d67461d051..3a3d144330 100644 --- a/gnu/packages/aux-files/linux-libre/5.15-arm64.conf +++ b/gnu/packages/aux-files/linux-libre/5.15-arm64.conf @@ -6100,7 +6100,7 @@ CONFIG_DRM_AMD_DC=y CONFIG_DRM_AMD_DC_SI=y # end of Display Engine Configuration -# CONFIG_HSA_AMD is not set +CONFIG_HSA_AMD=y CONFIG_DRM_NOUVEAU=m # CONFIG_NOUVEAU_LEGACY_CTX_SUPPORT is not set CONFIG_NOUVEAU_PLATFORM_DRIVER=y diff --git a/gnu/packages/aux-files/linux-libre/5.15-x86_64.conf b/gnu/packages/aux-files/linux-libre/5.15-x86_64.conf index abb1c98fcb..8fbb48bcb6 100644 --- a/gnu/packages/aux-files/linux-libre/5.15-x86_64.conf +++ b/gnu/packages/aux-files/linux-libre/5.15-x86_64.conf @@ -6482,7 +6482,7 @@ CONFIG_DRM_AMD_DC_DCN=y CONFIG_DRM_AMD_SECURE_DISPLAY=y # end of Display Engine Configuration -# CONFIG_HSA_AMD is not set +CONFIG_HSA_AMD=y CONFIG_DRM_NOUVEAU=m # CONFIG_NOUVEAU_LEGACY_CTX_SUPPORT is not set CONFIG_NOUVEAU_DEBUG=5 diff --git a/gnu/packages/aux-files/linux-libre/5.18-arm64.conf b/gnu/packages/aux-files/linux-libre/5.18-arm64.conf index 0175565bf3..929b0a128c 100644 --- a/gnu/packages/aux-files/linux-libre/5.18-arm64.conf +++ b/gnu/packages/aux-files/linux-libre/5.18-arm64.conf @@ -6265,7 +6265,7 @@ CONFIG_DRM_AMD_DC=y CONFIG_DRM_AMD_DC_SI=y # end of Display Engine Configuration -# CONFIG_HSA_AMD is not set +CONFIG_HSA_AMD=y CONFIG_DRM_NOUVEAU=m # CONFIG_NOUVEAU_LEGACY_CTX_SUPPORT is not set CONFIG_NOUVEAU_PLATFORM_DRIVER=y diff --git a/gnu/packages/aux-files/linux-libre/5.18-x86_64.conf b/gnu/packages/aux-files/linux-libre/5.18-x86_64.conf index 658e01187b..c8502e42c8 100644 --- a/gnu/packages/aux-files/linux-libre/5.18-x86_64.conf +++ b/gnu/packages/aux-files/linux-libre/5.18-x86_64.conf @@ -6687,7 +6687,7 @@ CONFIG_DRM_AMD_DC_DCN=y CONFIG_DRM_AMD_SECURE_DISPLAY=y # end of Display Engine Configuration -# CONFIG_HSA_AMD is not set +CONFIG_HSA_AMD=y CONFIG_DRM_NOUVEAU=m # CONFIG_NOUVEAU_LEGACY_CTX_SUPPORT is not set CONFIG_NOUVEAU_DEBUG=5 diff --git a/gnu/packages/aux-files/linux-libre/5.4-arm64.conf b/gnu/packages/aux-files/linux-libre/5.4-arm64.conf index d2ba5871e0..3b05083301 100644 --- a/gnu/packages/aux-files/linux-libre/5.4-arm64.conf +++ b/gnu/packages/aux-files/linux-libre/5.4-arm64.conf @@ -5523,7 +5523,7 @@ CONFIG_DRM_AMD_DC=y # CONFIG_DEBUG_KERNEL_DC is not set # end of Display Engine Configuration -# CONFIG_HSA_AMD is not set +CONFIG_HSA_AMD=y CONFIG_DRM_NOUVEAU=m # CONFIG_NOUVEAU_LEGACY_CTX_SUPPORT is not set CONFIG_NOUVEAU_PLATFORM_DRIVER=y diff --git a/gnu/packages/aux-files/linux-libre/5.4-x86_64.conf b/gnu/packages/aux-files/linux-libre/5.4-x86_64.conf index 7cf92478c1..7325ac21fc 100644 --- a/gnu/packages/aux-files/linux-libre/5.4-x86_64.conf +++ b/gnu/packages/aux-files/linux-libre/5.4-x86_64.conf @@ -6108,7 +6108,7 @@ CONFIG_DRM_AMD_DC_DSC_SUPPORT=y # CONFIG_DEBUG_KERNEL_DC is not set # end of Display Engine Configuration -# CONFIG_HSA_AMD is not set +CONFIG_HSA_AMD=y CONFIG_DRM_NOUVEAU=m # CONFIG_NOUVEAU_LEGACY_CTX_SUPPORT is not set CONFIG_NOUVEAU_DEBUG=5 -- 2.36.1