From patchwork Sun Nov 12 03:06:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: spacecadet X-Patchwork-Id: 56362 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 1963927BBEA; Sun, 12 Nov 2023 03:07:38 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id DB1DA27BBE2 for ; Sun, 12 Nov 2023 03:07:33 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r20ok-0003w4-6u; Sat, 11 Nov 2023 22:07:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r20oj-0003vw-Ft for guix-patches@gnu.org; Sat, 11 Nov 2023 22:07:21 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r20oj-0002of-7r for guix-patches@gnu.org; Sat, 11 Nov 2023 22:07:21 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r20pN-0000Gu-Si for guix-patches@gnu.org; Sat, 11 Nov 2023 22:08:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#67119] [PATCH 3/4] gnu: ovmf: Update ovmf-aarch64 to use GCC5. References: In-Reply-To: Resent-From: spacecadet@purge.sh Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 12 Nov 2023 03:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67119 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 67119@debbugs.gnu.org Received: via spool by 67119-submit@debbugs.gnu.org id=B67119.1699758425980 (code B ref 67119); Sun, 12 Nov 2023 03:08:01 +0000 Received: (at 67119) by debbugs.gnu.org; 12 Nov 2023 03:07:05 +0000 Received: from localhost ([127.0.0.1]:54728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r20oS-0000Fj-II for submit@debbugs.gnu.org; Sat, 11 Nov 2023 22:07:04 -0500 Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]:58441) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r20oQ-0000FC-8b for 67119@debbugs.gnu.org; Sat, 11 Nov 2023 22:07:02 -0500 Received: by mail.gandi.net (Postfix) with ESMTPA id 6DB24E0003 for <67119@debbugs.gnu.org>; Sun, 12 Nov 2023 03:06:13 +0000 (UTC) MIME-Version: 1.0 Date: Sun, 12 Nov 2023 03:06:13 +0000 From: spacecadet@purge.sh Message-ID: X-Sender: spacecadet@purge.sh X-GND-Sasl: spacecadet@purge.sh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Updating OVMF to 202308 requires GCC5, packages inheriting from ovmf also need to be updated. --- gnu/packages/firmware.scm | 61 ++++++++++++++++++++------------------- 1 file changed, 31 insertions(+), 30 deletions(-) + (mkdir-p fmw) + (copy-file (string-append "Build/ArmVirtQemu-AARCH64/RELEASE_" #$toolchain-ver "/FV/QEMU_EFI.fd") + (string-append fmw "/ovmf_aarch64.bin"))))))))) + (supported-systems %supported-systems)))) (define-public ovmf-arm (package diff --git a/gnu/packages/firmware.scm b/gnu/packages/firmware.scm index 53b89e4d90..e713aa9ac6 100644 --- a/gnu/packages/firmware.scm +++ b/gnu/packages/firmware.scm @@ -981,36 +981,37 @@ (define-public ovmf license:bsd-2 license:bsd-3 license:bsd-4))))) (define-public ovmf-aarch64 - (package - (inherit ovmf) - (name "ovmf-aarch64") - (native-inputs - (append (package-native-inputs ovmf) - (if (not (string-prefix? "aarch64" (%current-system))) - `(("cross-gcc" ,(cross-gcc "aarch64-linux-gnu")) - ("cross-binutils" ,(cross-binutils "aarch64-linux-gnu"))) - '()))) - (arguments - (substitute-keyword-arguments (package-arguments ovmf) - ((#:phases phases) - #~(modify-phases #$phases - #$@(if (string-prefix? "aarch64" (%current-system)) - '() - '((add-before 'configure 'set-env - (lambda _ - (setenv "GCC49_AARCH64_PREFIX" "aarch64-linux-gnu-"))))) - (replace 'build - (lambda _ - (invoke "build" "-a" "AARCH64" "-t" "GCC49" - "-p" "ArmVirtPkg/ArmVirtQemu.dsc"))) - (delete 'build-x64) - (replace 'install - (lambda _ - (let ((fmw (string-append #$output "/share/firmware"))) - (mkdir-p fmw) - (copy-file "Build/ArmVirtQemu-AARCH64/RELEASE_GCC49/FV/QEMU_EFI.fd" - (string-append fmw "/ovmf_aarch64.bin"))))))))) - (supported-systems %supported-systems))) + (let ((toolchain-ver "GCC5")) + (package + (inherit ovmf) + (name "ovmf-aarch64") + (native-inputs + (append (package-native-inputs ovmf) + (if (not (string-prefix? "aarch64" (%current-system))) + `(("cross-gcc" ,(cross-gcc "aarch64-linux-gnu")) + ("cross-binutils" ,(cross-binutils "aarch64-linux-gnu"))) + '()))) + (arguments + (substitute-keyword-arguments (package-arguments ovmf) + ((#:phases phases) + #~(modify-phases #$phases + #$@(if (string-prefix? "aarch64" (%current-system)) + '() + #~((add-before 'configure 'set-env + (lambda _ + (setenv (string-append #$toolchain-ver "_AARCH64_PREFIX") "aarch64-linux-gnu-"))))) + (replace 'build + (lambda _ + (invoke "build" "-a" "AARCH64" "-t" #$toolchain-ver + "-p" "ArmVirtPkg/ArmVirtQemu.dsc"))) + (delete 'build-x64) + (replace 'install + (lambda _ + (let ((fmw (string-append #$output "/share/firmware")))