From patchwork Mon Sep 16 20:10:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sharlatan Hellseher X-Patchwork-Id: 67993 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id CF75527BBEA; Mon, 16 Sep 2024 21:13:01 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 8CBAA27BBE2 for ; Mon, 16 Sep 2024 21:13:01 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sqI5b-0002zR-F7; Mon, 16 Sep 2024 16:12:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqI5Z-0002pQ-5n for guix-patches@gnu.org; Mon, 16 Sep 2024 16:12:49 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sqI5Y-0002lm-SP for guix-patches@gnu.org; Mon, 16 Sep 2024 16:12:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:Date:From:To:Subject; bh=GuHxGFYkzH+Na8JNM2sh7ZwX15dtgmJlmQPcfytYcSY=; b=IflQT34PeI54aKbguLvHwNa/u0a4jaWRgFTB1LrfjCuKygeXRXzs37frFKA+2/RENRJ6YWyJRrl3l6PtjGk2Oye9QQPk0UP+H+PAZM/PLmsDanonYfL8vBvTzGxoRcmzM3TiXN5OP6B2IV9fsTZTZD3x6ACjMrag7M9LRZtfdVpNcyAUla1ylPD+8AEig3ZGhUZkyLXG8Qit17r2mreGJPOTJAGjboMXe++RpaQOXZNvJS+CN2oYGOFyt7Jv3PhLd+g0nteZAEcmLnnw9cYiyjhnSLxfZT2N6rPU97Uz2o/K9NDF553RciLHCnmYIpYaKST8q+8Fn/St6JkAG9/MYw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sqI5m-0005iP-HF for guix-patches@gnu.org; Mon, 16 Sep 2024 16:13:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#73299] [PATCH v2 3/3] gnu: go-github-com-golang-protobuf: Remove redundant phase. Resent-From: Sharlatan Hellseher Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 16 Sep 2024 20:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73299 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 73299@debbugs.gnu.org Cc: Sharlatan Hellseher Received: via spool by 73299-submit@debbugs.gnu.org id=B73299.172651754421899 (code B ref 73299); Mon, 16 Sep 2024 20:13:02 +0000 Received: (at 73299) by debbugs.gnu.org; 16 Sep 2024 20:12:24 +0000 Received: from localhost ([127.0.0.1]:53377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqI59-0005h5-Q9 for submit@debbugs.gnu.org; Mon, 16 Sep 2024 16:12:24 -0400 Received: from mail-wr1-f54.google.com ([209.85.221.54]:43292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqI54-0005gQ-Dk for 73299@debbugs.gnu.org; Mon, 16 Sep 2024 16:12:19 -0400 Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-374c5bab490so3976771f8f.1 for <73299@debbugs.gnu.org>; Mon, 16 Sep 2024 13:12:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726517459; x=1727122259; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GuHxGFYkzH+Na8JNM2sh7ZwX15dtgmJlmQPcfytYcSY=; b=PsjOkQMkdjH1QJ+AF1BhEOvlNJmNr/GcVLka5ejqATOewmuWMw38oMZZlTL0ebDAAq pEnrF+9ull8givzJqGghaiRbaRUG2Kcy4bI7Tr2nH3ygQFaT+nifgIBY3LLA4Ax9Xv/v DdwMY6/H5LIa0RDqDeDtcXuhmtDcbEMrELL0iywtWyF8Sh6xXfM1uziYJCeaqZrKVoXM aCUSIxJEMHI/UhKUmb4+kEyVIIDV0YVisIOssk/SWX3c9DE1J6fLM0AVCvJZ7XYQitqu Zl/SOaJKvtmqwpKQJqBLvBqPHpuvZwgQIKHUvhVMs9c0Zi6a5V3PSKdIScPcMyX6QNK/ ysqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726517459; x=1727122259; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GuHxGFYkzH+Na8JNM2sh7ZwX15dtgmJlmQPcfytYcSY=; b=trbX/auwUx36qacbcbfM1rb51JddSBf3/hOdJRvpwHkHnL4KjO9MhEmjAK4VgcdqwP DpZ1t9eZzVgU0QDac4jPUjdiE8wQJKpObNrZ/8v1tx/JepB1Cobb680BpaJRoSOFq4FY QX7jVxnBUe6bxVR2cSQ/5a7CuF2QMpZEblH2KPxSILI3hEcasfn77AAHF+5QXw7ne1xG lwKsWvt/E62HUPtadmPP/RxhbzUaaQS+QhuK3wt5fQLLPQ4t6VuLNCGNejGJxFZi8PqT JKA2hzcfWxkCUWSnDLYHs56bucUi6LlN5qVyNUwKvDbHwZVweW6Wpiy7Jk07iE9DPKLh fS0Q== X-Gm-Message-State: AOJu0Yz66EPYeafh2a0xabc8l787FOtND0Crk3KgNJHp6IZCyK3YP24N u+sbw1mbetp8nXWClg2QeVMENjAB7hVlbRcBDPkK7+guLewKvy74hRpcIYOB X-Google-Smtp-Source: AGHT+IFr4bn+GjaDoJ6tbUKFdZmccbQ3TEmLjYU3yOO6kkdrkFuBcNdwgbTS1Ctm/GX1LDsc3A6uNQ== X-Received: by 2002:a5d:598a:0:b0:374:c6b6:c656 with SMTP id ffacd0b85a97d-378c27f94bbmr11872014f8f.21.1726517458855; Mon, 16 Sep 2024 13:10:58 -0700 (PDT) Received: from guxtil.incerto.xyz (cpc100684-bagu15-2-0-cust967.1-3.cable.virginm.net. [86.8.111.200]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-378e73f62bfsm7922576f8f.51.2024.09.16.13.10.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Sep 2024 13:10:58 -0700 (PDT) From: Sharlatan Hellseher Date: Mon, 16 Sep 2024 21:10:50 +0100 Message-ID: X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches * gnu/packages/packages/golang-build.scm (go-github-com-golang-protobuf) [arguments]: <#:phases>: Remove 'fix-embed-files and relay on standard one. Change-Id: Ife4d86e8072588d562364534a66d41ff01851361 --- gnu/packages/golang-build.scm | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/gnu/packages/golang-build.scm b/gnu/packages/golang-build.scm index 8fdd652b63..7049acf8c2 100644 --- a/gnu/packages/golang-build.scm +++ b/gnu/packages/golang-build.scm @@ -103,24 +103,6 @@ (define-public go-github-com-golang-protobuf #:import-path "github.com/golang/protobuf" #:phases #~(modify-phases %standard-phases - ;; TODO: Implement it in go-build-system. - ;; - ;; This happens due to Golang can't determine the valid directory of - ;; the module of embed file which is symlinked during setup - ;; environment phase, but easy resolved after coping file from the - ;; store to the build directory of the current package, see details - ;; in Golang source: - ;; - ;; - URL: - ;; - commit: 82c14346d89ec0eeca114f9ca0e88516b2cda454 - ;; - file: src/cmd/go/internal/load/pkg.go#L2059 - (add-after 'unpack 'fix-embed-files - (lambda _ - (for-each (lambda (file) - (let ((file-store-path (readlink file))) - (delete-file file) - (copy-recursively file-store-path file))) - (find-files "src" ".*(editions_defaults.binpb)$")))) ;; XXX: Workaround for go-build-system's lack of Go modules ;; support. (delete 'build)