[bug#77677] gnu: librewolf: Create lib/icecat so that ICECAT_SYSTEM_DIR is set.

Message ID e5a5817bf9b46a0ddc532355f7519ab267aa1c00.1744195200.git.clement@lassieur.org
State New
Headers
Series [bug#77677] gnu: librewolf: Create lib/icecat so that ICECAT_SYSTEM_DIR is set. |

Commit Message

Clément Lassieur April 9, 2025, 10:40 a.m. UTC
  This avoids issues with Native Messaging and non-guix add-ons:
<https://issues.guix.gnu.org/77415>.

* gnu/packages/librewolf.scm (librewolf):[arguments]: Add an
'mkdir-lib-icecat' phase.

Change-Id: I2e5dc8f599708c414c9266ee3453a6beac08ee66
---
 gnu/packages/librewolf.scm | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)


base-commit: 43d30332bf3b4de0003578a7b5b27472b11183c7
  

Comments

Ian Eure April 12, 2025, 12:10 a.m. UTC | #1
Hi Clément,

Pushed as 63f323fc98, along with a version bump and a bunch of 
package cleanup I’ve been meaning to get to.

Thanks,
  -- Ian
  
Clément Lassieur April 12, 2025, 6:56 a.m. UTC | #2
On Fri, Apr 11 2025, Ian Eure wrote:

> Hi Clément,
>
> Pushed as 63f323fc98, along with a version bump and a bunch of package cleanup
> I’ve been meaning to get to.

Thanks Ian, closing!

> Thanks,
>  -- Ian
  

Patch

diff --git a/gnu/packages/librewolf.scm b/gnu/packages/librewolf.scm
index 1cb7084f231d..a98b93ba3aae 100644
--- a/gnu/packages/librewolf.scm
+++ b/gnu/packages/librewolf.scm
@@ -5,7 +5,7 @@ 
 ;;; Copyright © 2015 Sou Bunnbu <iyzsong@gmail.com>
 ;;; Copyright © 2016, 2017, 2018, 2019 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2016 Alex Griffin <a@ajgrf.com>
-;;; Copyright © 2017 Clément Lassieur <clement@lassieur.org>
+;;; Copyright © 2017, 2025 Clément Lassieur <clement@lassieur.org>
 ;;; Copyright © 2017, 2018 Nikita <nikita@n0.is>
 ;;; Copyright © 2017, 2018 ng0 <gillmann@infotropique.org>
 ;;; Copyright © 2017, 2018, 2020 Tobias Geerinckx-Rice <me@tobias.gr>
@@ -665,7 +665,12 @@  (define-public librewolf
                                                       "/default" size ".png")
                                        (string-append dest
                                                       "/librewolf.png"))))
-                          '("16" "32" "48" "64" "128"))))))
+                          '("16" "32" "48" "64" "128")))))
+          ;; Make sure ICECAT_SYSTEM_DIR is set to avoid issues with Native
+          ;; Messaging and non-guix add-ons.
+          (add-after 'install-icons 'mkdir-lib-icecat
+            (lambda _
+              (mkdir-p (string-append #$output "/lib/icecat")))))
 
       ;; Test will significantly increase build time but with little rewards.
       #:tests? #f