diff mbox series

[bug#51358,4/4] gnu: Add ocaml-charinfo-width.

Message ID e4c3684d11791b840b2ae6c24dfdba04164c5d96.1635199548.git.julien@lepiller.eu
State Accepted
Headers show
Series [bug#51358,1/4] gnu: Add ocaml-lacaml. | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job
cbaines/issue success View issue

Commit Message

Julien Lepiller Oct. 25, 2021, 10:06 p.m. UTC 
* gnu/packages/ocaml.scm (ocaml4.07-charinfo-width): Replace with...
(ocaml-charinfo-width): ...this. Use latest ocaml package.
---
 gnu/packages/ocaml.scm | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

Comments

Simon Tournier Nov. 15, 2021, 12:45 p.m. UTC | #1 
Hi Julien,

On Tue, 26 Oct 2021 at 00:06, Julien Lepiller <julien@lepiller.eu> wrote:
> * gnu/packages/ocaml.scm (ocaml4.07-charinfo-width): Replace with...
> (ocaml-charinfo-width): ...this. Use latest ocaml package.
> ---
>  gnu/packages/ocaml.scm | 16 ++++++----------
>  1 file changed, 6 insertions(+), 10 deletions(-)

LGTM.

Aside, I note that ’ocaml4.07-charinfo-width’ fails to build because
Dune version issue.  Fix or remove?


Cheers,
simon
diff mbox series

Patch

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index a6e8af8bcf..c0bb1675a2 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -3882,9 +3882,9 @@  (define-public ocaml-camomile
     ;; with an exception for linked libraries to use a different license
     (license license:lgpl2.0+)))
 
-(define-public ocaml4.07-charinfo-width
+(define-public ocaml-charinfo-width
   (package
-    (name "ocaml4.07-charinfo-width")
+    (name "ocaml-charinfo-width")
     (version "1.1.0")
     (source (origin
               (method url-fetch)
@@ -3895,15 +3895,11 @@  (define-public ocaml4.07-charinfo-width
                (base32
                 "00bv4p1yqs8y0z4z07wd9w9yyv669dikp9b04dcjbwpiy2wy0086"))))
     (build-system dune-build-system)
-    (arguments
-     `(#:ocaml ,ocaml-4.07
-       #:findlib ,ocaml4.07-findlib
-       #:dune ,ocaml4.07-dune))
     (propagated-inputs
-     `(("ocaml-result" ,(package-with-ocaml4.07 ocaml-result))
-       ("ocaml-camomile" ,(package-with-ocaml4.07 ocaml-camomile))))
+     `(("ocaml-result" ,ocaml-result)
+       ("ocaml-camomile" ,ocaml-camomile)))
     (native-inputs
-     `(("ocaml-ppx-expect" ,(package-with-ocaml4.07 ocaml-ppx-expect))))
+     `(("ocaml-ppx-expect" ,ocaml-ppx-expect)))
     (properties
      `((upstream-name . "charInfo_width")))
     (home-page "https://bitbucket.org/zandoye/charinfo_width/")
@@ -3933,7 +3929,7 @@  (define-public ocaml4.07-zed
        #:dune ,ocaml4.07-dune))
     (propagated-inputs
      `(("ocaml-camomile" ,(package-with-ocaml4.07 ocaml-camomile))
-       ("ocaml-charinfo-width" ,ocaml4.07-charinfo-width)
+       ("ocaml-charinfo-width" ,(package-with-ocaml4.07 ocaml-charinfo-width))
        ("ocaml-react" ,(package-with-ocaml4.07 ocaml-react))))
     (home-page "https://github.com/diml/zed")
     (synopsis "Abstract engine for text editing in OCaml")