diff mbox series

[bug#50091,01/21] utils: Define 'target-riscv?' predicate.

Message ID e1f226e2111217131f4f4519466abfc7eda6d6f9.1629193993.git.efraim@flashner.co.il
State New
Headers show
Series Add riscv64 support | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue

Commit Message

Efraim Flashner Aug. 17, 2021, 10:18 a.m. UTC 
* guix/utils.scm (target-riscv?): New predicate.
---
 guix/utils.scm | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

M Aug. 17, 2021, 10:27 a.m. UTC | #1 
Efraim Flashner schreef op di 17-08-2021 om 13:18 [+0300]:
> * guix/utils.scm (target-riscv?): New predicate.
> ---
>  guix/utils.scm | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/guix/utils.scm b/guix/utils.scm
> index 32fcff72ea..134879feb1 100644
> --- a/guix/utils.scm
> +++ b/guix/utils.scm
> @@ -96,6 +96,7 @@
>              target-arm?
>              target-ppc32?
>              target-powerpc?
> +            target-riscv?
>              target-64bit?
>              cc-for-target
>              cxx-for-target
> @@ -699,6 +700,11 @@ architecture (x86_64)?"
>                                                   (%current-system))))
>    (string-prefix? "powerpc" target))
>  
> +(define* (target-riscv? #:optional (target (or (%current-target-system)
> +                                               (%current-system))))
> +  "Is the architecture of TARGET a 'riscv' architecture variant?"
> +  (string-prefix? "riscv" target))
> +
>  (define* (target-64bit? #:optional (system (or (%current-target-system)
>                                                 (%current-system))))
>    (any (cut string-prefix? <> system) '("x86_64" "aarch64" "mips64" "powerpc64")))

The next patch adds a ‘riscv64-linux-gnu’ target.  riscv64 seems 64-bit to me.
It would seem riscv64 needs to be added to target-64bit?.

Greetings,
Maxime.
Efraim Flashner Aug. 17, 2021, 10:28 a.m. UTC | #2 
On Tue, Aug 17, 2021 at 12:27:17PM +0200, Maxime Devos wrote:
> Efraim Flashner schreef op di 17-08-2021 om 13:18 [+0300]:
> > * guix/utils.scm (target-riscv?): New predicate.
> > ---
> >  guix/utils.scm | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/guix/utils.scm b/guix/utils.scm
> > index 32fcff72ea..134879feb1 100644
> > --- a/guix/utils.scm
> > +++ b/guix/utils.scm
> > @@ -96,6 +96,7 @@
> >              target-arm?
> >              target-ppc32?
> >              target-powerpc?
> > +            target-riscv?
> >              target-64bit?
> >              cc-for-target
> >              cxx-for-target
> > @@ -699,6 +700,11 @@ architecture (x86_64)?"
> >                                                   (%current-system))))
> >    (string-prefix? "powerpc" target))
> >  
> > +(define* (target-riscv? #:optional (target (or (%current-target-system)
> > +                                               (%current-system))))
> > +  "Is the architecture of TARGET a 'riscv' architecture variant?"
> > +  (string-prefix? "riscv" target))
> > +
> >  (define* (target-64bit? #:optional (system (or (%current-target-system)
> >                                                 (%current-system))))
> >    (any (cut string-prefix? <> system) '("x86_64" "aarch64" "mips64" "powerpc64")))
> 
> The next patch adds a ‘riscv64-linux-gnu’ target.  riscv64 seems 64-bit to me.
> It would seem riscv64 needs to be added to target-64bit?.
> 
> Greetings,
> Maxime.

The next patch also adds riscv64-linux to target-64bit?, since that's
pretty much "when it begins to exist".
M Aug. 17, 2021, 10:30 a.m. UTC | #3 
> > +(define* (target-riscv? #:optional (target (or (%current-target-system)
> > +                                               (%current-system))))
> > +  "Is the architecture of TARGET a 'riscv' architecture variant?"
> > +  (string-prefix? "riscv" target))
> > +
> >  (define* (target-64bit? #:optional (system (or (%current-target-system)
> >                                                 (%current-system))))
> >    (any (cut string-prefix? <> system) '("x86_64" "aarch64" "mips64" "powerpc64")))
> 
> The next patch adds a ‘riscv64-linux-gnu’ target.  riscv64 seems 64-bit to me.
> It would seem riscv64 needs to be added to target-64bit?.

Nevermind,
[bug#50091] [PATCH 02/21] gnu: bootstrap: Add support for riscv64-linux.
adds it to target-64bit?

> Greetings,
> Maxime.
diff mbox series

Patch

diff --git a/guix/utils.scm b/guix/utils.scm
index 32fcff72ea..134879feb1 100644
--- a/guix/utils.scm
+++ b/guix/utils.scm
@@ -96,6 +96,7 @@ 
             target-arm?
             target-ppc32?
             target-powerpc?
+            target-riscv?
             target-64bit?
             cc-for-target
             cxx-for-target
@@ -699,6 +700,11 @@  architecture (x86_64)?"
                                                  (%current-system))))
   (string-prefix? "powerpc" target))
 
+(define* (target-riscv? #:optional (target (or (%current-target-system)
+                                               (%current-system))))
+  "Is the architecture of TARGET a 'riscv' architecture variant?"
+  (string-prefix? "riscv" target))
+
 (define* (target-64bit? #:optional (system (or (%current-target-system)
                                                (%current-system))))
   (any (cut string-prefix? <> system) '("x86_64" "aarch64" "mips64" "powerpc64")))