From patchwork Mon Mar 4 22:28:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Famulari X-Patchwork-Id: 1333 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 25F6916D14; Mon, 4 Mar 2019 22:29:14 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 9150B16D13 for ; Mon, 4 Mar 2019 22:29:11 +0000 (GMT) Received: from localhost ([127.0.0.1]:34093 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h0w59-0001Ac-1V for patchwork@mira.cbaines.net; Mon, 04 Mar 2019 17:29:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48977) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h0w54-0001AH-1t for guix-patches@gnu.org; Mon, 04 Mar 2019 17:29:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h0w52-0005eH-3O for guix-patches@gnu.org; Mon, 04 Mar 2019 17:29:06 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46819) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h0w50-0005dL-9x for guix-patches@gnu.org; Mon, 04 Mar 2019 17:29:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h0w50-0004Cr-1Y for guix-patches@gnu.org; Mon, 04 Mar 2019 17:29:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#34752] [PATCH] WIP: Update Go to 1.12. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 04 Mar 2019 22:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 34752 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 34752@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.155173850816125 (code B ref -1); Mon, 04 Mar 2019 22:29:01 +0000 Received: (at submit) by debbugs.gnu.org; 4 Mar 2019 22:28:28 +0000 Received: from localhost ([127.0.0.1]:60363 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h0w4P-0004By-M2 for submit@debbugs.gnu.org; Mon, 04 Mar 2019 17:28:28 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34541) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h0w4N-0004Bm-Og for submit@debbugs.gnu.org; Mon, 04 Mar 2019 17:28:24 -0500 Received: from lists.gnu.org ([209.51.188.17]:53877) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h0w4I-000587-Gx for submit@debbugs.gnu.org; Mon, 04 Mar 2019 17:28:18 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48910) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h0w4H-00015P-8o for guix-patches@gnu.org; Mon, 04 Mar 2019 17:28:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h0w4B-00051J-I3 for guix-patches@gnu.org; Mon, 04 Mar 2019 17:28:16 -0500 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:48941) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h0w48-0004uP-3I for guix-patches@gnu.org; Mon, 04 Mar 2019 17:28:10 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id D518B3547; Mon, 4 Mar 2019 17:28:05 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 04 Mar 2019 17:28:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; s=mesmtp; bh=AEmWfI9DLOiI7tFSqwK1B6+ aC7ii6QmYwUUFWaqgc6M=; b=BT3kD0kGgZrHw8bd0VSsN4EORW2OW03tYLE5gxI DOqTfdJorKSy4iUnS6rX97gAZ5ThYZmhTtSUJzOkP4jF2GPZEjhGQx+z3LBnaZFo gERmDF2TTyjnl0W3jDRFOIJCL6cQfo6hfDl4OytW62ag10VsaKqH94mdUZd6HGgw fnS0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=AEmWfI9DLOiI7tFSq wK1B6+aC7ii6QmYwUUFWaqgc6M=; b=oBKntIMPvXKnjo6G8COTphO2XTnwa9RMV 6mM2L1hMT5E1qc6MXnT60nxBUZMGpS8wxXduQORlfRk8nXmMT18lx9rfSHcoan+g HnNNl5qgmbRvaTO8+Alx32Hfxgeb8R6ZHrMHit6+fqIGXJATJirX5xQN9UH6xhPD wm+1bFHeLzPWa/JfGS92da49bqOQr2a4I6YHj0EvGOZIy3QajxjTVawN/5Yve0L4 ErDLbTRWI7606vK35Q9kFWh7x0J3KrbeTos2M9QJE50soV7r+nGz4cgreXT8ZHzC WlCQmPGuwMSo1k1H+f08YlUvLTKyJi3Da6teBrzzpYgZ847y+iNFA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrfedugdduiedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgggfestdekredtre dttdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhi rdhnrghmvgeqnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkphepjeeirdduvd egrddvtddvrddufeejnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhl rghrihdrnhgrmhgvnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from jasmine.lan (c-76-124-202-137.hsd1.pa.comcast.net [76.124.202.137]) by mail.messagingengine.com (Postfix) with ESMTPA id ADF36100E5 for ; Mon, 4 Mar 2019 17:28:04 -0500 (EST) From: Leo Famulari Date: Mon, 4 Mar 2019 17:28:00 -0500 Message-Id: X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches This patch depends on the removal of Go 1.9 in bug #34280. Any ideas about these new test failures? Something fails to find some kernel headers for reasons that I don't understand. * gnu/packages/golang.scm (go-1.11): Replace with ... (go-1.12): ... new variable. [arguments]: Remove the Go 1.11.5 'tarbomb-workaround' phase. Move 'set-bootstrap-variables' into the 'build' phase. Disable some more tests in the 'prebuild' phase. Set $HOME because Go 1.12 actually tries to use it. (go): Update to go-1.12. * guix/build/go-build-system.scm (setup-environment): Set $HOME. --- gnu/packages/golang.scm | 39 ++++++++++++---------------------- guix/build/go-build-system.scm | 1 + 2 files changed, 14 insertions(+), 26 deletions(-) diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index da8ad3d7fe..ff21bcdba9 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -223,11 +223,11 @@ in the style of communicating sequential processes (@dfn{CSP}).") (supported-systems '("x86_64-linux" "i686-linux" "armhf-linux" "aarch64-linux")) (license license:bsd-3))) -(define-public go-1.11 +(define-public go-1.12 (package (inherit go-1.4) (name "go") - (version "1.11.5") + (version "1.12") (source (origin (method url-fetch) @@ -235,23 +235,11 @@ in the style of communicating sequential processes (@dfn{CSP}).") name version ".src.tar.gz")) (sha256 (base32 - "0gllmbjvp12iszwils8id78mvjxwviwf98lh2gdkb236n4mz07mw")))) + "1wl8kq21fbzmv4plnaza5acz8dhbaaq6smjzk3r6cf3l6qrkvi09")))) (arguments (substitute-keyword-arguments (package-arguments go-1.4) ((#:phases phases) `(modify-phases ,phases - ;; XXX Work around the Go 1.11.5 tarbomb. - ;; - (add-after 'unpack 'tarbomb-workaround - (lambda _ - (chdir "..") - (delete-file-recursively "gocache") - (delete-file-recursively "tmp") - #t)) - (replace 'chdir - (lambda _ - (chdir "go/src") - #t)) (replace 'prebuild (lambda* (#:key inputs outputs #:allow-other-keys) (let* ((gcclib (string-append (assoc-ref inputs "gcc:lib") "/lib")) @@ -276,8 +264,10 @@ in the style of communicating sequential processes (@dfn{CSP}).") ;; can not find crt1.o despite being present. "cmd/go/testdata/script/list_compiled_imports.txt" "cmd/go/testdata/script/mod_case_cgo.txt" - ;; https://github.com/golang/go/issues/24884 - "os/user/user_test.go")) + ;; XXX fails to find "asm/socket.h" + "cmd/go/testdata/script/list_find.txt" + ;; XXX fails to find "linux/errno.h" + "cmd/go/testdata/script/cgo_syso_issue29253.txt")) (substitute* "os/os_test.go" (("/usr/bin") (getcwd)) @@ -352,19 +342,16 @@ in the style of communicating sequential processes (@dfn{CSP}).") (substitute* (find-files "cmd" "\\.go") (("/lib(64)?/ld-linux.*\\.so\\.[0-9]") loader)) #t))) - (add-before 'build 'set-bootstrap-variables - (lambda* (#:key outputs inputs #:allow-other-keys) - ;; Tell the build system where to find the bootstrap Go. - (let ((go (assoc-ref inputs "go"))) - (setenv "GOROOT_BOOTSTRAP" go) - (setenv "GOGC" "400") - #t))) (replace 'build (lambda* (#:key inputs outputs #:allow-other-keys) ;; FIXME: Some of the .a files are not bit-reproducible. - (let* ((output (assoc-ref outputs "out"))) + (let ((go (assoc-ref inputs "go")) + (output (assoc-ref outputs "out"))) + (setenv "HOME" "/tmp") + (setenv "GOGC" "400") ; XXX necessary? (setenv "CC" (which "gcc")) (setenv "GOOS" "linux") + (setenv "GOROOT_BOOTSTRAP" go) (setenv "GOROOT" (dirname (getcwd))) (setenv "GOROOT_FINAL" output) (setenv "CGO_ENABLED" "1") @@ -415,7 +402,7 @@ in the style of communicating sequential processes (@dfn{CSP}).") ,@(package-native-inputs go-1.4))) (supported-systems %supported-systems))) -(define-public go go-1.11) +(define-public go go-1.12) (define-public go-github-com-alsm-ioprogress (let ((commit "063c3725f436e7fba0c8f588547bee21ffec7ac5") diff --git a/guix/build/go-build-system.scm b/guix/build/go-build-system.scm index 022d4fe16b..c4f55b06ee 100644 --- a/guix/build/go-build-system.scm +++ b/guix/build/go-build-system.scm @@ -172,6 +172,7 @@ respectively." (if (getenv "GOPATH") (setenv "GOPATH" (string-append (getcwd) ":" (getenv "GOPATH"))) (setenv "GOPATH" (getcwd))) + (setenv "HOME" "/tmp") ;; Where to install compiled executable files ('commands' in Go parlance'). (setenv "GOBIN" (string-append out "/bin")) #t))