From patchwork Thu Oct 10 08:56:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Prikler X-Patchwork-Id: 15680 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 2EA2A1756B; Thu, 10 Oct 2019 16:35:36 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=BAYES_00,MIME_BASE64_TEXT, T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 9A02817566 for ; Thu, 10 Oct 2019 16:35:35 +0100 (BST) Received: from localhost ([::1]:41194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIaTW-00085J-IL for patchwork@mira.cbaines.net; Thu, 10 Oct 2019 11:35:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51465) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIZPF-0005Vj-Uh for guix-patches@gnu.org; Thu, 10 Oct 2019 10:27:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIZPD-0007ex-Tm for guix-patches@gnu.org; Thu, 10 Oct 2019 10:27:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48111) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iIZPD-0007ep-Cy for guix-patches@gnu.org; Thu, 10 Oct 2019 10:27:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iIZPD-0001Xw-9h for guix-patches@gnu.org; Thu, 10 Oct 2019 10:27:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#37693] Seahorse build Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 10 Oct 2019 14:27:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 37693 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 37693@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15707176155914 (code B ref -1); Thu, 10 Oct 2019 14:27:03 +0000 Received: (at submit) by debbugs.gnu.org; 10 Oct 2019 14:26:55 +0000 Received: from localhost ([127.0.0.1]:56930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIZP3-0001XJ-T7 for submit@debbugs.gnu.org; Thu, 10 Oct 2019 10:26:54 -0400 Received: from lists.gnu.org ([209.51.188.17]:57560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIUHI-0000bk-UL for submit@debbugs.gnu.org; Thu, 10 Oct 2019 04:58:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33133) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIUHG-0003bt-Hp for guix-patches@gnu.org; Thu, 10 Oct 2019 04:58:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIUHE-0001os-6T for guix-patches@gnu.org; Thu, 10 Oct 2019 04:58:30 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:30050) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iIUHD-0001lb-Hu for guix-patches@gnu.org; Thu, 10 Oct 2019 04:58:28 -0400 Received: from nijino.local (194-118-175-91.hdsl.highway.telekom.at [194.118.175.91]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 46plNp5ptSz1LgFh for ; Thu, 10 Oct 2019 10:58:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 46plNp5ptSz1LgFh DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1570697898; bh=RvxhGpcO/37YodQZzOFv1DhPtargAe4xy233qf692Eo=; h=Subject:From:To:Date:From; b=ZsG6jVFobBNyZNOkX3U1JDxAP6HZNSQms7f/3vxj2Ko3Jca6sqnZfTOyD/4gvUHuM xy1Wgn5LjL6NdaVDp3SGzmcgapYu6MXJ9TPkuS0iGLe7xTNecFrgrbvVtAWrlSxNJ2 j4hMCI3VIqvxSUUvE0PTEY9GCt6F2fKJVmUzIIhw= Message-ID: From: Leo Prikler Date: Thu, 10 Oct 2019 10:56:44 +0200 User-Agent: Evolution 3.30.5 MIME-Version: 1.0 X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Mailman-Approved-At: Thu, 10 Oct 2019 10:26:51 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-Mailman-Approved-At: Thu, 10 Oct 2019 11:31:00 -0400 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches From e2b17f74841ae14ac96782539ec8bfc1c639ed34 Mon Sep 17 00:00:00 2001 From: Leo Prikler Date: Thu, 10 Oct 2019 10:16:47 +0200 Subject: [PATCH] gnu: seahorse: Fix build * /gnu/packages/gnome.scm: (seahorse): Use meson-build-system. Update inputs. Add patches to fix compile errors. * /gnu/packages/patches/seahorse-fix-libsecret-breakage.patch: New file. * /gnu/packages/patches/seahorse-fix-type-mismatches.patch: New file. --- gnu/packages/gnome.scm | 12 +- .../seahorse-fix-libsecret-breakage.patch | 29 ++++ .../seahorse-fix-type-mismatches.patch | 154 ++++++++++++++++++ 3 files changed, 192 insertions(+), 3 deletions(-) create mode 100644 gnu/packages/patches/seahorse-fix-libsecret-breakage.patch create mode 100644 gnu/packages/patches/seahorse-fix-type-mismatches.patch diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index 2a664e3db7..a34babebfe 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -2230,10 +2230,14 @@ engineering.") version ".tar.xz")) (sha256 (base32 - "1sbj1czlx1fakm72dwgbn0bwm12j838yaky4mkf6hf8j8afnxmzp")))) - (build-system glib-or-gtk-build-system) + "1sbj1czlx1fakm72dwgbn0bwm12j838yaky4mkf6hf8j8afnxmzp")) + (patches + (search-patches "seahorse-fix-libsecret-breakage.patch" + "seahorse-fix-type-mismatches.patch")))) + (build-system meson-build-system) (inputs - `(("gtk+" ,gtk+) + `(("avahi" ,avahi) + ("gtk+" ,gtk+) ("gcr" ,gcr) ("gnupg" ,gnupg) ("gpgme" ,gpgme) @@ -2244,8 +2248,10 @@ engineering.") (native-inputs `(("intltool" ,intltool) ("glib:bin" ,glib "bin") + ("gtk+:bin" ,gtk+ "bin") ("itstool" ,itstool) ("pkg-config" ,pkg-config) + ("vala" ,vala) ("xmllint" ,libxml2))) (home-page "https://launchpad.net/gnome-themes-standard") (synopsis "Manage encryption keys and passwords in the GNOME keyring") diff --git a/gnu/packages/patches/seahorse-fix-libsecret-breakage.patch b/gnu/packages/patches/seahorse-fix-libsecret-breakage.patch new file mode 100644 index 0000000000..d6396c227a --- /dev/null +++ b/gnu/packages/patches/seahorse-fix-libsecret-breakage.patch @@ -0,0 +1,29 @@ +From d9db29db567012b7c72e85e1be1fbf55fcc9b667 Mon Sep 17 00:00:00 2001 +From: Niels De Graef +Date: Sat, 11 May 2019 09:02:34 +0200 +Subject: [PATCH] gkr: Use 0 on empty flags + +A Flags-type variable without any flag set can be replaced with 0, so +this is a safe thing to do. It also prevents us from having to deal with +the accidental API break in libsecret (see +https://gitlab.gnome.org/GNOME/libsecret/merge_requests/19) +--- + gkr/gkr-keyring-add.vala | 3 +-- + 1 file changed, 1 insertion(+), 2 deletions(-) + +diff --git a/gkr/gkr-keyring-add.vala b/gkr/gkr-keyring-add.vala +index 4e92a520..f60c9a22 100644 +--- a/gkr/gkr-keyring-add.vala ++++ b/gkr/gkr-keyring-add.vala +@@ -43,8 +43,7 @@ public class Seahorse.Gkr.KeyringAdd : Gtk.Dialog { + + var cancellable = Dialog.begin_request(this); + var service = Backend.instance().service; +- Secret.Collection.create.begin(service, this.name_entry.text, null, +- Secret.CollectionCreateFlags.COLLECTION_CREATE_NONE, ++ Secret.Collection.create.begin(service, this.name_entry.text, null, 0, + cancellable, (obj, res) => { + /* Clear the operation without cancelling it since it is complete */ + Dialog.complete_request(this, false); +-- +2.22.0 diff --git a/gnu/packages/patches/seahorse-fix-type-mismatches.patch b/gnu/packages/patches/seahorse-fix-type-mismatches.patch new file mode 100644 index 0000000000..d259d8311d --- /dev/null +++ b/gnu/packages/patches/seahorse-fix-type-mismatches.patch @@ -0,0 +1,154 @@ +From 12178d7cc7fad52f61003b3221bd0a713ef80507 Mon Sep 17 00:00:00 2001 +From: Rico Tzschichholz +Date: Mon, 5 Nov 2018 09:59:27 +0100 +Subject: [PATCH] Fix type-argument mismatches related to GLib.List + +--- + common/deleter.vala | 2 +- + common/exporter.vala | 2 +- + gkr/gkr-item.vala | 2 +- + gkr/gkr-keyring.vala | 2 +- + pkcs11/certificate-der-exporter.vala | 4 ++-- + pkcs11/pkcs11-deleter.vala | 2 +- + pkcs11/pkcs11-token.vala | 4 ++-- + ssh/deleter.vala | 2 +- + ssh/exporter.vala | 2 +- + 9 files changed, 11 insertions(+), 11 deletions(-) + +diff --git a/common/deleter.vala b/common/deleter.vala +index 18dd0d4c..1c50cdaf 100644 +--- a/common/deleter.vala ++++ b/common/deleter.vala +@@ -24,7 +24,7 @@ namespace Seahorse { + public abstract class Deleter : GLib.Object { + public abstract Gtk.Dialog create_confirm(Gtk.Window? parent); + +- public abstract unowned GLib.List get_objects(); ++ public abstract unowned GLib.List get_objects(); + + public abstract bool add_object (GLib.Object obj); + +diff --git a/common/exporter.vala b/common/exporter.vala +index e686ff0d..edc4b4d3 100644 +--- a/common/exporter.vala ++++ b/common/exporter.vala +@@ -35,7 +35,7 @@ public interface Exporter : GLib.Object { + + public abstract Gtk.FileFilter file_filter { owned get; } + +- public abstract unowned GLib.List get_objects(); ++ public abstract unowned GLib.List get_objects(); + + public abstract bool add_object(GLib.Object obj); + +diff --git a/gkr/gkr-item.vala b/gkr/gkr-item.vala +index ec45a5c7..bdcf14d1 100644 +--- a/gkr/gkr-item.vala ++++ b/gkr/gkr-item.vala +@@ -513,7 +513,7 @@ class ItemDeleter : Deleter { + GLib.assert_not_reached(); + } + +- public override unowned GLib.List get_objects() { ++ public override unowned GLib.List get_objects() { + return this._items; + } + +diff --git a/gkr/gkr-keyring.vala b/gkr/gkr-keyring.vala +index e6ecaf76..096bb0ae 100644 +--- a/gkr/gkr-keyring.vala ++++ b/gkr/gkr-keyring.vala +@@ -248,7 +248,7 @@ class KeyringDeleter : Deleter { + GLib.assert_not_reached(); + } + +- public override unowned GLib.List get_objects() { ++ public override unowned GLib.List get_objects() { + return this._objects; + } + +diff --git a/pkcs11/certificate-der-exporter.vala b/pkcs11/certificate-der-exporter.vala +index e8789f52..57e6ec25 100644 +--- a/pkcs11/certificate-der-exporter.vala ++++ b/pkcs11/certificate-der-exporter.vala +@@ -23,7 +23,7 @@ namespace Seahorse { + + public class CertificateDerExporter : GLib.Object, Exporter { + private Gcr.Certificate _certificate; +- private GLib.List _objects; ++ private GLib.List _objects; + + public CertificateDerExporter(Gcr.Certificate certificate) + { +@@ -67,7 +67,7 @@ public class CertificateDerExporter : GLib.Object, Exporter { + } + } + +- public unowned GLib.List get_objects() { ++ public unowned GLib.List get_objects() { + return this._objects; + } + +diff --git a/pkcs11/pkcs11-deleter.vala b/pkcs11/pkcs11-deleter.vala +index 34efc0eb..475b30c4 100644 +--- a/pkcs11/pkcs11-deleter.vala ++++ b/pkcs11/pkcs11-deleter.vala +@@ -44,7 +44,7 @@ public class Deleter : Seahorse.Deleter { + GLib.assert_not_reached(); + } + +- public override unowned GLib.List get_objects() { ++ public override unowned GLib.List get_objects() { + return this.objects; + } + +diff --git a/pkcs11/pkcs11-token.vala b/pkcs11/pkcs11-token.vala +index 927118c2..c4a83c4e 100644 +--- a/pkcs11/pkcs11-token.vala ++++ b/pkcs11/pkcs11-token.vala +@@ -208,7 +208,7 @@ public class Token : GLib.Object, Gcr.Collection, Place, Lockable { + public void remove_object(Gck.Object object) { + GLib.List objects = null; + objects.append(object); +- remove_objects(objects); ++ remove_objects(objects.copy()); + } + + public bool has_mechanism(ulong mechanism) { +@@ -387,7 +387,7 @@ public class Token : GLib.Object, Gcr.Collection, Place, Lockable { + update_visibility(show, true); + } + +- private void remove_objects(GLib.List objects) { ++ private void remove_objects(GLib.List objects) { + var depaired = new GLib.List(); + var hide = new GLib.List(); + +diff --git a/ssh/deleter.vala b/ssh/deleter.vala +index 10788c25..e2e1221b 100644 +--- a/ssh/deleter.vala ++++ b/ssh/deleter.vala +@@ -64,7 +64,7 @@ public class Seahorse.Ssh.Deleter : Seahorse.Deleter { + return dialog; + } + +- public override unowned List get_objects () { ++ public override unowned GLib.List get_objects () { + return this.keys; + } + +diff --git a/ssh/exporter.vala b/ssh/exporter.vala +index f2d70b4f..e9499493 100644 +--- a/ssh/exporter.vala ++++ b/ssh/exporter.vala +@@ -97,7 +97,7 @@ public class Seahorse.Ssh.Exporter : GLib.Object, Seahorse.Exporter { + } + } + +- public unowned GLib.List get_objects() { ++ public unowned GLib.List get_objects() { + return this.objects; + } + +-- +2.22.0 -- 2.23.0