diff mbox series

[bug#76246,v5,6/6] gnu: g-golf: Redefine as a non-deprecated alias.

Message ID df547c9baa43532359da24016b711e5f37d13dd0.1739898237.git.pelzflorian@pelzflorian.de
State New
Headers
Series Add G-Golf's GTK-4 examples. |

Commit Message

pelzflorian (Florian Pelz) Feb. 18, 2025, 5:17 p.m. UTC 
  As proposed by Maxim Cournoyer
<https://lists.gnu.org/archive/html/guix-devel/2025-02/msg00296.html>.

* gnu/packages/guile-xyz.scm (g-golf: Redefine.

Change-Id: I850e05d46c026d6a27c8765ff3753c1bbe555235
---
 gnu/packages/guile-xyz.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Tobias Geerinckx-Rice Feb. 18, 2025, 5:33 p.m. UTC | #1 
Hi Florian,

Thanks.  If we do decide to do this (I don't think it's a good idea; just keep ‘guile-g-golf’), then add a comment like

;; Use ‘guile-g-golf’ above in package inputs and other code.  This alias exists as a compromise,
;; see <https://lists.gnu.org/archive/html/guix-devel/2025-02/msg00296.html>.

so later readers can know why we have two identical packages with different package names.

Kind regards,

T G-R

Sent on the go.  Excuse or enjoy my brevity.
Maxim Cournoyer Feb. 23, 2025, 2:47 a.m. UTC | #2 
Hi Tobias, Florian,

Tobias Geerinckx-Rice <me@tobias.gr> writes:

> Hi Florian,
>
> Thanks.  If we do decide to do this (I don't think it's a good idea;
> just keep ‘guile-g-golf’), then add a comment like
>
> ;; Use ‘guile-g-golf’ above in package inputs and other code.  This alias exists as a compromise,
> ;; see <https://lists.gnu.org/archive/html/guix-devel/2025-02/msg00296.html>.

My 2 cents: prefixing a package with '$lang-' is a (somewhat loose, or
at least sparsely documented *guideline*).  I think given David is very
sensitive about having their package exposed as 'g-golf' on the command
line of Guix, it is not a big harm to do what is proposed by Florian
above (and I second adding the comment you suggested).  We'd loose more
to not have 'g-golf' packaged anymore in Guix, which is the only library
to do GTK with Guile, IIRC.

Guix itself might use it at some point, for a GUI updater say that could
make keeping Guix up-to-date easier on desktop systems.
pelzflorian (Florian Pelz) Feb. 24, 2025, 11:51 p.m. UTC | #3 
Pushed as db172d1f64a514babc9a2e4fd11fe8fe248e306e.

* Added Tobias’ comment on the alias g-golf compromise.
  I was at first inclined to drop the whole alias patch,
  since David Pirotte did not respond on it, but the alias
  is in Guix now.

* Changed synopses and descriptions to be closer to what David Pirotte
  wrote.  This means the synopsis no longer says “in Guile”, but
  surprisingly, it does not negatively affect its search score with
  “guix search guile gtk”.  However, I wrote "G-Golf GTK 4 examples"
  instead of David’s "G-Golf Gtk-4 Examples".

* In g-golf-adw-1-examples, I wrapped GDK_PIXBUF_MODULE_FILE rather
  than GUIX_GDK_PIXBUF_MODULE_FILES, so it builds on the master
  branch.  The main demo adwaita-1-demo does not work on master yet,
  libadwaita is too old.  I plan to rewrite the wrapping when
  GUIX_GDK_PIXBUF_MODULE_FILES is on master or rather 宋文武’s GCD [1]
  is accepted.

I would much welcome if G-Golf, AFAIK the only currently maintained
and comprehensive library to access GTK and perhaps better Libadwaita
in Guile, were put to use in Guix itself, as Maxim writes, but I will
not be of help.

Regards,
Florian

[1] https://git.savannah.gnu.org/cgit/guix/guix-consensus-documents.git/plain/004-set-search-paths-without-program-wrappers.md?h=wip-set-search-paths-without-program-wrappers
https://lists.gnu.org/archive/html/guix-devel/2025-02/msg00007.html
Maxim Cournoyer Feb. 25, 2025, 2:12 a.m. UTC | #4 
Hi Florian,

"pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> writes:

> Pushed as db172d1f64a514babc9a2e4fd11fe8fe248e306e.
>
> * Added Tobias’ comment on the alias g-golf compromise.
>   I was at first inclined to drop the whole alias patch,
>   since David Pirotte did not respond on it, but the alias
>   is in Guix now.
>
> * Changed synopses and descriptions to be closer to what David Pirotte
>   wrote.  This means the synopsis no longer says “in Guile”, but
>   surprisingly, it does not negatively affect its search score with
>   “guix search guile gtk”.  However, I wrote "G-Golf GTK 4 examples"
>   instead of David’s "G-Golf Gtk-4 Examples".
>
> * In g-golf-adw-1-examples, I wrapped GDK_PIXBUF_MODULE_FILE rather
>   than GUIX_GDK_PIXBUF_MODULE_FILES, so it builds on the master
>   branch.  The main demo adwaita-1-demo does not work on master yet,
>   libadwaita is too old.  I plan to rewrite the wrapping when
>   GUIX_GDK_PIXBUF_MODULE_FILES is on master or rather 宋文武’s GCD [1]
>   is accepted.
>
> I would much welcome if G-Golf, AFAIK the only currently maintained
> and comprehensive library to access GTK and perhaps better Libadwaita
> in Guile, were put to use in Guix itself, as Maxim writes, but I will
> not be of help.

Thanks for your efforts in packaging this library, and for David for
having authored it in the first place!
pelzflorian (Florian Pelz) Feb. 25, 2025, 10:25 a.m. UTC | #5 
Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
> Thanks for your efforts in packaging this library, and for David for
> having authored it in the first place!

:)

Note that I packaged examples but never packaged the guile-g-golf
library, which was done by other fans of G-Golf, namely

commit dfe277a5ce60d487fe44840506206fea8507bc69
Author: Vitaliy Shatrov <D0dyBo0D0dyBo0@protonmail.com>
Date:   Wed Apr 15 07:15:59 2020 +0000
commit 85fcceeea146b2e2e84a063f042893a0c39e9e5f
Author: Mike Rosset <mike.rosset@gmail.com>
Date:   Mon Jul 20 12:06:12 2020 -0700
commit 35c96e65a9ea638d5c544257e1917e320c2beca1
Author: Zhu Zihao <all_but_last@163.com>
Date:   Thu Feb 3 22:27:40 2022 +0800

Regards,
Florian
diff mbox series

Patch

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index bac21afc4f..0fc6123f1d 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -2613,7 +2613,9 @@  (define-public guile-g-golf
     (license license:lgpl3+)))
 
 (define-public g-golf
-  (deprecated-package "g-golf" guile-g-golf))
+  (package
+    (inherit guile-g-golf)
+    (name "g-golf")))
 
 (define-public guile2.2-g-golf
   (package