From patchwork Sat Jul 29 11:50:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Attila Lendvai X-Patchwork-Id: 52351 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 18E1627BBEA; Sat, 29 Jul 2023 13:44:45 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, SPF_HELO_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 38B1727BBE2 for ; Sat, 29 Jul 2023 13:44:44 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qPj8o-00048r-SJ; Sat, 29 Jul 2023 08:33:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPiWJ-0003Xp-Be for guix-patches@gnu.org; Sat, 29 Jul 2023 07:54:03 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qPiWJ-0006So-3x for guix-patches@gnu.org; Sat, 29 Jul 2023 07:54:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qPiWI-0002bx-Nt for guix-patches@gnu.org; Sat, 29 Jul 2023 07:54:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64929] [PATCH] gnu: gcc-toolchain: Create a 'bin/cc' symlink. Resent-From: Attila Lendvai Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 29 Jul 2023 11:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 64929 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 64929@debbugs.gnu.org Cc: Attila Lendvai X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16906315999980 (code B ref -1); Sat, 29 Jul 2023 11:54:02 +0000 Received: (at submit) by debbugs.gnu.org; 29 Jul 2023 11:53:19 +0000 Received: from localhost ([127.0.0.1]:46531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPiVb-0002au-F4 for submit@debbugs.gnu.org; Sat, 29 Jul 2023 07:53:19 -0400 Received: from lists.gnu.org ([2001:470:142::17]:37894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPiVZ-0002af-TU for submit@debbugs.gnu.org; Sat, 29 Jul 2023 07:53:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPiVU-00034f-Gx for guix-patches@gnu.org; Sat, 29 Jul 2023 07:53:12 -0400 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qPiVT-0006L2-53 for guix-patches@gnu.org; Sat, 29 Jul 2023 07:53:12 -0400 Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-992e22c09edso406636766b.2 for ; Sat, 29 Jul 2023 04:53:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690631589; x=1691236389; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+eyUiKviALOsbG8l7g7JjVQuUL/xxFYma9svfokqgNo=; b=WbMGgl8FAIJcqCBowh1grz3m1gWoy4fSIwwYzXRdSFKHrK1QJT2knpJmMPPpnvfu4d KrpaJy5HDOkFBea81CIkhh/ai4jQ0yswNtPuTHtsnYnEQNiVvPsEOXrGGVMcXyUd71lU BHyNTRddVc4mDMxeYJtHeUzp9FJsqCgRSgheclYaiqoe+TTnpnR7aXsj/liCZWWNxI6f +pzgQMh4qb60rsjJbsArriiqIjS720xHji0Oms2EZvEzfdOdhk/UWFLOQwsBrzl1Vuey czqK83UIakxM5N7iBmezb76uqFwPnFRvEve4m7k/L0J3LXBVec3S0kVB/kozvA/y4CVO yskg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690631589; x=1691236389; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+eyUiKviALOsbG8l7g7JjVQuUL/xxFYma9svfokqgNo=; b=Spndz7xnNAKjb/EmF22+Zd1hBpyK02XvH4VVfLM7Em1BW7GA2/BXpuTyLljanieBSA 6lAAjdbKC/xUaEBw+FffHPwub6z3l6G5ESZuH1o/K+ofuLIDjZc0ouSXEUOAHp8o9KHV XtIG0sOJXJbhwPy8Yp4j0BIlu3w2dFFng7sm9spd6XUj197oJgJvkB/+aAnvdNLGzHLF 3n3daflWqxQGKWQkIg4Uw9mpTZpUle/wp98/qGdSzbMAtnu8ym/f8MiCgnvUcrJUvzbq gkHGNPTKGiBS9smyARU6a1YlhZSHy1XXLSg4LubEhu//BXrNSBjjsmS9zrGBS2mHH9BW pD/Q== X-Gm-Message-State: ABy/qLb50ZnCLYQDfIDSle/Wa0d1U4ul8Uc+mf25oMMZGDecRQB7hUtP uuna+fKOUau/0OAKviw1daznDPd003c= X-Google-Smtp-Source: APBJJlEeboGgGQhOueSsbXW41wZ5GmJ6sPUJI+a3Fo7RN57BRxr3qoJexelpjuuQL0JJKw44Cuhk7w== X-Received: by 2002:a17:906:8a70:b0:993:f497:adbe with SMTP id hy16-20020a1709068a7000b00993f497adbemr1864955ejc.19.1690631588538; Sat, 29 Jul 2023 04:53:08 -0700 (PDT) Received: from lelap.lan (catv-80-98-247-145.catv.fixed.vodafone.hu. [80.98.247.145]) by smtp.gmail.com with ESMTPSA id s17-20020a1709064d9100b0098e4aef0791sm3217793eju.66.2023.07.29.04.53.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jul 2023 04:53:07 -0700 (PDT) From: Attila Lendvai X-Google-Original-From: Attila Lendvai Date: Sat, 29 Jul 2023 13:50:29 +0200 Message-Id: X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::62c; envelope-from=attila.lendvai@gmail.com; helo=mail-ej1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Mailman-Approved-At: Sat, 29 Jul 2023 08:33:48 -0400 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches There are many projects that don't have a configure script that finds gcc. Also makes it more symmetric with the clang-toolchain, that also does this. * gnu/packages/commencement.scm (make-gcc-toolchain): Create the symlink. --- i'm not sure what was the conclusion about this. clang-toolchain does create a cc symlink, so i have mirrored what clang-toolchain does into gcc-toolchain. i thought i'll send this patch lying in my kludges branch, and offer it either for rejection or inclusion, as you see fit. gnu/packages/commencement.scm | 6 ++++++ 1 file changed, 6 insertions(+) base-commit: e43cbeafd1b632f39b08b3644af5230d5350a656 prerequisite-patch-id: 6793c8ad24215c5f14ce71a4741fff5f6ccd7eeb prerequisite-patch-id: 3a8dd737d11f37987641af9bc7f512a0bb1a1591 diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm index fe6f025257..fceda97ad5 100644 --- a/gnu/packages/commencement.scm +++ b/gnu/packages/commencement.scm @@ -3554,6 +3554,12 @@ (define* (make-gcc-toolchain gcc ((_ . directory) directory)) %build-inputs)) + ;; Create 'cc' so that one can use it as a drop-in + ;; replacement for the default tool chain and have + ;; configure scripts find the compiler. Note that + ;; 'c++' is already present, no need to symlink it. + (symlink "gcc" (string-append out "/bin/cc")) + (union-build (assoc-ref %outputs "debug") (list (assoc-ref %build-inputs "libc-debug")))