diff mbox series

[bug#74305,1/2] gnu: emacs-piem: Build Info manual

Message ID da7e05fdc2d64bc5042f05737c5713746ff61320.1731291038.git.liam@hpfr.net
State New
Headers
Series Improve piem package |

Commit Message

Liam Hupfer Nov. 11, 2024, 2:52 a.m. UTC 
  * gnu/packages/emacs-xyz (emacs-piem): Build Info manual

Change-Id: Id3be957586e430f74330e35c6e39e08437668d0e
---
 gnu/packages/emacs-xyz.scm | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

Comments

Noé Lopez Nov. 13, 2024, 11:38 p.m. UTC | #1 
Hi,

Thanks for your patch,

Everything is great, you just forgot a dot at the end of your commit
messages and description :P You can check the git log for examples.

Can you send an updated patch?

Have a good day,
Noé Lopez


> * gnu/packages/emacs-xyz (emacs-piem): Build Info manual
> 
> Change-Id: Id3be957586e430f74330e35c6e39e08437668d0e
> ---
>  gnu/packages/emacs-xyz.scm | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 88e1ab89a9..7772a80192 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -9785,7 +9785,13 @@ (define-public emacs-piem
>                   (lambda* (#:key inputs #:allow-other-keys)
>                     (emacs-substitute-variables "piem-b4.el"
>                       ("piem-b4-b4-executable"
> -                      (search-input-file inputs "/bin/b4"))))))))
> +                      (search-input-file inputs "/bin/b4")))))
> +               (add-after 'install 'makeinfo
> +                 (lambda _
> +                   (invoke "makeinfo" "Documentation/piem.texi")
> +                   (install-file "piem.info"
> +                                 (string-append #$output "/share/info")))))))
> +    (native-inputs (list texinfo))
>      (inputs
>       (list b4
>             emacs-debbugs
> -- 
> 2.46.0
diff mbox series

Patch

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 88e1ab89a9..7772a80192 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -9785,7 +9785,13 @@  (define-public emacs-piem
                  (lambda* (#:key inputs #:allow-other-keys)
                    (emacs-substitute-variables "piem-b4.el"
                      ("piem-b4-b4-executable"
-                      (search-input-file inputs "/bin/b4"))))))))
+                      (search-input-file inputs "/bin/b4")))))
+               (add-after 'install 'makeinfo
+                 (lambda _
+                   (invoke "makeinfo" "Documentation/piem.texi")
+                   (install-file "piem.info"
+                                 (string-append #$output "/share/info")))))))
+    (native-inputs (list texinfo))
     (inputs
      (list b4
            emacs-debbugs