| Message ID | d95e34dc-cc97-1033-de64-b31b9071115e@disroot.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [bug#41111] Claws-Mail | expand |
| Context | Check | Description |
|---|---|---|
| cbaines/applying patch | fail | View Laminar job |
Raghav, Raghav Gururajan 写道： > Based on your feedback, I have split the changes. Please find > the > attached patches. I haven't been following this thread, but have updated claws-mail to .7 on master in the meantime. Your 0003-gnu-claws-mail-Update-to-3.17.7.patch does unrelated things and deserves a different commit message. > [source]<origin>[sha256]: Modify base32. This isn't needed; <version> and <origin> changes are implicitly covered by ‘Update to x.y’ to reduce noise in the common case. Kind regards, T G-R
@Danny Please find the revised patches. @Tobias I have fixed the commit message. Regards, RG.
Hi RG, pushed to master as commits b168f2ba53b938e1b322c79e5bfa47fcc506b803 and 7269a591361138ac6fc122d465e45e2b8c4944be. Thanks!
Hi Danny! > pushed to master as commits b168f2ba53b938e1b322c79e5bfa47fcc506b803 and > 7269a591361138ac6fc122d465e45e2b8c4944be. Thanks! The patch-set had 6 patches, but only 2 were pushed? Regards, RG.
> The patch-set had 6 patches, but only 2 were pushed?
Whoops, yes. I only saw and pushed the first two.
Reopened the bug report.
Hi Danny! > Whoops, yes. I only saw and pushed the first two. > > Reopened the bug report. Cool! Regards, RG.
This patchset (mostly patch 4) increases claws-mail's closure size from 563 MiB to 1128 MiB. That's a definition of "lightweight" (see revised synopsis and description) I was not aware of. I'm not necessarily opposed--but for example does it really need webkitgtk ? What does it do with it ? (There were really bad security problems in Microsoft Outlook because they were using a more-capable-than-necessary web browser to render HTML mail, back in the day?)
Hi Danny! > This patchset (mostly patch 4) increases claws-mail's closure size from 563 MiB to 1128 MiB. > > That's a definition of "lightweight" (see revised synopsis and description) I was not aware of. I know :/ > I'm not necessarily opposed--but for example does it really need webkitgtk ? > What does it do with it ? Yeah, it enables a feature called "Fancy" (HTML stuff). > (There were really bad security problems in Microsoft Outlook because they > were using a more-capable-than-necessary web browser to render HTML mail, > back in the day?) The fancy is disabled my default. So, user should enable it only if required. Regards, RG.
Hi Danny! >> This patchset (mostly patch 4) increases claws-mail's closure size from 563 MiB to 1128 MiB. >> >> That's a definition of "lightweight" (see revised synopsis and description) I was not aware of. > > I know :/ > >> I'm not necessarily opposed--but for example does it really need webkitgtk ? >> What does it do with it ? > > Yeah, it enables a feature called "Fancy" (HTML stuff). > >> (There were really bad security problems in Microsoft Outlook because they >> were using a more-capable-than-necessary web browser to render HTML mail, >> back in the day?) > > The fancy is disabled my default. So, user should enable it only if required. Hmm. Would you be able to comment-out the webkitgtk input while pushing? In future, if someone really needs it, then we can include it. Regards, RG.
Hi RG,
On Thu, 15 Oct 2020 22:52:13 +0000
"Raghav Gururajan" <raghavgururajan@disroot.org> wrote:
> Hmm. Would you be able to comment-out the webkitgtk input while pushing? In future, if someone really needs it, then we can include it.
With your patchset I get:
$ guix gc --references /gnu/store/1lz5ax9j3wysl83qfzyh2c8212mh2dch-claws-mail-3.17.7 |grep -i webkit
$
So it's not using webkitgtk in the first place.
Still huge...
Hi Danny! > With your patchset I get: > > $ guix gc --references /gnu/store/1lz5ax9j3wysl83qfzyh2c8212mh2dch-claws-mail-3.17.7 |grep -i > webkit > $ > > So it's not using webkitgtk in the first place. > > Still huge... Thanks for catching that. The claws-mail wants WebKit-1.0 (older version of webkitgtk). So I removed it. Please find the revised patch attached. Regards, RG.
How come gobject-introspection is in the regular inputs, not in native-inputs?
Hi Danny!
> How come gobject-introspection is in the regular inputs, not in native-inputs?
Oops! Performed lint on wrong branch. Fixed now.
Regards,
RG.
From 6c74dfc8d76d9ae447698c98eef4dbed7cee290e Mon Sep 17 00:00:00 2001 From: Raghav Gururajan <raghavgururajan@disroot.org> Date: Wed, 30 Sep 2020 06:10:56 -0400 Subject: [PATCH 5/5] gnu: claws-mail: Update synopsis and description. * gnu/packages/mail.scm (claws-mail) [synopsis]: Modify. [description]: Modify. --- gnu/packages/mail.scm | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm index 4a185235b1..ca0ec9d8de 100644 --- a/gnu/packages/mail.scm +++ b/gnu/packages/mail.scm @@ -1398,12 +1398,10 @@ compresses it.") ("mime-info" ,shared-mime-info) ("startup-notification" ,startup-notification) ("webkitgtk" ,webkitgtk))) - (synopsis "GTK-based Email client") - (description "Claws-Mail is an email client (and news reader) based on GTK+. -The appearance and interface are designed to be familiar to new users coming from -other popular email clients, as well as experienced users. Almost all commands -are accessible with the keyboard. Plus, Claws-Mail is extensible via addons -which can add many functionalities to the base client.") + (synopsis "A GTK+ lightweight and fast e-mail client") + (description "Claws-Mail is a lightweight and highly configurable email +client and news reader based on the GTK+ GUI toolkit. It runs on the X Window +System.") (home-page "https://www.claws-mail.org/") (license license:gpl3+))) -- 2.28.0