diff mbox series

[bug#72206] lint: check-inputs-should-not-be-an-input-at-all: Add more packages.

Message ID d94f5587e54d21e681f72bafaa3f9ec3552bc725.1721473565.git.monego@posteo.net
State New
Headers
Series [bug#72206] lint: check-inputs-should-not-be-an-input-at-all: Add more packages. |

Commit Message

Vinicius Monego July 20, 2024, 11:09 a.m. UTC 
* guix.lint.scm (check-inputs-should-not-be-an-input-at-all): Add
python-black, python-coverage, python-flake8, python-mypy, python-pycodestyle,
python-pyflakes, python-pylint, python-pytest-cov, python-yapf.

Change-Id: I4e7071f21b84313a117c4487d5977adbb91efe92
---
There are several flake8 extensions too which could be added.

 guix/lint.scm | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)


base-commit: 9df5289c6687cd5688c275d16417389fbab6d384

Comments

Ludovic Courtès Sept. 5, 2024, 6:43 a.m. UTC | #1 
Hi Vinicius,

Vinicius Monego <monego@posteo.net> skribis:

> * guix.lint.scm (check-inputs-should-not-be-an-input-at-all): Add
> python-black, python-coverage, python-flake8, python-mypy, python-pycodestyle,
> python-pyflakes, python-pylint, python-pytest-cov, python-yapf.
>
> Change-Id: I4e7071f21b84313a117c4487d5977adbb91efe92
> ---
> There are several flake8 extensions too which could be added.

I’m not a Python person but I this looks reasonable to me.  I think you
can go ahead and push.

Ludo’.
Ludovic Courtès Sept. 5, 2024, 6:43 a.m. UTC | #2 
Hi Vinicius,

Vinicius Monego <monego@posteo.net> skribis:

> * guix.lint.scm (check-inputs-should-not-be-an-input-at-all): Add
> python-black, python-coverage, python-flake8, python-mypy, python-pycodestyle,
> python-pyflakes, python-pylint, python-pytest-cov, python-yapf.
>
> Change-Id: I4e7071f21b84313a117c4487d5977adbb91efe92
> ---
> There are several flake8 extensions too which could be added.

I’m not a Python person but this looks reasonable to me.  I think you
can go ahead and push.

Ludo’.
diff mbox series

Patch

diff --git a/guix/lint.scm b/guix/lint.scm
index 7612832a5a..49e9b73676 100644
--- a/guix/lint.scm
+++ b/guix/lint.scm
@@ -586,9 +586,18 @@  (define (check-inputs-should-be-native package)
 (define (check-inputs-should-not-be-an-input-at-all package)
   ;; Emit a warning if some inputs of PACKAGE are likely to should not be
   ;; an input at all.
-  (let ((input-names '("python-setuptools"
+  (let ((input-names '("python-black"
+                       "python-coverage"
+                       "python-flake8"
+                       "python-mypy"
                        "python-pip"
-                       "python-pre-commit")))
+                       "python-pre-commit"
+                       "python-pycodestyle"
+                       "python-pyflakes"
+                       "python-pylint"
+                       "python-pytest-cov"
+                       "python-setuptools"
+                       "python-yapf")))
     (map (lambda (input)
            (make-warning
             package