diff mbox series

[bug#59437] gnu: Add mympd.

Message ID d919bf1bc6a818f1ecb09ee3cf150307beedb1b7.1668990380.git.mirai@makinata.eu
State New
Headers show
Series [bug#59437] gnu: Add mympd. | expand

Commit Message

mirai Nov. 21, 2022, 12:26 a.m. UTC 
From: Bruno Victal <mirai@makinata.eu>

* gnu/packages/mpd.scm (mympd): New variable.
---
 gnu/packages/mpd.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)


base-commit: 99ba4ddb03b396f56764a25317f40d4501380704

Comments

\( Nov. 21, 2022, 5:09 p.m. UTC | #1 
Heya,

On Mon Nov 21, 2022 at 12:26 AM GMT,  wrote:
> * gnu/packages/mpd.scm (mympd): New variable.

> --- a/gnu/packages/mpd.scm
> +++ b/gnu/packages/mpd.scm

> @@ -561,3 +565,28 @@ (define-public mpdevil

> +    (arguments
> +     '(#:tests? #f))

Please explain why tests are disabled in a comment. Also, please use

  (list ...)

rather than

  '(...)

for arguments.

> +    (description
> +     "myMPD is a standalone and mobile friendly web mpd client with
> +a tiny footprint and advanced features.")

This is a bit markety, I think. How about this?

  (description
   "MyMPD is a mobile-friendly web client for the MPD music
player daemon.")

    -- (
diff mbox series

Patch

diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm
index 4e9cb0cb37..881065d103 100644
--- a/gnu/packages/mpd.scm
+++ b/gnu/packages/mpd.scm
@@ -55,6 +55,7 @@  (define-module (gnu packages mpd)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages icu4c)
   #:use-module (gnu packages libusb)
+  #:use-module (gnu packages lua)
   #:use-module (gnu packages readline)
   #:use-module (gnu packages check)
   #:use-module (gnu packages compression)
@@ -66,6 +67,7 @@  (define-module (gnu packages mpd)
   #:use-module (gnu packages music)
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages pcre)
+  #:use-module (gnu packages perl)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages pretty-print)
   #:use-module (gnu packages python)
@@ -74,7 +76,9 @@  (define-module (gnu packages mpd)
   #:use-module (gnu packages qt)
   #:use-module (gnu packages sphinx)
   #:use-module (gnu packages sqlite)
+  #:use-module (gnu packages tls)
   #:use-module (gnu packages video)
+  #:use-module (gnu packages web)
   #:use-module (gnu packages xiph))
 
 (define-public libmpdclient
@@ -561,3 +565,28 @@  (define-public mpdevil
 Instead of maintaining a client side database of your music library,
 mpdevil loads all tags and covers on demand.")
     (license license:gpl3+)))
+
+(define-public mympd
+  (package
+    (name "mympd")
+    (version "10.1.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/jcorporation/myMPD")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0cw21sz8xyfz7p8yi03mhriqadrm11x1kqw0pw61v1dkbw13q79c"))))
+    (build-system cmake-build-system)
+    (arguments
+     '(#:tests? #f))
+    (native-inputs (list jq perl))
+    (inputs (list flac libid3tag lua openssl pcre2))
+    (home-page "https://jcorporation.github.io/")
+    (synopsis "Web-based MPD client")
+    (description
+     "myMPD is a standalone and mobile friendly web mpd client with
+a tiny footprint and advanced features.")
+    (license license:gpl3+)))