diff mbox series

[bug#33738] Add emacs-buttercup

Message ID cu7va3wegmi.fsf@systemreboot.net
State Accepted
Headers show
Series [bug#33738] Add emacs-buttercup | expand

Checks

Context Check Description
cbaines/applying patch success Successfully applied

Commit Message

Arun Isaac Dec. 14, 2018, 7:01 a.m. UTC 
This patchset adds emacs-buttercup, and enables tests for emacs-circe
and emacs-tracking, two packages that require emacs-buttercup to run
tests.

Comments

Ludovic Courtès Dec. 16, 2018, 3:09 p.m. UTC | #1 
Hello Arun,

Arun Isaac <arunisaac@systemreboot.net> skribis:

> This patchset adds emacs-buttercup, and enables tests for emacs-circe
> and emacs-tracking, two packages that require emacs-buttercup to run
> tests.

All 3 patches LGTM, thank you!

Ludo’.
Arun Isaac Dec. 16, 2018, 6:28 p.m. UTC | #2 
> All 3 patches LGTM, thank you!

Pushed to master, thanks for the review!
diff mbox series

Patch

From e17724b3e59a7784aac391e5be7e450ffcf2a67d Mon Sep 17 00:00:00 2001
From: Arun Isaac <arunisaac@systemreboot.net>
Date: Wed, 12 Dec 2018 01:00:26 +0530
Subject: [PATCH 3/3] gnu: emacs-tracking: Enable tests.

* gnu/packages/emacs.scm (emacs-tracking)[arguments]: Append to arguments
inherited from emacs-circe, instead of overwriting them.
---
 gnu/packages/emacs.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 0575338ee..df56612c3 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -7868,7 +7868,7 @@  want to use it.")
      ;; "tracking.el" is a library extracted from Circe package.  It requires
      ;; "shorten.el".
      `(#:include '("^shorten.el$" "^tracking.el$")
-       #:tests? #f))                    ;tests require buttercup
+       ,@(package-arguments emacs-circe)))
     (home-page "https://github.com/jorgenschaefer/circe/wiki/Tracking")
     (synopsis "Buffer tracking library")
     (description "@code{tracking.el} provides a way for different modes to
-- 
2.19.2