From patchwork Tue May 2 20:18:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Felix Gruber X-Patchwork-Id: 49752 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 1702D27BBE2; Tue, 2 May 2023 21:19:18 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, URIBL_BLOCKED,WEIRD_PORT autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 563F627BBE9 for ; Tue, 2 May 2023 21:19:15 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptwSo-0002pw-Ia; Tue, 02 May 2023 16:19:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptwSk-0002hq-HN for guix-patches@gnu.org; Tue, 02 May 2023 16:19:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptwSk-0002Cy-9H for guix-patches@gnu.org; Tue, 02 May 2023 16:19:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ptwSk-00084C-5S for guix-patches@gnu.org; Tue, 02 May 2023 16:19:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62842] [PATCH 00/11] gnu: maths: dune-*: Update to version 2.9.0 Resent-From: Felix Gruber Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 02 May 2023 20:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62842 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?utf-8?q?Court=C3=A8s?= Cc: 62842@debbugs.gnu.org Received: via spool by 62842-submit@debbugs.gnu.org id=B62842.168305874131002 (code B ref 62842); Tue, 02 May 2023 20:19:02 +0000 Received: (at 62842) by debbugs.gnu.org; 2 May 2023 20:19:01 +0000 Received: from localhost ([127.0.0.1]:45111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptwSi-00083v-AQ for submit@debbugs.gnu.org; Tue, 02 May 2023 16:19:01 -0400 Received: from mout01.posteo.de ([185.67.36.65]:37411) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptwSe-00083c-EF for 62842@debbugs.gnu.org; Tue, 02 May 2023 16:18:59 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 753A524037E for <62842@debbugs.gnu.org>; Tue, 2 May 2023 22:18:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1683058730; bh=f/90W1VwduHLF1KZXBNFatIQfSv0v6XLvWYh/+GPY6M=; h=Date:Subject:To:Cc:From:From; b=pLlUFTFtxiaHYKwJOr93DOzy/LogWI5Lo4NAlhEuhufFKv+4+Gy/pLUNoJcTUHeTh lS9cNs0CjDE/yjsNLZSx1i4txEdAlGx3bsbdIDNLXnfMQ6y00n0eq62tKieHjdUyeu 0hd7vn5Kjit4G0BTGs34VDuOwdgc4LGRVoE2+/+QK1gcukWantRBShe43qugfAgMWy BsAMI9iiK1v2wwSSdBNGIqhtesR2qQIQNEr4Z6JFNFezTaKLKksN+V+CmSlJ8qjpOp t8FwzmOJgbhxNsFDswYlZt2QYPKy7w2vyaoF5ld7hYyPAIhj+s2k1UCeDBs9/95x06 3Q+ndf0mlB91Q== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Q9ry15QjCz9rxT; Tue, 2 May 2023 22:18:49 +0200 (CEST) Message-ID: Date: Tue, 2 May 2023 20:18:13 +0000 MIME-Version: 1.0 References: <20230414192518.41188-1-felgru@posteo.net> <877ctq99ay.fsf@gnu.org> Content-Language: en-US From: Felix Gruber In-Reply-To: <877ctq99ay.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Hi Ludo’, On 5/2/23 15:01, Ludovic Courtès wrote: > Felix Gruber skribis: > >> This patchset updates all packages belonging to the Dune finite element >> library to the latest release 2.9.0. > > There’s one test failure on aarch64-linux: > > --8<---------------cut here---------------start------------->8--- > 99/106 Test #99: eigenvaluestest ........................Subprocess aborted***Exception: 1.24 sec > Eigenvalues of Rosser matrix: (-1020.05,0) (0.0980486,0) (-1.05342e-14,0) (1020.05,0) (1020,0) (1019.9,0) (1000,0) (1000,0) > Eigenvalues of Rosser matrix: (-1020.05,0) (0.0980486,0) (-1.05342e-14,0) (1020.05,0) (1020,0) (1019.9,0) (1000,0) (1000,0) > Eigenvalues of Rosser matrix: (-1020.05,0) (0.0980486,0) (-1.05342e-14,0) (1020.05,0) (1020,0) (1019.9,0) (1000,0) (1000,0) > terminate called after throwing an instance of 'Dune::MathError' > what(): MathError [testSymmetricFieldMatrix:/tmp/guix-build-dune-common-2.9.0.drv-0/dune-common-2.9.0/dune/common/test/eigenvaluestest.cc:143]: Vector computed by FMatrixHelp::eigenValuesVectors is not an eigenvector > > […] > The following tests FAILED: > 99 - eigenvaluestest (Subprocess aborted) > Errors while running CTest > make: *** [Makefile:74: test] Error 8 > --8<---------------cut here---------------end--------------->8--- > > From . > > Could you take a look and/or report it upstream? Thanks for letting me know. I've looked into upstream issues/fixes for this problem and it seems that these aarch64 test failures are a known issue [1]. This bugreport mentions build failures in dune-common's Debian package, which nowadays seems to be patched to disable the failing tests [2]. [1]: https://gitlab.dune-project.org/core/dune-common/-/issues/262 [2]: https://sources.debian.org/src/dune-common/2.9.0-2/debian/patches/disable-long-double-eigenvalue-checks.patch/ I've prepared a patch to apply Debian's patch for disabling the failing tests to our dune-common package. You can find it attached to this email. Can you test if it fixes the aarch64-linux builds (I don't have access to an aarch64 machine)? I hope that this would also fix the build failures for the other dune-* packages on aarch64-linux, which are currently all failing because they depend on the broken dune-common package. Kind regards, Felix From 1001e15623108e6f92b89a1a2daacd43b5e2a123 Mon Sep 17 00:00:00 2001 From: Felix Gruber Date: Tue, 2 May 2023 21:59:30 +0200 Subject: [PATCH] gnu: dune-common: Fix build on aarch64-linux. * gnu/packages/maths.scm (dune-common)[source]: Add patch to disable tests that are failing on aarch64-linux. * gnu/packages/patches/dune-common-disable-long-double-eigenvalue-checks.patch: New file. * gnu/local.mk (dist_patch_DATA): Register it. --- gnu/local.mk | 1 + gnu/packages/maths.scm | 4 ++- ...isable-long-double-eigenvalue-checks.patch | 28 +++++++++++++++++++ 3 files changed, 32 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/dune-common-disable-long-double-eigenvalue-checks.patch diff --git a/gnu/local.mk b/gnu/local.mk index 1476c730ba..68a40e7c6c 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1056,6 +1056,7 @@ dist_patch_DATA = \ %D%/packages/patches/dovecot-trees-support-dovecot-2.3.patch \ %D%/packages/patches/dstat-fix-crash-when-specifying-delay.patch \ %D%/packages/patches/dstat-skip-devices-without-io.patch \ + %D%/packages/patches/dune-common-disable-long-double-eigenvalue-checks.patch \ %D%/packages/patches/dune-grid-add-missing-include-cassert.patch \ %D%/packages/patches/dune-istl-fix-solver-playground.patch \ %D%/packages/patches/dvd+rw-tools-add-include.patch \ diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm index d7e2719b70..31ae3796fc 100644 --- a/gnu/packages/maths.scm +++ b/gnu/packages/maths.scm @@ -6805,7 +6805,9 @@ (define-public dune-common version "/dune-common-" version ".tar.gz")) (sha256 (base32 - "04pzk8q0bibci8z5xlwndhh3y3vs63mw7kad62lbzfwrr5121hrd")))) + "04pzk8q0bibci8z5xlwndhh3y3vs63mw7kad62lbzfwrr5121hrd")) + (patches (search-patches + "dune-common-disable-long-double-eigenvalue-checks.patch")))) (build-system cmake-build-system) (arguments `(#:phases diff --git a/gnu/packages/patches/dune-common-disable-long-double-eigenvalue-checks.patch b/gnu/packages/patches/dune-common-disable-long-double-eigenvalue-checks.patch new file mode 100644 index 0000000000..cdab27b933 --- /dev/null +++ b/gnu/packages/patches/dune-common-disable-long-double-eigenvalue-checks.patch @@ -0,0 +1,28 @@ +--- a/dune/common/test/eigenvaluestest.cc ++++ b/dune/common/test/eigenvaluestest.cc +@@ -340,20 +340,20 @@ + testSymmetricFieldMatrix(); + testSymmetricFieldMatrix(); + testSymmetricFieldMatrix(); +- testSymmetricFieldMatrix(); +- testSymmetricFieldMatrix(); ++// testSymmetricFieldMatrix(); ++// testSymmetricFieldMatrix(); + #endif // HAVE_LAPACK + + testSymmetricFieldMatrix(); + testSymmetricFieldMatrix(); + testSymmetricFieldMatrix(); + testSymmetricFieldMatrix(); +- testSymmetricFieldMatrix(); +- testSymmetricFieldMatrix(); ++// testSymmetricFieldMatrix(); ++// testSymmetricFieldMatrix(); + + checkMultiplicity(); + checkMultiplicity(); +- checkMultiplicity(); ++// checkMultiplicity(); + + return 0; + } -- 2.39.2