From patchwork Fri Apr 30 14:36:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: M X-Patchwork-Id: 29029 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 0E59027BC7D; Fri, 30 Apr 2021 15:40:17 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 88E9127BC7C for ; Fri, 30 Apr 2021 15:40:12 +0100 (BST) Received: from localhost ([::1]:55702 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcUJP-0007MO-Lu for patchwork@mira.cbaines.net; Fri, 30 Apr 2021 10:40:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59746) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcUGM-0005Fd-8M for guix-patches@gnu.org; Fri, 30 Apr 2021 10:37:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47886) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lcUGM-0001VL-0I for guix-patches@gnu.org; Fri, 30 Apr 2021 10:37:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lcUGL-0002t2-UY for guix-patches@gnu.org; Fri, 30 Apr 2021 10:37:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48120] [PATCH]: Teach etc/committer.scm.in some stuff. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 30 Apr 2021 14:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 48120 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 48120@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.161979339711064 (code B ref -1); Fri, 30 Apr 2021 14:37:01 +0000 Received: (at submit) by debbugs.gnu.org; 30 Apr 2021 14:36:37 +0000 Received: from localhost ([127.0.0.1]:59432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lcUFt-0002sK-0i for submit@debbugs.gnu.org; Fri, 30 Apr 2021 10:36:37 -0400 Received: from lists.gnu.org ([209.51.188.17]:50798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lcUFn-0002s9-JS for submit@debbugs.gnu.org; Fri, 30 Apr 2021 10:36:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59634) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcUFn-0004f9-Am for guix-patches@gnu.org; Fri, 30 Apr 2021 10:36:27 -0400 Received: from andre.telenet-ops.be ([2a02:1800:120:4::f00:15]:56998) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lcUFg-0000vG-NB for guix-patches@gnu.org; Fri, 30 Apr 2021 10:36:27 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by andre.telenet-ops.be with bizsmtp id z2cF2400p0mfAB4012cFsQ; Fri, 30 Apr 2021 16:36:16 +0200 Message-ID: From: Maxime Devos Date: Fri, 30 Apr 2021 16:36:05 +0200 User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1619793376; bh=1CzUq+bPbI3li11PJHHsUELyRic2R+dzazIvVAE0Aew=; h=Subject:From:To:Date; b=OyEJnDTZBMn9MLu6wGHqwk3L1eqNRVr9WBH8vi5hn/JjoWmLLgIJdR85uQ5ZF9Co0 Kv4G46Kpic+B6Q3Ri0NUoADLDo2cV8wHm/SmbtmwAkLRjY3WzwXPHw+6r+EOVI5Aku Qw8PE/McmZ8czz+gvZ+9EZguJRwIjM22Tb5YsxSJ4/6GcJOC8nylaLHbY07OX+sLgY K5Q0L53yuoqpEG4AD8LBQH8h/OtWAKvH+g49T9Vlr03sFbY/dNpTON+L0+SkplI42v dvN9v4+7XnTYiXI5UnvrTbY1+YVIxi4jyZKKZCif9DgMgLvbEEfIp6oElJb9en9+Hy fQH5WZ662eP0Q== Received-SPF: pass client-ip=2a02:1800:120:4::f00:15; envelope-from=maximedevos@telenet.be; helo=andre.telenet-ops.be X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi Guix, I snarfed these from my cc-for-target branch. Examples of generated commit messages, without any massaging: gnu: ufoai-data: Use 'cc-for-target' and friends. * gnu/packages/games.scm (ufoai-data) [arguments]<#:configure-flags>: Use the C cross-compiler, instead of hardcoding "gcc". Use the C++ cross-compiler, instead of hardcoding "g++". gnu: mlt: Use 'cc-for-target' and friends. * gnu/packages/video.scm (mlt) [arguments]<#:make-flags>: Use the C cross-compiler, instead of hardcoding "gcc". Use the C++ cross-compiler, instead of hardcoding "g++". gnu: theorafile: Use the C cross-compiler. * gnu/packages/video.scm (theorafile) [arguments]<#:make-flags>: Use the C cross-compiler, instead of hardcoding "gcc". [arguments]<#:phases>{check}: Only run tests when not requested. etc/comitter.scm.in should probably do some line wrapping as well. WDYT? Greetings, Maxime. From 295cca1e1745acfea49b54681d566dd3d0c1dd19 Mon Sep 17 00:00:00 2001 From: Maxime Devos Date: Fri, 30 Apr 2021 15:45:02 +0200 Subject: [PATCH 6/6] etc: committer: Explain changes in #:configure-flags. * etc/committer.scm.in (change-commit-message/one-pass)[explain-argument]: Handle #:configure-flags the same way as #:make-flags for now. --- etc/committer.scm.in | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/etc/committer.scm.in b/etc/committer.scm.in index fc3c929f17..0fd383533d 100755 --- a/etc/committer.scm.in +++ b/etc/committer.scm.in @@ -381,8 +381,12 @@ SUMMARY: first using a ‘void port’, then with the ‘real’ output port." (define (explain-argument keyword old new) (unless (equal? old new) (case keyword - ((#:make-flags) - (format port "[arguments]<#:make-flags>:") + ;; Sometimes, arguments like "CC=TARGET-gcc" are passed to the + ;; configure script. Their interpretation is sometimes the same + ;; as in makefiles. Hence, for now we unify the handling of + ;; #:make-flags and #:configure-flags. + ((#:make-flags #:configure-flags) + (format port "[arguments]<~a>:" keyword) (if (explain-list-delta (unwrap-list old) (unwrap-list new) #:pairwise/change explain-make-flags/change) ;; There were some unexplained changes. -- 2.31.1