From patchwork Fri Jan 5 20:53:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christopher Baines X-Patchwork-Id: 58399 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id A720427BBEC; Fri, 5 Jan 2024 20:54:28 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 1C6CD27BBEA for ; Fri, 5 Jan 2024 20:54:27 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rLrCd-0005wq-44; Fri, 05 Jan 2024 15:54:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rLrCa-0005w5-LP for guix-patches@gnu.org; Fri, 05 Jan 2024 15:54:00 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rLrCa-0007WC-1r; Fri, 05 Jan 2024 15:54:00 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rLrCc-00046l-EZ; Fri, 05 Jan 2024 15:54:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68271] [PATCH 2/3] guix: derivations: Use delete-duplicates/sort. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix@cbaines.net, dev@jpoiret.xyz, ludo@gnu.org, othacehe@gnu.org, rekado@elephly.net, zimon.toutoune@gmail.com, me@tobias.gr, guix-patches@gnu.org Resent-Date: Fri, 05 Jan 2024 20:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68271 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 68271@debbugs.gnu.org Cc: Christopher Baines , Josselin Poiret , Ludovic =?utf-8?q?Court=C3=A8s?= , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice X-Debbugs-Original-Xcc: Christopher Baines , Josselin Poiret , Ludovic =?utf-8?q?Court=C3=A8s?= , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice Received: via spool by 68271-submit@debbugs.gnu.org id=B68271.170448801215735 (code B ref 68271); Fri, 05 Jan 2024 20:54:02 +0000 Received: (at 68271) by debbugs.gnu.org; 5 Jan 2024 20:53:32 +0000 Received: from localhost ([127.0.0.1]:58038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLrC7-00045h-Py for submit@debbugs.gnu.org; Fri, 05 Jan 2024 15:53:32 -0500 Received: from mira.cbaines.net ([212.71.252.8]:43070) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLrC5-00045L-8w for 68271@debbugs.gnu.org; Fri, 05 Jan 2024 15:53:30 -0500 Received: from localhost (unknown [217.155.61.229]) by mira.cbaines.net (Postfix) with ESMTPSA id E941127BBE9 for <68271@debbugs.gnu.org>; Fri, 5 Jan 2024 20:53:23 +0000 (GMT) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 8acfac1b for <68271@debbugs.gnu.org>; Fri, 5 Jan 2024 20:53:22 +0000 (UTC) From: Christopher Baines Date: Fri, 5 Jan 2024 20:53:21 +0000 Message-ID: X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches As this seems to be a small speedup, as tested by computing derivations for all packages targeting i586-pc-gnu. * guix/derivations.scm (derivation/masked-inputs): Use delete-duplicates/sort. Change-Id: I9ec963c10e67a525037c346f44c92a87376935c5 --- guix/derivations.scm | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/guix/derivations.scm b/guix/derivations.scm index 9fec7f4f0b..29c7ef9a5c 100644 --- a/guix/derivations.scm +++ b/guix/derivations.scm @@ -745,10 +745,12 @@ (define (derivation/masked-inputs drv) (make-derivation-input hash sub-drvs)))) inputs))) (make-derivation outputs - (sort (delete-duplicates inputs) - (lambda (drv1 drv2) - (string