From patchwork Sun Aug 4 20:31:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lilah Tascheter X-Patchwork-Id: 66701 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id E8A2527BBEA; Sun, 4 Aug 2024 21:34:57 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FROM_SUSPICIOUS_NTLD,MAILING_LIST_MULTI,PDS_OTHER_BAD_TLD, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id C388C27BBE2 for ; Sun, 4 Aug 2024 21:34:56 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sahwB-0002Fo-GS; Sun, 04 Aug 2024 16:34:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sahwA-0002FU-20 for guix-patches@gnu.org; Sun, 04 Aug 2024 16:34:42 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sahw9-0008JP-OJ for guix-patches@gnu.org; Sun, 04 Aug 2024 16:34:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:Date:From:To:Subject; bh=t3putvifLmBtxRMBIO2MkhAQkvsLpbOrET+GfLPM8+U=; b=b2R49D2NEHvaI3C2wZh9ycwByOLhPaWIbkLZ365Uz11xjg9Fm5W2T6hZH/yi8bglQrA0FrzKUKy6l+clpUOX43H9KVpXbDCdEt1qTM9jHgdBMUYWbcnWW9n4jwHI3e3LTbKyKX5CwPsZifQZnrzqiiNx2jlBCMGXFJUMdyJOstNYg31VgznewOJAQM/P3jo8LPHd3MkDhpjQKWUdwRiSnsR0GXfPxlaR+BE9sFAOvU9tpiWSIWMCEPhTbaPKNIwGQyTMGBn+Bsp1fQ5ER1euzWQ+SXIlOy2HN3VoNGBOOmeMshA2Ll+jF+o8sausimPrF2gBTTZBepyboPwG5W+rAg==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sahwV-0006O1-61 for guix-patches@gnu.org; Sun, 04 Aug 2024 16:35:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72457] [PATCH v3 05/15] gnu: system: Remove useless boot parameters. Resent-From: Lilah Tascheter Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 04 Aug 2024 20:35:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72457 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 72457@debbugs.gnu.org Cc: Lilah Tascheter , Sergey Trofimov Received: via spool by 72457-submit@debbugs.gnu.org id=B72457.172280365424198 (code B ref 72457); Sun, 04 Aug 2024 20:35:03 +0000 Received: (at 72457) by debbugs.gnu.org; 4 Aug 2024 20:34:14 +0000 Received: from localhost ([127.0.0.1]:57335 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sahvh-0006IA-1H for submit@debbugs.gnu.org; Sun, 04 Aug 2024 16:34:13 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:35032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sahvf-0006HF-2w for 72457@debbugs.gnu.org; Sun, 04 Aug 2024 16:34:11 -0400 Authentication-Results: purelymail.com; auth=pass DKIM-Signature: a=rsa-sha256; b=NdSaUuzkNGIIv5h3as9mfrHgyIGoD0fs2vVi36kMKXVBVeUd5O0SaRKGWOZI3O1XPzT0L+S9oTI+fSBwUSguxeDhxXQzcfZ5QcrHXxXJA+mpvbhb+vn/FTlVwczX4CAmD4CVMrQRXv9SHDIHZQ3DkNnWcGu4FeWu4sRXK0Ia1fE4H4oThxjtOhkE0Z310RPEW4qFuAmfsqQAC0vjPtcYlrZ3ZKdz19itHlERaIFGVbWhfpod/9P4U2NAvHAi9+yzMp/1PtlVreR/jDDZFcc3BDAqhZG/T4MdphpknDRoJ5IfPyyLybcrFRFDOloa2myNtdUwe0jA3VBEf6tkS6BfUA==; s=purelymail2; d=lunabee.space; v=1; bh=ol1uWhvcd6jg8jrl+jAW7wdPNF/rhebpv51yL/ZJ3vU=; h=Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=mDlNXug/BF4O/w4s1ZmUrNnFrW5sHq3i/97Y9mcJnjVe84lBRQTZrC9shtPQKHy8bMHUlyx4E/dLfs8qHtIOCs1qIzGr+CmWo+mEUdSh+VgVQedGU1nZCpKlwWsV7v6ygk/ooOKZqQTL+B8VHYkpAHCG5tFsBEkeLIv3eY+IyopEgpJA7YQHl1rC4eYIy7+efYbJ5EFnv6w2LqqZi3pmhJhoDtopLLyfH+KZY+p/IJq1Gz4h3TfNCtsIWDCHVlAYmt4xfzVsD2FqSI2Xa5J1iCxbUqWgPd9lo+yHZUkHHwNxYRZEPU1pRQxoL08S5guYwdKtTj/Ng3s20YwoHotqiA==; s=purelymail2; d=purelymail.com; v=1; bh=ol1uWhvcd6jg8jrl+jAW7wdPNF/rhebpv51yL/ZJ3vU=; h=Feedback-ID:Received:From:To:Subject:Date; Feedback-ID: 8937:2070:null:purelymail X-Pm-Original-To: 72457@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -1317130453; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sun, 04 Aug 2024 20:33:38 +0000 (UTC) Date: Sun, 4 Aug 2024 15:31:51 -0500 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-MIME-Autoconverted: from 8bit to quoted-printable by Purelymail X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Lilah Tascheter via Guix-patches From: Lilah Tascheter Reply-To: Lilah Tascheter Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches * gnu/system.scm (operating-system-boot-parameters, operating-system-boot-parameters-file): Delete bootloader-menu-entries. * gnu/system/boot.scm (boot-parameters)[bootloader-menu-entries]: Delete fields. (read-boot-parameters): Don't read bootloader-menu-entries. * tests/boot-parameters.scm (%grub-boot-parameters, test-read-boot-parameters, test-read-boot-parameters): Don't include bootloader-menu-entries. ("read, bootloader-menu-entries, default value"): Delete test. Change-Id: I46d9cff4604dbfcf654b0820fdb77e72aecffbb4 --- gnu/system.scm | 7 ------- gnu/system/boot.scm | 8 -------- tests/boot-parameters.scm | 14 ++------------ 3 files changed, 2 insertions(+), 27 deletions(-) diff --git a/gnu/system.scm b/gnu/system.scm index a345b52d55..66c1a80733 100644 --- a/gnu/system.scm +++ b/gnu/system.scm @@ -1304,8 +1304,6 @@ (define* (operating-system-boot-parameters os root-device (initrd initrd) (multiboot-modules multiboot-modules) (bootloader-name bootloader-name) - (bootloader-menu-entries - (bootloader-configuration-menu-entries (operating-system-bootloader os))) (locale locale) (store-device (ensure-not-/dev (file-system-device store))) (store-directory-prefix (btrfs-store-subvolume-file-name file-systems)) @@ -1347,11 +1345,6 @@ (define* (operating-system-boot-parameters-file os) #$(boot-parameters-multiboot-modules params))) #~()) (bootloader-name #$(boot-parameters-bootloader-name params)) - (bootloader-menu-entries - #$(map menu-entry->sexp - (or (and=> (operating-system-bootloader os) - bootloader-configuration-menu-entries) - '()))) (locale #$(boot-parameters-locale params)) (store (device diff --git a/gnu/system/boot.scm b/gnu/system/boot.scm index 2b5302ce5f..4d89827ced 100644 --- a/gnu/system/boot.scm +++ b/gnu/system/boot.scm @@ -54,7 +54,6 @@ (define-module (gnu system boot) boot-parameters-label boot-parameters-root-device boot-parameters-bootloader-name - boot-parameters-bootloader-menu-entries boot-parameters-store-crypto-devices boot-parameters-store-device boot-parameters-store-directory-prefix @@ -113,8 +112,6 @@ (define-record-type* ;; partition. (root-device boot-parameters-root-device) (bootloader-name boot-parameters-bootloader-name) - (bootloader-menu-entries ;list of - boot-parameters-bootloader-menu-entries) (store-device boot-parameters-store-device) (store-mount-point boot-parameters-store-mount-point) (store-directory-prefix boot-parameters-store-directory-prefix) @@ -176,11 +173,6 @@ (define (read-boot-parameters port) ((_ args) (list args)) (#f 'grub))) ; for compatibility reasons. - (bootloader-menu-entries - (match (assq 'bootloader-menu-entries rest) - ((_ entries) (map sexp->menu-entry entries)) - (#f '()))) - ;; In the past, we would store the directory name of linux instead of ;; the absolute file name of its image. Detect that and correct it. (kernel (if (string=? kernel (direct-store-path kernel)) diff --git a/tests/boot-parameters.scm b/tests/boot-parameters.scm index 2e7976aa6c..f214de360d 100644 --- a/tests/boot-parameters.scm +++ b/tests/boot-parameters.scm @@ -64,7 +64,6 @@ (define %root-path "/") (define %grub-boot-parameters (boot-parameters (bootloader-name 'grub) - (bootloader-menu-entries '()) (root-device %default-root-device) (label %default-label) (kernel %default-kernel) @@ -107,7 +106,6 @@ (define* (test-read-boot-parameters #:key (version %boot-parameters-version) (bootloader-name 'grub) - (bootloader-menu-entries '()) (label %default-label) (root-device (quote-uuid %default-root-device)) (kernel %default-kernel) @@ -127,7 +125,7 @@ (define* (test-read-boot-parameters (cond ((eq? 'false val) (format #false fmt #false)) (val (format #false fmt val)) (else ""))) - (format #false "(boot-parameters~a~a~a~a~a~a~a~a~a~a)" + (format #false "(boot-parameters~a~a~a~a~a~a~a~a~a)" (sexp-or-nothing " (version ~S)" version) (sexp-or-nothing " (label ~S)" label) (sexp-or-nothing " (root-device ~S)" root-device) @@ -145,9 +143,7 @@ (define* (test-read-boot-parameters store-crypto-devices)) "") (sexp-or-nothing " (locale ~S)" locale) - (sexp-or-nothing " (bootloader-name ~a)" bootloader-name) - (sexp-or-nothing " (bootloader-menu-entries ~S)" - bootloader-menu-entries))) + (sexp-or-nothing " (bootloader-name ~a)" bootloader-name))) (let ((str (generate-boot-parameters))) (call-with-input-string str read-boot-parameters))) @@ -170,7 +166,6 @@ (define* (test-read-boot-parameters (test-assert "read, construction, optional fields" (and (test-read-boot-parameters #:bootloader-name #false) - (test-read-boot-parameters #:bootloader-menu-entries #false) (test-read-boot-parameters #:kernel-arguments #false) (test-read-boot-parameters #:with-store #false) (test-read-boot-parameters #:store-device #false) @@ -223,11 +218,6 @@ (define* (test-read-boot-parameters (boot-parameters-bootloader-name (test-read-boot-parameters #:bootloader-name #false))) -(test-eq "read, bootloader-menu-entries, default value" - '() - (boot-parameters-bootloader-menu-entries - (test-read-boot-parameters #:bootloader-menu-entries #false))) - (test-eq "read, kernel-arguments, default value" '() (boot-parameters-kernel-arguments