From patchwork Sun Mar 23 14:24:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ludovic_Court=C3=A8s?= X-Patchwork-Id: 40737 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 3AD5927BBE2; Sun, 23 Mar 2025 14:26:48 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id DE41927BBEA for ; Sun, 23 Mar 2025 14:26:46 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1twMHI-00030E-1A; Sun, 23 Mar 2025 10:26:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1twMHF-0002zQ-OW for guix-patches@gnu.org; Sun, 23 Mar 2025 10:26:13 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1twMHF-0005VH-6E for guix-patches@gnu.org; Sun, 23 Mar 2025 10:26:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:Date:From:To:Subject; bh=fUCaHHG/eO75rZDRlbk9XFL7p37y9SICE8zVkSS6pAE=; b=o9DESZOMOJ3g+XPG3XWocNan5D81RcUcKYejhjHexdRNgYLWp/lnH1lF5UrpES3fN+Oma7j6ZptqpL/fm7m8QwzL7f+zwIH38TleGjJ18AXuMa/brLgnmSDpSdwcxR/XJR3vmfJHTozT6q0SlBTgzhmHRwGubTN6wc58FcdENqfaNoTsDK+3QA6Ul/0Idv0iDSdvjVAZnV9hDTt94CX4iO4iVGnh2zpa1XDqUmo1tjim8YFKcaED5OY/IxNU3U7XX7KNURxcyUQouRPPNF/HegCbiMbj7XhwVWTSjwKUHa2Xl5FO++8kAWFCIQ14XVHSyXUjhFwQqhhx8dOF1PBYzw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1twMHF-0005Xs-07 for guix-patches@gnu.org; Sun, 23 Mar 2025 10:26:13 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#75810] [PATCH v8 02/16] daemon: Close the read end of the logging pipe. Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 23 Mar 2025 14:26:12 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75810 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 75810@debbugs.gnu.org Cc: Ludovic =?utf-8?q?Court=C3=A8s?= , Reepca Russelstein Received: via spool by 75810-submit@debbugs.gnu.org id=B75810.174273996521193 (code B ref 75810); Sun, 23 Mar 2025 14:26:12 +0000 Received: (at 75810) by debbugs.gnu.org; 23 Mar 2025 14:26:05 +0000 Received: from localhost ([127.0.0.1]:51868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1twMH3-0005Uz-09 for submit@debbugs.gnu.org; Sun, 23 Mar 2025 10:26:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43736) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1twMGi-0005QJ-Oz for 75810@debbugs.gnu.org; Sun, 23 Mar 2025 10:25:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1twMGb-0005Rk-3C; Sun, 23 Mar 2025 10:25:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=fUCaHHG/eO75rZDRlbk9XFL7p37y9SICE8zVkSS6pAE=; b=Y4s/GyJUjCjWRu5UpqxZ VJwHWUEL9a3+AB9vBF5WrHs02V7bpMFWeN+uOBYQ+VojQrHmlP1o9ES6uoE+2KugOKTleuTeuu+CE WF0QMdSHAo3oLQv0Sofou0RrZgMfO43ZZseJ5o7tRVE2JCEZKa/oSkkYMHu/KY9eq1ZwFsO3FX3Vl /YVtGCJNsru6+pSUodTecPr0i0TRh3jwV9GI/XeetDyDbWF9lLsGOgaSqURsu0SP/+ZTqHCjaFGy9 sVQQIsA27sPWRktZvKvCjHmnR6WPzIUSV91wkelGdCDr1X4r64KMwhp84doqRBzC1No0/b2TMSYSJ LIxJmXKFHzmogA==; From: Ludovic =?utf-8?q?Court=C3=A8s?= Date: Sun, 23 Mar 2025 15:24:55 +0100 Message-ID: X-Mailer: git-send-email 2.48.1 In-Reply-To: References: MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches * nix/libutil/util.cc (commonChildInit): Close ‘logPipe.readSide’. Reported-by: Reepca Russelstein Change-Id: Ia9e48d1afb85d7af52770e016f2b6832792044dd --- nix/libutil/util.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/nix/libutil/util.cc b/nix/libutil/util.cc index eb2d16e1cc..56f116046c 100644 --- a/nix/libutil/util.cc +++ b/nix/libutil/util.cc @@ -1279,6 +1279,9 @@ void commonChildInit(Pipe & logPipe) if (setsid() == -1) throw SysError(format("creating a new session")); + /* Close the read end so only the parent holds a reference to it. */ + logPipe.readSide.close(); + /* Dup the write side of the logger pipe into stderr. */ if (dup2(logPipe.writeSide, STDERR_FILENO) == -1) throw SysError("cannot pipe standard error into log file");