diff mbox series

[bug#76717] services: readymedia-activation: Change directory permissions to 775.

Message ID c039ec9c55cefc5880a56eb48aebbd56e087e799.1741021635.git.sughosha@disroot.org
State New
Headers
Series [bug#76717] services: readymedia-activation: Change directory permissions to 775. |

Commit Message

Sughosha March 3, 2025, 5:07 p.m. UTC 
  Allow users in readymedia group to write in the directory created by
readymedia-activation.

* gnu/services/upnp.scm (readymedia-activation): Change directory permissions
to 775.

Change-Id: Ifda8e4fe8594fb5a1cdf6e329a8c83551eab9c06
---
 gnu/services/upnp.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: f3f09fb4a370fd0363fd216f73736164a2a29f7b

Comments

Ludovic Courtès March 8, 2025, 5:06 p.m. UTC | #1 
Sughosha <sughosha@disroot.org> skribis:

> Allow users in readymedia group to write in the directory created by
> readymedia-activation.
>
> * gnu/services/upnp.scm (readymedia-activation): Change directory permissions
> to 775.
>
> Change-Id: Ifda8e4fe8594fb5a1cdf6e329a8c83551eab9c06
> ---

Applied, thanks!
Ludovic Courtès March 10, 2025, 10:06 p.m. UTC | #2 
Sughosha <sughosha@disroot.org> skribis:

> Allow users in readymedia group to write in the directory created by
> readymedia-activation.
>
> * gnu/services/upnp.scm (readymedia-activation): Change directory permissions
> to 775.
>
> Change-Id: Ifda8e4fe8594fb5a1cdf6e329a8c83551eab9c06

I noticed (but too late) that this triggers failures of the ‘readymedia’
system test:

--8<---------------cut here---------------start------------->8---
PASS: ReadyMedia user exists
PASS: ReadyMedia group exists
PASS: cache directory exists
PASS: cache directory has correct ownership
/gnu/store/hz3am9anh55m4d0951wq9gqr1z7n5zas-readymedia-test-builder:1: FAIL cache directory has expected permissions
PASS: log directory exists
PASS: log directory has correct ownership
/gnu/store/hz3am9anh55m4d0951wq9gqr1z7n5zas-readymedia-test-builder:1: FAIL log directory has expected permissions
PASS: log file exists
PASS: log file has expected permissions
PASS: ReadyMedia service is running
PASS: ReadyMedia service is listening for connections
# of expected passes      10
# of unexpected failures  2
--8<---------------cut here---------------end--------------->8---

(From <https://ci.guix.gnu.org/build/9557295/log>.)

Could you send a patch adjusting the test or suggest the way forward?

Thanks, and apologies for overlooking it!

Ludo’.
diff mbox series

Patch

diff --git a/gnu/services/upnp.scm b/gnu/services/upnp.scm
index e5d05add28..c125c07af2 100644
--- a/gnu/services/upnp.scm
+++ b/gnu/services/upnp.scm
@@ -187,7 +187,7 @@  (define (readymedia-activation config)
                       (unless (file-exists? directory)
                         (mkdir-p/perms directory
                                        (getpw #$%readymedia-user-account)
-                                       #o755)))
+                                       #o775)))
                     (list #$cache-directory
                           #$log-directory
                           #$@(map readymedia-media-directory-path