[bug#78672] gnu: ngtcp2: Update to 1.13.0.

Message ID bfc38c0523b606ff47bfe00a4cdd78586b7c04f1.1748886564.git.~@wolfsden.cz
State New
Headers
Series [bug#78672] gnu: ngtcp2: Update to 1.13.0. |

Commit Message

Tomas Volf June 2, 2025, 5:49 p.m. UTC
  * gnu/packages/networking.scm (ngtcp2): Update to 1.13.0.

Change-Id: Ie83ea3dc6920c80b246cffd7678d53dbaba5f228
---
 gnu/packages/networking.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Andreas Enge June 13, 2025, 9:39 a.m. UTC | #1
Hello Tomas,

the update breaks vlang:
   https://qa.guix.gnu.org/issue/78672/package-changes?x86_64-linux-change=broken&x86_64-linux-change=still-failing&x86_64-linux-change=unknown-to-failing&x86_64-linux-change=new-failing

Could you have a look, please?

Andreas
  
Tomas Volf June 13, 2025, 8:06 p.m. UTC | #2
Hi,

Andreas Enge <andreas@enge.fr> writes:

> the update breaks vlang:
>    https://qa.guix.gnu.org/issue/78672/package-changes?x86_64-linux-change=broken&x86_64-linux-change=still-failing&x86_64-linux-change=unknown-to-failing&x86_64-linux-change=new-failing
>
> Could you have a look, please?

Well, as usual, builds for me:

--8<---------------cut here---------------start------------->8---
$ g l -2 --oneline --no-decorate
d7a47224ca gnu: ngtcp2: Update to 1.13.0.
60828ad981 gnu: direnv: Don't install go sources.
$ guix shell -CWN -D guix -- ./pre-inst-env guix build vlang
/gnu/store/y23d0ih34kb8fm86m4kx0dgijy8m034g-vlang-0.2.4
--8<---------------cut here---------------end--------------->8---

Also, looking into the build log from your link, I see

--8<---------------cut here---------------start------------->8---
 FAIL  [ 43/640]  6732.170 ms vlib/io/reader_test.v
sh: line 1: /tmp/guix-build-vlang-0.2.4.drv-0/v/test_session_1463470970505238/reader_test: Permission denied
--8<---------------cut here---------------end--------------->8---

and

--8<---------------cut here---------------start------------->8---
 FAIL  [ 48/640]  9820.446 ms vlib/encoding/csv/reader_test.v
sh: line 1: /tmp/guix-build-vlang-0.2.4.drv-0/v/test_session_1463470970505238/reader_test: No such file or directory
V panic: Failed to remove "/tmp/guix-build-vlang-0.2.4.drv-0/v/test_session_1463470970505238/reader_test": No such file or directory
v hash: 2533f06
                                                        |       0x6d8f96 | /tmp/guix-build-vlang-0.2.4.drv-0/source/v() 
                                                        |       0x6d8cbb | /tmp/guix-build-vlang-0.2.4.drv-0/source/v() 
                                                        |       0x6d83b6 | /tmp/guix-build-vlang-0.2.4.drv-0/source/v() 
                                                        |       0x6e31ee | /tmp/guix-build-vlang-0.2.4.drv-0/source/v() 
                                                        |       0x6f29e3 | /tmp/guix-build-vlang-0.2.4.drv-0/source/v() 
                                                        | 0x7ffff7df3bf7 | /gnu/store/zvlp3n8iwa1svxmwv4q22pv1pb1c9pjq-glibc-2.39/lib/libc.so.6(+0x29bf7) 
                                                        | 0x7ffff7df3cac | /gnu/store/zvlp3n8iwa1svxmwv4q22pv1pb1c9pjq-glibc-2.39/lib/libc.so.6(__libc_start_main+0x7c) 
                                                        |       0x402641 | /tmp/guix-build-vlang-0.2.4.drv-0/source/v()
--8<---------------cut here---------------end--------------->8---

I would *hope* version of ngtcp2 should have no effect on these errors.

Maybe I should just stop touching these two libraries unless necessary.
It seems I have picked somewhat fragile part of Guix to send patches
for. :/

Tomas
  
Andreas Enge June 14, 2025, 1:27 p.m. UTC | #3
Am Fri, Jun 13, 2025 at 10:06:05PM +0200 schrieb Tomas Volf:
> Andreas Enge <andreas@enge.fr> writes:
> > the update breaks vlang:
> Well, as usual, builds for me:

Ah, I see, it also does for me (after spending ages building node);
so I have just pushed; if these are random failures, I do not think the
situation will be worse after that.

> Maybe I should just stop touching these two libraries unless necessary.
> It seems I have picked somewhat fragile part of Guix to send patches
> for. :/

Ah, your choice! :-)  But what can we do, we also need to update brittle
software shipped with Guix.

Andreas
  

Patch

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index e2d8f271b7..27c7d8ae8f 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -4691,7 +4691,7 @@  (define-public nbd
 (define-public ngtcp2
   (package
     (name "ngtcp2")
-    (version "1.12.0")
+    (version "1.13.0")
     (source
      (origin
        (method url-fetch)
@@ -4699,7 +4699,7 @@  (define-public ngtcp2
                            "releases/download/v" version "/"
                            "ngtcp2-" version ".tar.gz"))
        (sha256
-        (base32 "047glkg71rikj7s46jb9aaipqn13arzz0pvph5kg66f0pz4zb2n0"))))
+        (base32 "1sik0rlpar1dk46ahssv59ik1w360v97hydzari77m8khfjscxd1"))))
     (build-system gnu-build-system)
     (arguments
      (list