| Message ID | bcd58e2dc5d4349d36ed2b670359e8fd31d5d4bd.1667807492.git.avityazev@posteo.org |
|---|---|
| State | New |
| Headers | show |
| Series | [bug#59097] gnu: emacs-skempo: Remove dependency on emacs-parent-mode. | expand |
| Context | Check | Description |
|---|---|---|
| cbaines/comparison | success | View comparision |
| cbaines/git-branch | success | View Git branch |
| cbaines/applying patch | success | |
| cbaines/issue | success | View issue |
Aleksandr Vityazev <avityazev@posteo.org> writes: > * gnu/packages/emacs-xyz.scm (emacs-skempo)[propagated-inputs]: > Remove dependency on emacs-parent-mode. > --- > gnu/packages/emacs-xyz.scm | 2 -- > 1 file changed, 2 deletions(-) While writing the changelog in the commit is good (so thanks for that), it's still often important to put something in the commit about why the change is being made. That includes this case, I'm left wondering why this propagated-input is being removed? Note that I'm not asking for some detailed and airtight argument for making the change, I just want to why you think this is good to do, even if that's just "it doesn't seem to be needed". Thanks, Chris
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 4bbebd3cd6..27039609fd 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -4772,8 +4772,6 @@ (define-public emacs-skempo (base32 "0xsr6819qaad0y8rhfrf555c9w7cmgbgkf1a2svgbp7rhhnywl0a")))) (build-system emacs-build-system) - (propagated-inputs - (list emacs-parent-mode)) (home-page "https://github.com/xFA25E/skempo") (synopsis "Enhancements for skeleton/tempo + abbrev") (description