From patchwork Tue Mar 11 19:15:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Sergio_Pastor_P=C3=A9rez?= X-Patchwork-Id: 40111 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id B7D2727BBEA; Tue, 11 Mar 2025 19:19:50 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE,SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id F1A8C27BBE2 for ; Tue, 11 Mar 2025 19:19:49 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ts58F-0002I1-De; Tue, 11 Mar 2025 15:19:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ts584-0002Fu-RM for guix-patches@gnu.org; Tue, 11 Mar 2025 15:19:06 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ts584-0002Uy-DH for guix-patches@gnu.org; Tue, 11 Mar 2025 15:19:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:Date:From:To:Subject; bh=vA++wNXTLR98hduQwgQi2KXv9O9F+V32x9/0SFv+5Vw=; b=q2IPL1YTghgtAhW2QqwEX1v99jUWiYUfMTYgNK3x9QDPQri6sM34gLyr2dbU3F3FWVsy9cEShtGbWvVlC6ZDtIY59ltpfo4PDvvTa+S50PoBoCDRa/GPHhUA+QFI5NWtP2YsLDs3YFc+A1CnWzWp7acxnuF0POn1Z8xgqt2bhw5QQ6OByGLUfmdB/rTgJTLQdGQ7//AKEZYbcu6YVIOXDz1Bj4RdGHocSte+3w9RjKfEiwQyY26A4GLyqFVXLN9Tt4E+YSI9GoAPtENQH3UDeZhLaIjjn1oOtBcU16Hy50O72slLFQkFe3mWUnDYg8vaLz5Z83G8y8lDE2Nwv08bEA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ts582-0000KK-8S; Tue, 11 Mar 2025 15:19:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#67755] [PATCH v5 9/9] gnu: Add imhex. Resent-From: Sergio Pastor =?utf-8?b?UMOpcmV6?= Original-Sender: "Debbugs-submit" Resent-CC: sergio.pastorperez@outlook.es, jgart@dismail.de, guix-patches@gnu.org Resent-Date: Tue, 11 Mar 2025 19:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67755 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 67755@debbugs.gnu.org Cc: Sergio Pastor =?utf-8?b?UMOpcmV6?= , Sergio Pastor =?utf-8?b?UMOpcmV6?= , jgart X-Debbugs-Original-Xcc: Sergio Pastor =?utf-8?b?UMOpcmV6?= , jgart Received: via spool by 67755-submit@debbugs.gnu.org id=B67755.17417206911172 (code B ref 67755); Tue, 11 Mar 2025 19:19:02 +0000 Received: (at 67755) by debbugs.gnu.org; 11 Mar 2025 19:18:11 +0000 Received: from localhost ([127.0.0.1]:45777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ts57B-0000Io-RD for submit@debbugs.gnu.org; Tue, 11 Mar 2025 15:18:11 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]:45057) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1ts56X-0000Eo-6e for 67755@debbugs.gnu.org; Tue, 11 Mar 2025 15:17:29 -0400 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-43cfebc343dso13849555e9.2 for <67755@debbugs.gnu.org>; Tue, 11 Mar 2025 12:17:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741720642; x=1742325442; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vA++wNXTLR98hduQwgQi2KXv9O9F+V32x9/0SFv+5Vw=; b=c8WRcrsP0xt0Od09GTjJISWB1MTs6fvgofhqyTAWHpxzBMh3qeHH2BEpGp8YOlJiLM xtMYbx62TNRsQA6a+MmumimvMOnB8jqBoE2gWL8l5+ecOD3/lZ2tvXLsB7KhATXdBCgn P3WkbCRPRY07yblD1y7OUAnTRP5kz+K6obwPIy6ooMBy/zCCotTnNPh5rUIcwUNxrfo6 t9UkOoy/y1R2ER5cPkakE74nQuSk1TCrsrmCiSFNUjL108V8x65B/PUKDHfAlvViPJWD 2neCOdQOZ5aFM5QU+XpXnPPjDYdg11ryryTxg/lXva9wsPsMf+rEF8r+nP9x+xycipPU o8Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741720642; x=1742325442; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vA++wNXTLR98hduQwgQi2KXv9O9F+V32x9/0SFv+5Vw=; b=DD3BZkvr362QYg0doSooJwmVvWMYKQv4bKTQ+FS9IA3XYw8rY+wtd/+65lXDGtgOYn dDtwzYUsXIR7zMy/UJkPO0iL7w8j7fu12oN7UCMsQP6WcOowW5zyNxg8L5EMmBEX9hSw 4Qd9C8QmR/+HdpcAew66MmHJ+LtfsxtJ3UDDuMki6P7NUey8PJkRFOBd4cexVic9egOF CH4BQQl/TvXa48gDbph6johLHnwLL0DEUMefK4wtpcQNbyZ1d/YQYXM+hSxy1QYyTc8T wmixa0zHcqUOTPut7A/50drfV/c1TkAuGeLcpTIXsPtBIEBPiaO6ZW2fW1oDuRQJ64tt rOYg== X-Gm-Message-State: AOJu0YxBv6+ipTrFLas+ViOqWm4NMg1MLXkRlqKLg4TsZI2OYgd1+rKj DnpYXuNY7yesf8JVtCdTCptMKu6EIAQFGbgYoJ/Q3mN1yxq4W3Jlq35GaQ== X-Gm-Gg: ASbGncuQ8M5ylsEgxfUr+oPomDRuvDJucHZsuPIbPY/pN4kdGmfCM+S03mF43Iu9s7D pYDbNj+eg4UeXJy7FQZfXHVrJ72X85xRduCLILBOKVUIY8iIHU+CH/2vpS76JDj+4x1DU0D5+t2 0Nflve4mFllVfpfjuHzzDIFLolKI3xJRUEL/cEnWeWWs9js8VGQPNBFBUjLpIDBJNL6eUp6Pr0f 1ajnn5C0Mhg2LPmohLMSc+nsAldDtKyDvvSi7EMECposH0PtCLb2/Y0IlWY6KQMq3kUGSuVfvhp rQPDaoEzcXVb1tf5uWO5YTAzuHGdqJbpmrYKmlvParZAWV817gfrb5NfdQ== X-Google-Smtp-Source: AGHT+IFavvL4KiHhijdoBljDhK1TLFpK5v6XTUf0Us1LB8DDplKGdxd0qah1kymjEcMqLndwyTkosw== X-Received: by 2002:a05:6000:1847:b0:391:3aaf:1d5d with SMTP id ffacd0b85a97d-39264693cb4mr5790994f8f.27.1741720642000; Tue, 11 Mar 2025 12:17:22 -0700 (PDT) Received: from localhost ([2a0c:5a85:d50e:8e00:c7d4:a3dc:7540:dcad]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3912c0e1476sm18898443f8f.70.2025.03.11.12.17.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Mar 2025 12:17:21 -0700 (PDT) From: Sergio Pastor =?utf-8?b?UMOpcmV6?= Date: Tue, 11 Mar 2025 20:15:25 +0100 Message-ID: X-Mailer: git-send-email 2.48.1 In-Reply-To: <5af801299bc13936ebbd6d1cbc5076dc5f11b463.1741720525.git.sergio.pastorperez@gmail.com> References: <5af801299bc13936ebbd6d1cbc5076dc5f11b463.1741720525.git.sergio.pastorperez@gmail.com> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches From: Sergio Pastor Pérez * gnu/packages/hexedit.scm (imhex): New variable. Change-Id: I114d3a6c0dae32ea434a77a6bd88b8ff6870b70c Reviewed-by: Divya Ranjan Pattanaik --- gnu/packages/hexedit.scm | 169 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 169 insertions(+) diff --git a/gnu/packages/hexedit.scm b/gnu/packages/hexedit.scm index 2eab13e239..e9b9698c22 100644 --- a/gnu/packages/hexedit.scm +++ b/gnu/packages/hexedit.scm @@ -28,11 +28,25 @@ (define-module (gnu packages hexedit) #:use-module (gnu packages) #:use-module (gnu packages autotools) #:use-module (gnu packages compression) + #:use-module (gnu packages gl) #:use-module (gnu packages man) #:use-module (gnu packages cpp) #:use-module (gnu packages gcc) + #:use-module (gnu packages tls) + #:use-module (gnu packages curl) + #:use-module (gnu packages llvm) + #:use-module (gnu packages ruby) + #:use-module (gnu packages glib) + #:use-module (gnu packages boost) + #:use-module (gnu packages backup) #:use-module (gnu packages python) + #:use-module (gnu packages libffi) #:use-module (gnu packages ncurses) + #:use-module (gnu packages antivirus) + #:use-module (gnu packages fontutils) + #:use-module (gnu packages pkg-config) + #:use-module (gnu packages engineering) + #:use-module (gnu packages pretty-print) #:use-module (guix download) #:use-module (guix git-download) #:use-module (guix gexp) @@ -209,6 +223,161 @@ (define-public imhex-pattern-language (description "The Pattern Language used by the ImHex Hex Editor.") (license license:lgpl2.1))) +(define-public imhex + ;; NOTE: imhex-patterns does not support using `imhex-pattern-language' + ;; system package. Until it does, there is no point in making it a package. + (let ((version "1.37.4")) + (define-public imhex-patterns + (let ((name "imhex-patterns")) + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/WerWolv/ImHex-Patterns") + (commit (string-append "ImHex-v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0m9g93fzmj2rsgaq25y4mmfigjh1xxyh41zjs6lp5ydsl5hhrn6q"))))) + (package + (name "imhex") + (version version) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/WerWolv/ImHex") + (commit (string-append "v" version)) + (recursive? #t))) + (file-name (git-file-name name version)) + (sha256 + (base32 "0l3fpizkz2ykdirbn9alddnnsg75w6kwpp92nvmird13l80z1sdr")) + (snippet + #~(begin + (use-modules (guix build utils)) + (define (delete-files-from-list-recursively . args) + (for-each (lambda (path) + (delete-file-recursively path)) + args)) + + (define (replace-files-from-list-recursively lst) + (for-each + (lambda (elt) + (delete-file-recursively (cdr elt)) + (copy-recursively (car elt) (cdr elt))) + lst)) + + ;; NOTE: `libwolf' does not have an install target. Until the + ;; maintainers create one, it will remain bundled. + ;; NOTE: `libromfs' it's meant to be bundled and cannot be + ;; compiled independently. Until the maintainers support + ;; building it independently, it will remain bundled. + ;; NOTE: `imhex-pattern-language' it's meant to be bundled and + ;; cannot be linked independently. Until the maintainers support + ;; linking it independently, it's source will be replaced + ;; in-tree. + (replace-files-from-list-recursively + `((#$(package-source imhex-pattern-language) + . "lib/external/pattern_language"))) + ;; NOTE: `hashlibplus' has been left as a submodule since it's a + ;; fork which only makes sense within ImHex. + (with-directory-excursion "lib/third_party" + (delete-files-from-list-recursively + "nlohmann_json" "capstone" "llvm-demangle" + "fmt" "nativefiledialog" + ;; NOTE: for versions above c++20 it is not required. + "jthread/jthread") + (replace-files-from-list-recursively + `((#$(package-source xdgpp) . "xdgpp") + (#$(file-append miniaudio "/include/miniaudio.h") + . "miniaudio/include/miniaudio.h")))) + + ;; Drop `imhex-patters' in the source tree. + (copy-recursively #$imhex-patterns "ImHex-Patterns"))))) + (build-system cmake-build-system) + (arguments + (list + ;; NOTE: there is an issue with the way the test library is linked + ;; with the output binaries. Tests are intrusive and should not be + ;; shipped with the release, when the issue is fixed we could add a + ;; phase which builds the package with the tests and runs the + ;; testsuite and a second build phase which prepares the output + ;; binary. + #:configure-flags + ''("-DIMHEX_ENABLE_UNIT_TESTS=ON" + "-DIMHEX_OFFLINE_BUILD=ON" + ;; NOTE: required for the `validate-runpath' phase. + ;; If OFF, the pluggings won't be able to find `libimhex.so'. + "-DIMHEX_PLUGIN_ADD_INSTALL_PREFIX_TO_RPATH=ON" + + "-DUSE_SYSTEM_NLOHMANN_JSON=ON" + "-DUSE_SYSTEM_CAPSTONE=ON" + "-DUSE_SYSTEM_LUNASVG=ON" + "-DUSE_SYSTEM_CLI11=ON" + "-DUSE_SYSTEM_BOOST=ON" + "-DUSE_SYSTEM_EDLIB=ON" + "-DUSE_SYSTEM_YARA=ON" + "-DUSE_SYSTEM_LLVM=ON" + "-DUSE_SYSTEM_FMT=ON" + "-DUSE_SYSTEM_NFD=ON" + + ;; NOTE: the build system doesn't correctly support + ;; locating these system libraries. Until fixed + ;; upstream, drop the sources where they are + ;; expected, this is done in the `' snippet. + "-DUSE_SYSTEM_MINIAUDIO=OFF") + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'fix-paths + (lambda _ + (substitute* "main/gui/source/window/linux_window.cpp" + (("dbus-send") + #$(file-append dbus "/bin/dbus-send"))) + (substitute* "cmake/build_helpers.cmake" + (("Boost REQUIRED") + "Boost COMPONENTS regex REQUIRED")))) + (add-before 'check 'build-tests + (lambda _ + (invoke "make" "unit_tests")))))) + (native-inputs + (list cli11 + nlohmann-json + pkg-config + python + python-wrapper + ruby + gcc-14)) + (inputs + (list yara + boost + capstone + curl + edlib + fmt + glfw + libarchive + libffi + llvm-17 + lunasvg + plutovg + mbedtls + mesa + nativefiledialog-extended + xz + fontconfig + lz4 + `(,zstd "lib") + zlib + freetype)) + (home-page "https://imhex.werwolv.net") + (synopsis "Hex Editor to display, decode and analyze binary data") + (description "ImHex is a hex editor with many advanced features that can +often only be found in paid applications. Such features are a completely +custom binary template and pattern language to decode and highlight structures +in the data, a graphical node-based data processor to pre-process values +before they're displayed, a disassembler, diffing support, bookmarks and much +much more.") + (license license:gpl2)))) + (define-public bvi (package (name "bvi")