diff mbox series

[bug#56083] style: Add option '--list-stylings'.

Message ID bad30ecc00bc6c29f22dd515068e010064ebf05e.1655627838.git.h.goebel@crazy-compilers.com
State Accepted
Headers show
Series [bug#56083] style: Add option '--list-stylings'. | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job
cbaines/issue success View issue

Commit Message

Hartmut Goebel June 19, 2022, 8:37 a.m. UTC 
* guix/scripts/style.scm (show-stylings): New procedure.
  (%options, show-help): Add "--list-stylings".
* doc/guix.texi (Invoking guix style): Document "-l".
---
 doc/guix.texi          |  4 ++++
 guix/scripts/style.scm | 11 +++++++++++
 2 files changed, 15 insertions(+)

Comments

M June 19, 2022, 9:02 a.m. UTC | #1 
Hartmut Goebel schreef op zo 19-06-2022 om 10:37 [+0200]:
> +@item --list-stylings
> +@itemx -l
> +List and describe the available styling rule and exit.

Nitpick: ‘styling rule’ -> ‘styling rules’.  Otherwie LGTM.

Greetings,
Maxime.
Hartmut Goebel July 4, 2022, 2:14 p.m. UTC | #2 
Thanks for the review. I fixed it and pushed as 
a3d86b341d361530127c36fbfbf77d638df2c1de.
diff mbox series

Patch

diff --git a/doc/guix.texi b/doc/guix.texi
index 86348fc02c..2768762e62 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -13963,6 +13963,10 @@  The @option{--input-simplification} option described below provides
 fine-grain control over when inputs should be simplified.
 @end table
 
+@item --list-stylings
+@itemx -l
+List and describe the available styling rule and exit.
+
 @item --load-path=@var{directory}
 @itemx -L @var{directory}
 Add @var{directory} to the front of the package module search path
diff --git a/guix/scripts/style.scm b/guix/scripts/style.scm
index 8123570c38..3381a54130 100644
--- a/guix/scripts/style.scm
+++ b/guix/scripts/style.scm
@@ -797,15 +797,26 @@  PACKAGE."
                 (lambda args
                   (show-help)
                   (exit 0)))
+        (option '(#\l "list-stylings") #f #f
+                (lambda args
+                  (show-stylings)
+                  (exit 0)))
         (option '(#\V "version") #f #f
                 (lambda args
                   (show-version-and-exit "guix style")))))
 
+(define (show-stylings)
+  (display (G_ "Available styling rules:\n"))
+  (display (G_ "- format: Format the given package definition(s)\n"))
+  (display (G_ "- inputs: Rewrite package inputs to the “new style”\n")))
+
 (define (show-help)
   (display (G_ "Usage: guix style [OPTION]... [PACKAGE]...
 Update package definitions to the latest style.\n"))
   (display (G_ "
   -S, --styling=RULE     apply RULE, a styling rule"))
+  (display (G_ "
+  -l, --list-stylings   display the list of available style rules"))
   (newline)
   (display (G_ "
   -n, --dry-run          display files that would be edited but do nothing"))