diff mbox series

[bug#61560,Guix,Data,Service] Comparing package derivations: Fix inconsistent verbage.

Message ID b567b089d484aa3eea08063f16bb1dca193f84f7.1676586405.git.leo@famulari.name
State New
Headers show
Series [bug#61560,Guix,Data,Service] Comparing package derivations: Fix inconsistent verbage. | expand

Commit Message

Leo Famulari Feb. 16, 2023, 10:26 p.m. UTC
Harmonize "Build change" options between the selection menu and the documentation

I don't have a preference about which phrase is chosen. Please use your
judgement in fixing this to ensure consistency throughout the user interface.

* guix-data-service/web/compare/html.scm (compare/package-derivations): Replace
"Still broken" with "Still failing" in the "Build change" help text.
---
 guix-data-service/web/compare/html.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Christopher Baines Feb. 17, 2023, 5:11 p.m. UTC | #1
Leo Famulari <leo@famulari.name> writes:

> Harmonize "Build change" options between the selection menu and the documentation
>
> I don't have a preference about which phrase is chosen. Please use your
> judgement in fixing this to ensure consistency throughout the user interface.
>
> * guix-data-service/web/compare/html.scm (compare/package-derivations): Replace
> "Still broken" with "Still failing" in the "Build change" help text.
> ---
>  guix-data-service/web/compare/html.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/guix-data-service/web/compare/html.scm b/guix-data-service/web/compare/html.scm
> index 58fb514..44acb81 100644
> --- a/guix-data-service/web/compare/html.scm
> +++ b/guix-data-service/web/compare/html.scm
> @@ -797,7 +797,7 @@ derivation")
>                             (dd
>                              "At least one successful build for both the base
>  and target derivations")
> -                           (dt "Still broken")
> +                           (dt "Still failing")
>                             (dd
>                              "No successful builds and at least one failed builds for both the base and target derivations")
>                             (dt "Unknown")

Looks good to me, I've pushed this now.

Thanks,

Chris
diff mbox series

Patch

diff --git a/guix-data-service/web/compare/html.scm b/guix-data-service/web/compare/html.scm
index 58fb514..44acb81 100644
--- a/guix-data-service/web/compare/html.scm
+++ b/guix-data-service/web/compare/html.scm
@@ -797,7 +797,7 @@  derivation")
                            (dd
                             "At least one successful build for both the base
 and target derivations")
-                           (dt "Still broken")
+                           (dt "Still failing")
                            (dd
                             "No successful builds and at least one failed builds for both the base and target derivations")
                            (dt "Unknown")