diff mbox series

[bug#63641,1/8] hurd-boot: Add urandom and default-pager translators.

Message ID b3a157c648efc539edfb0c8c16e5166dec583620.1684745752.git.dev@jpoiret.xyz
State New
Headers show
Series Add libc specific to Hurd and update components | expand

Commit Message

Josselin Poiret May 22, 2023, 9:04 a.m. UTC
From: Josselin Poiret <dev@jpoiret.xyz>

* gnu/build/hurd-boot.scm (set-hurd-device-translators): Set up urandom and
default-pager on boot.
---
 gnu/build/hurd-boot.scm | 3 +++
 1 file changed, 3 insertions(+)

Comments

Janneke Nieuwenhuizen May 23, 2023, 9:28 p.m. UTC | #1
Josselin Poiret via Guix-patches via writes:

> From: Josselin Poiret <dev@jpoiret.xyz>
>
> * gnu/build/hurd-boot.scm (set-hurd-device-translators): Set up urandom and
> default-pager on boot.
> ---
>  gnu/build/hurd-boot.scm | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/gnu/build/hurd-boot.scm b/gnu/build/hurd-boot.scm
> index 95c15907dd..14bfc5e809 100644
> --- a/gnu/build/hurd-boot.scm
> +++ b/gnu/build/hurd-boot.scm

Please add your copyright line at the top of the file.

Otherwise, LGTM!
Janneke Nieuwenhuizen May 28, 2023, 8:26 a.m. UTC | #2
Janneke Nieuwenhuizen writes:

> Josselin Poiret via Guix-patches via writes:
>
>> From: Josselin Poiret <dev@jpoiret.xyz>
>>
>> * gnu/build/hurd-boot.scm (set-hurd-device-translators): Set up urandom and
>> default-pager on boot.
>> ---
>>  gnu/build/hurd-boot.scm | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/gnu/build/hurd-boot.scm b/gnu/build/hurd-boot.scm
>> index 95c15907dd..14bfc5e809 100644
>> --- a/gnu/build/hurd-boot.scm
>> +++ b/gnu/build/hurd-boot.scm
>
> Please add your copyright line at the top of the file.
>
> Otherwise, LGTM!

...other than /dev/urandom gets created as a symlink too, so I guess
this should be included too:

modified   gnu/build/hurd-boot.scm
@@ -282,7 +282,6 @@ (define* (set-hurd-device-translators #:optional (root "/"))
     (rename-file (scope "dev/console") (scope "dev/console-")))
   (for-each scope-set-translator devices)
 
-  (false-if-EEXIST (symlink "/dev/random" (scope "dev/urandom")))
   (false-if-EEXIST (symlink "/dev/fd/0" (scope "dev/stdin")))
   (false-if-EEXIST (symlink "/dev/fd/1" (scope "dev/stdout")))
   (false-if-EEXIST (symlink "/dev/fd/2" (scope "dev/stderr")))


(I'm trying to support multiple boots, well a second boot, from the same
device and got hit by this.  Still testing if the removal fixes it for me.)

Greetings,
Janneke
diff mbox series

Patch

diff --git a/gnu/build/hurd-boot.scm b/gnu/build/hurd-boot.scm
index 95c15907dd..14bfc5e809 100644
--- a/gnu/build/hurd-boot.scm
+++ b/gnu/build/hurd-boot.scm
@@ -188,6 +188,7 @@  (define* (set-hurd-device-translators #:optional (root "/"))
       ("servers/crash-suspend"   ("/hurd/crash" "--suspend"))
       ("servers/password"        ("/hurd/password"))
       ("servers/socket/1"        ("/hurd/pflocal"))
+      ("servers/default-pager"   ("/hurd/proxy-defpager"))
       ;; /servers/socket/2 and /26 are created by 'static-networking-service'.
       ;; XXX: Spawn pfinet without arguments on these nodes so that a DHCP
       ;; client has someone to talk to?
@@ -198,6 +199,8 @@  (define* (set-hurd-device-translators #:optional (root "/"))
       ("dev/null"    ("/hurd/null")                         #o666)
       ("dev/random"  ("/hurd/random"   "--seed-file" "/var/lib/random-seed")
                                                             #o644)
+      ("dev/urandom" ("/hurd/random"   "--seed-file" "/var/lib/random-seed"
+                      "--fast")                             #o644)
       ("dev/zero"    ("/hurd/storeio"  "--store-type=zero") #o666)
 
       ("dev/console" ("/hurd/term"     "/dev/console" "device" "console"))