From patchwork Sun Oct 6 16:11:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomas Volf <~@wolfsden.cz> X-Patchwork-Id: 68642 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id EC7CA27BBE9; Sun, 6 Oct 2024 17:13:27 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_ALL,DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id E68AC27BBE2 for ; Sun, 6 Oct 2024 17:13:25 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sxTsQ-0002LG-RN; Sun, 06 Oct 2024 12:12:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sxTsO-0002L5-V7 for guix-patches@gnu.org; Sun, 06 Oct 2024 12:12:56 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sxTsO-0004j7-NI for guix-patches@gnu.org; Sun, 06 Oct 2024 12:12:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=2Ois6kUN7m8h8wLmgMX0he6Bg0LO/PDpXPyawLFSZQk=; b=lre/odM6BBiH+Q/ciODA0k0FqCQXsEmbA4bdTD2CHxiE094P4kATNgqxeawgBsq+fVi1cJV/pXNCAY4Nbsh5QpFskwdH8xW3LnZcBpOV0yzX0Grn676qdUUKpmu8wI1TBcd20lA9xkxNAPCTIgQBDQNbGMteZsU9yLZo89ZW72fF/LbzZEjZZghnqv9E/xSVPob6n7G2eMk4d2hGBM2QQwgkLlIGEcImKaY7esPLPGZP+w+1H2JI61lL9l8K3a03OObpXLipAYsiOpE9hX4peV9cFi5jlcC7ktsYXv7VcjfUTlhjvWbImvHmrG+tLpal2p8BZMV10Uw01U/qDybiVQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sxTsU-0001ul-Mb for guix-patches@gnu.org; Sun, 06 Oct 2024 12:13:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#73664] [PATCH] gnu: libtorrent-rasterbar: Work around hang in test_ssl. Resent-From: Tomas Volf <~@wolfsden.cz> Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 06 Oct 2024 16:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 73664 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 73664@debbugs.gnu.org Cc: Tomas Volf <~@wolfsden.cz> X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.17282311307241 (code B ref -1); Sun, 06 Oct 2024 16:13:02 +0000 Received: (at submit) by debbugs.gnu.org; 6 Oct 2024 16:12:10 +0000 Received: from localhost ([127.0.0.1]:42061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxTre-0001sj-4g for submit@debbugs.gnu.org; Sun, 06 Oct 2024 12:12:10 -0400 Received: from lists.gnu.org ([209.51.188.17]:47272) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1sxTrb-0001sa-UI for submit@debbugs.gnu.org; Sun, 06 Oct 2024 12:12:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1sxTrU-0002Cu-Cz for guix-patches@gnu.org; Sun, 06 Oct 2024 12:12:00 -0400 Received: from wolfsden.cz ([37.205.8.62]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1sxTrR-0004gC-Or for guix-patches@gnu.org; Sun, 06 Oct 2024 12:11:59 -0400 Received: by wolfsden.cz (Postfix, from userid 104) id 5BF28320AF9; Sun, 6 Oct 2024 16:11:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1728231113; bh=VVbAdH2zXS/30KAAJ75B5y+I4+i6r7Mke5rwHWxbtkI=; h=From:To:Cc:Subject:Date; b=aWQIPv5TJUCSE1LDq1/E5Q9ImsoIVA/yq5Ea3A6wM1o3wUM1MK+2rLUjMaLFVxUY3 ql4AAdUPTVx2mlM3JdJnG9M2Z/R51JtaWt+YFacFNG8V//DjSXj9IE4Yx1BGBLd/DX Nv+LLrnWQR70JiVstgUAMaM8GV49wF7NbxEIw3Gf4/T5W4qzNSxRQ3IcvgzhNISwpj xAIUM9Q1GCEw5O19DhgVrkTy/hIXRFJF59Fgh6HGCzCYtwgYBCRUL03jJ+5NKGEIxP Zf+Y++0mqmrMaOqHNM9F15RCCYeT99tIzOWiYdCMlYgne/GM1ySjnHjAT17EsH4o/5 IZkIJUJyVHIvLlcImVv3r7urwHcavcWaIz099kYe7XZlpyZcabonh+CvTEnhiTM6NB hW64hcQM/p3WWX/OKikg4EtZJU5VmRnQPbe/7KCn14V1Su6m/mJKoMZK44GZxWUDLF JPlOPvZXYb4Mmqg8IsHqpRTlSkiRbRoHCgYPpBhtvQmjdl6m/2dzrzIjh5SFF8G2dc XqApU9z/I8jyYJA0QJWFTYG4hns0aryOOY1zSHz5cfoxMMGPFjKQOdKrW8jo6ijD7K goB36V/I9fc75I8UyvBzJV9zTL+1sCYlJJQbjjfA5Bclg2lDlgWQ5FzqrXdRVfggVr PTKxkZFWTabhKnyUc50QGCpQ= Received: from localhost (unknown [146.70.134.132]) by wolfsden.cz (Postfix) with ESMTPSA id E1A6C31EAAE; Sun, 6 Oct 2024 16:11:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1728231113; bh=VVbAdH2zXS/30KAAJ75B5y+I4+i6r7Mke5rwHWxbtkI=; h=From:To:Cc:Subject:Date; b=aWQIPv5TJUCSE1LDq1/E5Q9ImsoIVA/yq5Ea3A6wM1o3wUM1MK+2rLUjMaLFVxUY3 ql4AAdUPTVx2mlM3JdJnG9M2Z/R51JtaWt+YFacFNG8V//DjSXj9IE4Yx1BGBLd/DX Nv+LLrnWQR70JiVstgUAMaM8GV49wF7NbxEIw3Gf4/T5W4qzNSxRQ3IcvgzhNISwpj xAIUM9Q1GCEw5O19DhgVrkTy/hIXRFJF59Fgh6HGCzCYtwgYBCRUL03jJ+5NKGEIxP Zf+Y++0mqmrMaOqHNM9F15RCCYeT99tIzOWiYdCMlYgne/GM1ySjnHjAT17EsH4o/5 IZkIJUJyVHIvLlcImVv3r7urwHcavcWaIz099kYe7XZlpyZcabonh+CvTEnhiTM6NB hW64hcQM/p3WWX/OKikg4EtZJU5VmRnQPbe/7KCn14V1Su6m/mJKoMZK44GZxWUDLF JPlOPvZXYb4Mmqg8IsHqpRTlSkiRbRoHCgYPpBhtvQmjdl6m/2dzrzIjh5SFF8G2dc XqApU9z/I8jyYJA0QJWFTYG4hns0aryOOY1zSHz5cfoxMMGPFjKQOdKrW8jo6ijD7K goB36V/I9fc75I8UyvBzJV9zTL+1sCYlJJQbjjfA5Bclg2lDlgWQ5FzqrXdRVfggVr PTKxkZFWTabhKnyUc50QGCpQ= From: Tomas Volf <~@wolfsden.cz> Date: Sun, 6 Oct 2024 18:11:49 +0200 Message-ID: X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 Received-SPF: pass client-ip=37.205.8.62; envelope-from=~@wolfsden.cz; helo=wolfsden.cz X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches test_ssl does sometimes hang (at least when executed under faketime). It is somewhat unlikely to happen, and (on my machine) required a build with --rounds=32 to reproduce it. The workaround is to set somewhat lower timeout of 240s (expected test duration * 5 rounded up to whole minutes) and retry few times on failure. In this way, --rounds=64 finished successfully (on my machine). At the same time remove the timeout from the other tests, since it is not necessary (they do not hang), and one of them runs for ~270s (almost half the original timeout), so it could pose a problem on slow/overloaded machine. * gnu/packages/bittorrent.scm (libtorrent-rasterbar)[arguments]<#:phases>['check]: Remote test timeout for most tests. Lower the timeout for test_ssl. Retry test_ssl on failure. Change-Id: I535c72fec24658a4b2151d2e8794319055c9a278 --- gnu/packages/bittorrent.scm | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm index 2b38c7cb65..1a0735d928 100644 --- a/gnu/packages/bittorrent.scm +++ b/gnu/packages/bittorrent.scm @@ -452,7 +452,6 @@ (define-public libtorrent-rasterbar (exclude-regex (string-append "^(" (string-join disabled-tests "|") ")$")) - (timeout "600") (jobs (if parallel-tests? (number->string (parallel-job-count)) "1"))) @@ -460,7 +459,6 @@ (define-public libtorrent-rasterbar (invoke "ctest" "-E" exclude-regex "-j" jobs - "--timeout" timeout "--output-on-failure") ;; test_ssl relies on bundled TLS certificates with a fixed ;; expiry date. To ensure succesful builds in the future, @@ -470,16 +468,16 @@ (define-public libtorrent-rasterbar ;; test_fast_extension, test_privacy and test_resolve_links ;; to hang, even with FAKETIME_ONLY_CMDS. Not sure why. So ;; execute only test_ssl under faketime. - ;; - ;; Note: The test_ssl test times out in the ci. - ;; Temporarily disable it until that is resolved. - ;; (invoke "faketime" "2022-10-24" - ;; "ctest" - ;; "-R" "^test_ssl$" - ;; "-j" jobs - ;; "--timeout" timeout - ;; "--output-on-failure") - ))))))) + (invoke "faketime" "2022-10-24" + "ctest" + "-R" "^test_ssl$" + "-j" jobs + ;; test_ssl sometimes hangs (at least when run under + ;; faketime), therefore set a time limit and retry + ;; few times on failure. + "--timeout" "240" + "--repeat" "until-pass:5" + "--output-on-failure")))))))) (inputs (list boost openssl)) (native-inputs (list libfaketime